hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: dblink xid may be duplicated

Browse Source
This commit is contained in:
obdev
2024-02-09 19:13:37 +00:00
committed by ob-robot
parent 1852c21cd5
commit 71301ab305
1 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/storage/tx/ob_xa_dblink_service.cpp
View File

@ -29,6 +29,11 @@ using namespace common::sqlclient;
namespace transaction namespace transaction
{ {
// generate a xid with new gtrid // generate a xid with new gtrid
// xid content:
// gtrid:
// base_version: "$tenant_id.$trans_id.$timestamp"
// using_ipv4: "$tenant_id.$trans_id.$timestamp,$ipv4"
// bqual: "10000"
// @param[out] new_xid // @param[out] new_xid
int ObXAService::generate_xid(const ObTransID &tx_id, ObXATransID &new_xid) int ObXAService::generate_xid(const ObTransID &tx_id, ObXATransID &new_xid)
{ {
@ -37,19 +42,16 @@ int ObXAService::generate_xid(const ObTransID &tx_id, ObXATransID &new_xid)
static const ObString BQUAL_STRING = ObString("10000"); static const ObString BQUAL_STRING = ObString("10000");
// gtrid // gtrid
int64_t txid_value = tx_id.get_id(); int64_t txid_value = tx_id.get_id();
static const char *DBLINK_STR = "DBLINK."; uint64_t tenant_id = MTL_ID();
static const int DBLINK_STR_LENGTH = 7; char gtrid_base_str[ObXATransID::MAX_GTRID_LENGTH] = {0};
char txid_str[ObXATransID::MAX_GTRID_LENGTH]; int64_t timestamp = ObTimeUtility::current_time() / 1000000; // second level
memset(txid_str, 0, ObXATransID::MAX_GTRID_LENGTH); const char *gtrid_base_format = "%llu.%lld.%lld";
int txid_str_length = sprintf(txid_str, "%ld", txid_value); int base_len = snprintf(gtrid_base_str, ObXATransID::MAX_GTRID_LENGTH, gtrid_base_format,
if (ObXATransID::MAX_GTRID_LENGTH < txid_str_length + DBLINK_STR_LENGTH) { tenant_id, txid_value, timestamp);
if (ObXATransID::MAX_GTRID_LENGTH <= base_len || 0 > base_len) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
TRANS_LOG(WARN, "unexpected gtrid length", K(ret), K(txid_str_length)); TRANS_LOG(WARN, "unexpected gtrid length", K(ret), K(base_len));
} else { } else {
char gtrid_str[ObXATransID::MAX_GTRID_LENGTH];
memset(gtrid_str, 0, ObXATransID::MAX_GTRID_LENGTH);
strncpy(gtrid_str, DBLINK_STR, DBLINK_STR_LENGTH);
strncpy(gtrid_str + DBLINK_STR_LENGTH, txid_str, txid_str_length);
ObString gtrid_string; ObString gtrid_string;
if (GCONF.self_addr_.using_ipv4()) { if (GCONF.self_addr_.using_ipv4()) {
char ip_port[MAX_IP_PORT_LENGTH]; char ip_port[MAX_IP_PORT_LENGTH];
@ -57,17 +59,20 @@ int ObXAService::generate_xid(const ObTransID &tx_id, ObXATransID &new_xid)
memset(ip_port, 0, MAX_IP_PORT_LENGTH); memset(ip_port, 0, MAX_IP_PORT_LENGTH);
if (OB_FAIL(GCONF.self_addr_.addr_to_buffer(ip_port, MAX_IP_PORT_LENGTH, ip_str_length))) { if (OB_FAIL(GCONF.self_addr_.addr_to_buffer(ip_port, MAX_IP_PORT_LENGTH, ip_str_length))) {
TRANS_LOG(WARN, "convert server to string failed", K(ret), K(tx_id)); TRANS_LOG(WARN, "convert server to string failed", K(ret), K(tx_id));
} else if (ObXATransID::MAX_GTRID_LENGTH < 1 + ip_str_length + txid_str_length + DBLINK_STR_LENGTH) {
ret = OB_ERR_UNEXPECTED;
TRANS_LOG(WARN, "unexpected gtrid length", K(ret), K(tx_id), K(txid_str_length), K(ip_port), K(ip_str_length));
} else { } else {
const char *comma = ","; const char *gtrid_full_format = "%s,%s";
strncpy(gtrid_str + DBLINK_STR_LENGTH + txid_str_length, comma, 1); char gtrid_full_str[ObXATransID::MAX_GTRID_LENGTH] = {0};
strncpy(gtrid_str + DBLINK_STR_LENGTH + txid_str_length + 1, ip_port, ip_str_length); int full_len = snprintf(gtrid_full_str, ObXATransID::MAX_GTRID_LENGTH, gtrid_full_format,
gtrid_string = ObString(DBLINK_STR_LENGTH + txid_str_length + 1 + ip_str_length, gtrid_str); gtrid_base_str, ip_port);
if (ObXATransID::MAX_GTRID_LENGTH <= full_len || 0 > full_len) {
ret = OB_ERR_UNEXPECTED;
TRANS_LOG(WARN, "unexpected gtrid length", K(ret), K(full_len));
} else {
gtrid_string = ObString(full_len, gtrid_full_str);
}
} }
} else { } else {
gtrid_string = ObString(DBLINK_STR_LENGTH + txid_str_length, gtrid_str); gtrid_string = ObString(base_len, gtrid_base_str);
} }
if (OB_SUCC(ret)) { if (OB_SUCC(ret)) {
ret = new_xid.set(gtrid_string, BQUAL_STRING, DBLINK_FORMAT_ID); ret = new_xid.set(gtrid_string, BQUAL_STRING, DBLINK_FORMAT_ID);