hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] fix onetime expr cause prune index incorrectly

Browse Source
This commit is contained in:
ChangerR
2023-11-15 05:14:18 +00:00
committed by ob-robot
parent 98c4e09fa1
commit 73a2381458
2 changed files with 42 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/sql/optimizer/ob_join_order.cpp
View File

@ -2811,6 +2811,8 @@ int ObJoinOrder::compute_cost_and_prune_access_path(PathHelper &helper,
LOG_WARN("failed to estimate cost", K(ret));
} else if (OB_FAIL(ap->compute_pipeline_info())) {
LOG_WARN("failed to compute pipelined path", K(ret));
} else if (OB_FAIL(ap->compute_valid_inner_path())) {
LOG_WARN("failed to compute inner path with pushdown filters", K(ret));
} else if (!ap->is_inner_path()) {
if (OB_FAIL(add_path(ap))) {
LOG_WARN("failed to add the interesting order");
@ -4611,16 +4613,14 @@ int ObJoinOrder::compute_path_relationship(const Path &first_path,
static_cast<const JoinPath&>(second_path).contain_normal_nl()) {
relation = DominateRelation::OBJ_LEFT_DOMINATE;
OPT_TRACE("left path dominate right path because of normal nl");
} else if (first_path.is_access_path() &&
second_path.is_access_path() &&
static_cast<const AccessPath&>(first_path).est_cost_info_.pushdown_prefix_filters_.empty() &&
!static_cast<const AccessPath&>(second_path).est_cost_info_.pushdown_prefix_filters_.empty()) {
} else if (first_path.is_access_path() && second_path.is_access_path() &&
!static_cast<const AccessPath&>(first_path).is_valid_inner_path_
&& static_cast<const AccessPath&>(second_path).is_valid_inner_path_) {
relation = DominateRelation::OBJ_RIGHT_DOMINATE;
OPT_TRACE("right path dominate left path because of pushdown prefix filters");
} else if (first_path.is_access_path() &&
second_path.is_access_path() &&
!static_cast<const AccessPath&>(first_path).est_cost_info_.pushdown_prefix_filters_.empty() &&
static_cast<const AccessPath&>(second_path).est_cost_info_.pushdown_prefix_filters_.empty()) {
} else if (first_path.is_access_path() && second_path.is_access_path() &&
static_cast<const AccessPath&>(first_path).is_valid_inner_path_
&& !static_cast<const AccessPath&>(second_path).is_valid_inner_path_) {
relation = DominateRelation::OBJ_LEFT_DOMINATE;
OPT_TRACE("left path dominate right path because of pushdown prefix filters");
} else {
@ -5056,6 +5056,7 @@ int AccessPath::assign(const AccessPath &other, common::ObIAllocator *allocator)
for_update_ = other.for_update_;
use_skip_scan_ = other.use_skip_scan_;
use_column_store_ = other.use_column_store_;
is_valid_inner_path_ = other.is_valid_inner_path_;
if (OB_ISNULL(allocator)) {
ret = OB_INVALID_ARGUMENT;
@ -5413,6 +5414,31 @@ const ObIArray<ObNewRange>& AccessPath::get_query_ranges() const
return est_cost_info_.ranges_;
}
int AccessPath::compute_valid_inner_path()
{
int ret = OB_SUCCESS;
is_valid_inner_path_ = false;
if (OB_ISNULL(parent_) || OB_ISNULL(parent_->get_plan())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(parent_), K(ret));
} else {
const ObIArray<ObRawExpr*> &filters = est_cost_info_.pushdown_prefix_filters_;
for (int64_t i = 0; OB_SUCC(ret) && !is_valid_inner_path_ && i < filters.count(); i ++) {
const ObRawExpr *expr = filters.at(i);
if (OB_ISNULL(expr)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected null", K(ret));
} else if (!expr->has_flag(CNT_DYNAMIC_PARAM) ||
expr->has_flag(CNT_ONETIME)) {
// do nothing
} else if (ObOptimizerUtil::find_item(parent_->get_plan()->get_pushdown_filters(), expr)) {
is_valid_inner_path_ = true;
}
}
}
return ret;
}
int FunctionTablePath::assign(const FunctionTablePath &other, common::ObIAllocator *allocator)
{
int ret = OB_SUCCESS;

10
src/sql/optimizer/ob_join_order.h
View File

@ -599,7 +599,8 @@ struct EstimateCostInfo {
table_opt_info_(),
for_update_(false),
use_skip_scan_(OptSkipScanState::SS_UNSET),
use_column_store_(false)
use_column_store_(false),
is_valid_inner_path_(false)
{
}
virtual ~AccessPath() {
@ -668,6 +669,8 @@ struct EstimateCostInfo {
}
return ret;
}
// compute current path is inner path and contribute query ranges
int compute_valid_inner_path();
TO_STRING_KV(K_(table_id),
K_(ref_table_id),
@ -685,7 +688,8 @@ struct EstimateCostInfo {
K_(for_update),
K_(use_das),
K_(use_skip_scan),
K_(use_column_store));
K_(use_column_store),
K_(is_valid_inner_path));
public:
//member variables
uint64_t table_id_;
@ -708,6 +712,8 @@ struct EstimateCostInfo {
bool for_update_;
OptSkipScanState use_skip_scan_;
bool use_column_store_;
// mark this access path is inner path and contribute query range
bool is_valid_inner_path_;
private:
DISALLOW_COPY_AND_ASSIGN(AccessPath);
};