hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix some bugs in boundary cases of optimizer stats

Browse Source
This commit is contained in:
wangt1xiuyi
2024-01-08 07:17:14 +00:00
committed by ob-robot
parent 7064b1ca27
commit 75f71da924
7 changed files with 82 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/sql/optimizer/ob_log_plan.cpp
View File

@ -14432,20 +14432,26 @@ int ObLogPlan::perform_gather_stat_replace(ObLogicalOperator *op)
}
} else {
if (NULL != (group_by = dynamic_cast<ObLogGroupBy *>(op))) {
if (group_by->get_rollup_exprs().empty() && group_by->get_group_by_exprs().count() == 1) {
ObRawExpr* group_by_expr = group_by->get_group_by_exprs().at(0);
if (OB_ISNULL(group_by_expr) || OB_ISNULL(stat_partition_id_expr_) || OB_ISNULL(stat_table_scan_)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(group_by_expr), K(stat_partition_id_expr_), K(stat_table_scan_));
} else if (T_FUN_SYS_CALC_PARTITION_ID != group_by_expr->get_expr_type()) {
// do nothing
} else if (OB_FAIL(stat_gather_replacer_.add_replace_expr(group_by_expr,
stat_partition_id_expr_))) {
LOG_WARN("failed to push back replaced expr", K(ret));
} else if (group_by_expr->get_partition_id_calc_type() == CALC_IGNORE_SUB_PART) {
stat_table_scan_->set_tablet_id_type(1);
} else {
stat_table_scan_->set_tablet_id_type(2);
if (group_by->get_rollup_exprs().empty() && group_by->get_group_by_exprs().count() > 0) {
//bug:
bool found_it = false;//expected only one T_FUN_SYS_CALC_PARTITION_ID in gather stats.
for (int64_t i = 0; OB_SUCC(ret) && !found_it && i < group_by->get_group_by_exprs().count(); ++i) {
ObRawExpr* group_by_expr = group_by->get_group_by_exprs().at(i);
if (OB_ISNULL(group_by_expr) || OB_ISNULL(stat_partition_id_expr_) || OB_ISNULL(stat_table_scan_)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(group_by_expr), K(stat_partition_id_expr_), K(stat_table_scan_));
} else if (T_FUN_SYS_CALC_PARTITION_ID != group_by_expr->get_expr_type()) {
// do nothing
} else if (OB_FAIL(stat_gather_replacer_.add_replace_expr(group_by_expr,
stat_partition_id_expr_))) {
LOG_WARN("failed to push back replaced expr", K(ret));
} else if (group_by_expr->get_partition_id_calc_type() == CALC_IGNORE_SUB_PART) {
stat_table_scan_->set_tablet_id_type(1);
found_it = true;
} else {
stat_table_scan_->set_tablet_id_type(2);
found_it = true;
}
}
}
}