hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add normal_date_expr to the rewriting phase to solve the problem of comparing illegal date constants with date columns.

Browse Source
This commit is contained in:
obdev
2023-09-11 07:10:42 +00:00
committed by ob-robot
parent 68d091760c
commit 794549cf22
12 changed files with 705 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

419
src/sql/engine/expr/ob_expr_align_date4cmp.cpp Normal file
View File

@ -0,0 +1,419 @@
/**
* Copyright (c) 2021 OceanBase
* OceanBase CE is licensed under Mulan PubL v2.
* You can use this software according to the terms and conditions of the Mulan PubL v2.
* You may obtain a copy of Mulan PubL v2 at:
* http://license.coscl.org.cn/MulanPubL-2.0
* THIS SOFTWARE IS PROVIDED ON AN "AS IS" BASIS, WITHOUT WARRANTIES OF ANY KIND,
* EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO NON-INFRINGEMENT,
* MERCHANTABILITY OR FIT FOR A PARTICULAR PURPOSE.
* See the Mulan PubL v2 for more details.
*/
#define USING_LOG_PREFIX SQL_ENG
#include "sql/engine/expr/ob_expr_align_date4cmp.h"
#include "lib/oblog/ob_log.h"
#include "share/object/ob_obj_cast.h"
#include "common/object/ob_obj_compare.h"
#include "lib/timezone/ob_time_convert.h"
#include "sql/resolver/expr/ob_raw_expr.h"
namespace oceanbase
{
using namespace common;
namespace sql
{
static const int8_t DAYS_OF_MON[2][12 + 1] = {
{0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31},
{0, 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}
};
#define IS_LEAP_YEAR(y) ((((y) % 4) == 0 && (((y) % 100) != 0 || ((y) % 400) == 0)) ? 1 : 0)
ObExprAlignDate4Cmp::ObExprAlignDate4Cmp(common::ObIAllocator &alloc)
: ObFuncExprOperator(alloc, T_ALIGN_DATE4CMP, N_ALIGN_DATE4CMP, 3, VALID_FOR_GENERATED_COL, NOT_ROW_DIMENSION)
{
}
int ObExprAlignDate4Cmp::calc_result_type3(ObExprResType &type,
ObExprResType &type1,
ObExprResType &type2,
ObExprResType &type3,
ObExprTypeCtx &type_ctx) const
{
int ret = OB_SUCCESS;
ObRawExpr *raw_expr = get_raw_expr();
ObOpRawExpr *op_expr = static_cast<ObOpRawExpr *>(raw_expr);
if (OB_ISNULL(op_expr) || OB_UNLIKELY(op_expr->get_param_count() != 3)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("op raw expr is null or param_count error", K(ret), K(op_expr));
} else {
ObRawExpr *param3 = op_expr->get_param_expr(2);
if (!param3->is_const_expr()) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("raw expr is not const expr", K(ret), KPC(param3));
} else {
ObConstRawExpr *const_param = static_cast<ObConstRawExpr *>(param3);
if (OB_ISNULL(const_param)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("third child of the expr is null", K(ret), K(const_param));
} else {
if (const_param->get_value().is_null()) {
type.set_null();
} else {
ObObjType res_type = ObObjType(const_param->get_value().get_int());
switch(res_type) {
case ObNullType: {
type.set_null();
break;
}
case ObDateTimeType: {
type.set_datetime();
break;
}
case ObDateType: {
type.set_date();
break;
}
default: {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("unexpected res type.", K(ret), K(res_type));
break;
}
}
}
}
}
}
return ret;
}
int ObExprAlignDate4Cmp::cg_expr(ObExprCGCtx &expr_cg_ctx, const ObRawExpr &raw_expr,
ObExpr &rt_expr) const
{
int ret = OB_SUCCESS;
UNUSED(expr_cg_ctx);
UNUSED(raw_expr);
if (rt_expr.arg_cnt_ != 3) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("the arg_cnt of expr_align_date4cmp error.", K(ret), K(rt_expr.arg_cnt_));
} else if (OB_ISNULL(rt_expr.args_[0]) ||
OB_ISNULL(rt_expr.args_[1]) ||
OB_ISNULL(rt_expr.args_[2])) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("the arg of expr_align_date4cmp is null.", K(ret), K(rt_expr));
} else {
rt_expr.eval_func_ = eval_align_date4cmp;
}
return ret;
}
int ObExprAlignDate4Cmp::eval_align_date4cmp(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &res)
{
int ret = OB_SUCCESS;
ObDatum* date_datum = NULL;
ObDatum* cmp_type_datum = NULL;
ObDatum* res_type_datum = NULL;
DateArgType date_arg_type = NON_DATE;
ObObjType res_type;
ObTime ob_time;
ObObjType date_arg_obj_type = ObMaxType;
if (OB_FAIL(expr.args_[0]->eval(ctx, date_datum))) {
LOG_WARN("expr_align_date4cmp eval arg[0] date fail.", K(ret), K(expr));
} else if (OB_FAIL(expr.args_[1]->eval(ctx, cmp_type_datum))) {
LOG_WARN("expr_align_date4cmp eval arg[1] cmp_type fail.", K(ret), K(expr));
} else if (OB_FAIL(expr.args_[2]->eval(ctx, res_type_datum))) {
LOG_WARN("expr_align_date4cmp eval arg[2] res_type fail.", K(ret), K(expr));
} else {
date_arg_obj_type = expr.args_[0]->datum_meta_.type_;
res_type = ObObjType(res_type_datum->get_int());
if(OB_FAIL(datum_to_ob_time(date_datum, date_arg_obj_type, date_arg_type, ob_time))) {
LOG_WARN("datum_to_ob_time fail.", K(ret), K(date_datum), K(date_arg_obj_type));
}
}
bool offset = false;
const bool is_zero_on_warn = CM_IS_ZERO_ON_WARN(expr.extra_);
if (OB_SUCC(ret)) {
switch(date_arg_type) {
case VALID_DATE: {
const bool is_valid_time = true;
if (OB_FAIL(set_res(res, ob_time, res_type, is_valid_time, offset, is_zero_on_warn))) {
LOG_WARN("set_res fail.", K(ret), K(ob_time), K(res_type));
}
break;
}
case INVALID_DATE: {
bool is_valid_time = false;
int cmp_type = cmp_type_datum->get_int();
// if cmp_type == T_OP_EQ or T_OP_NSEQ or T_OP_NE,
// return null or 0 depending on is_zero_on_warn.
if (cmp_type == T_OP_EQ || cmp_type == T_OP_NSEQ || cmp_type == T_OP_NE) {
if (OB_FAIL(set_res(res, ob_time, res_type, is_valid_time, offset, is_zero_on_warn))) {
LOG_WARN("set_res fail.", K(ret), K(ob_time), K(res_type));
}
} else {
if (day_over_limit(ob_time)) {
offset = (cmp_type == T_OP_GT || cmp_type == T_OP_LE) ? false : true;
set_valid_time_floor(ob_time);
is_valid_time = true;
if (OB_FAIL(set_res(res, ob_time, res_type, is_valid_time, offset, is_zero_on_warn))) {
LOG_WARN("set_res fail.", K(ret), K(ob_time), K(res_type));
}
} else if (OB_FAIL(set_res(res, ob_time, res_type, is_valid_time, offset, is_zero_on_warn))) {
LOG_WARN("set_res fail.", K(ret), K(ob_time), K(res_type));
}
}
break;
}
case NON_DATE: {
const bool is_valid_time = false;
if (OB_FAIL(set_res(res, ob_time, res_type, is_valid_time, offset, is_zero_on_warn))) {
LOG_WARN("set_res fail.", K(ret), K(ob_time), K(res_type));
}
break;
}
case NULL_DATE: {
res.set_null();
break;
}
}
}
return ret;
}
void ObExprAlignDate4Cmp::set_valid_time_floor(ObTime& ob_time)
{
int ret = OB_SUCCESS;
if(IS_LEAP_YEAR(ob_time.parts_[DT_YEAR])) {
ob_time.parts_[DT_MDAY] = DAYS_OF_MON[1][ob_time.parts_[DT_MON]];
} else {
ob_time.parts_[DT_MDAY] = DAYS_OF_MON[0][ob_time.parts_[DT_MON]];
}
ob_time.parts_[DT_HOUR] = HOURS_PER_DAY - 1;
ob_time.parts_[DT_MIN] = MINS_PER_HOUR - 1;
ob_time.parts_[DT_SEC] = SECS_PER_MIN - 1;
ob_time.parts_[DT_USEC] = USECS_PER_SEC - 1;
ob_time.parts_[DT_DATE] = ObTimeConverter::ob_time_to_date(ob_time);
}
bool ObExprAlignDate4Cmp::day_over_limit(const ObTime& ob_time)
{
bool res = true;
if(IS_LEAP_YEAR(ob_time.parts_[DT_YEAR])) {
res = ob_time.parts_[DT_MDAY] > DAYS_OF_MON[1][ob_time.parts_[DT_MON]];
} else {
res = ob_time.parts_[DT_MDAY] > DAYS_OF_MON[0][ob_time.parts_[DT_MON]];
}
return res;
}
int ObExprAlignDate4Cmp::integer_to_ob_time(const int64_t& date,
DateArgType& date_arg_type,
ObTime& ob_time)
{
int ret = OB_SUCCESS;
ObDateSqlMode date_sql_mode;
// First try to perform a lenient type conversion.
// If it fails, it means the value is not convertible to time.
date_sql_mode.allow_invalid_dates_ = true;
date_sql_mode.no_zero_date_ = false;
if (OB_FAIL(ObTimeConverter::int_to_ob_time_with_date(date, ob_time, true, date_sql_mode))) {
date_arg_type = NON_DATE;
ret = OB_SUCCESS;
} else {
// Then perform a strict type conversion check.
// If successful, it indicates a VALID_DATE;
// if unsuccessful, it indicates an INVALID_DATE.
date_sql_mode.allow_invalid_dates_ = false;
date_sql_mode.no_zero_date_ = true;
if (OB_SUCC(ObTimeConverter::validate_datetime(ob_time, false, date_sql_mode))) {
date_arg_type = VALID_DATE;
} else {
date_arg_type = INVALID_DATE;
ret = OB_SUCCESS;
}
}
return ret;
}
int ObExprAlignDate4Cmp::integer_to_ob_time(const ObDatum* date_datum, DateArgType& date_arg_type, ObTime& ob_time) {
return integer_to_ob_time(date_datum->get_int(), date_arg_type, ob_time);
}
int ObExprAlignDate4Cmp::double_to_ob_time(const double& date, DateArgType& date_arg_type, ObTime& ob_time) {
return integer_to_ob_time((int64_t)date, date_arg_type, ob_time);
}
int ObExprAlignDate4Cmp::double_to_ob_time(const ObDatum* date_datum, DateArgType& date_arg_type, ObTime& ob_time) {
return double_to_ob_time(date_datum->get_double(), date_arg_type, ob_time);
}
int ObExprAlignDate4Cmp::number_to_ob_time(const number::ObNumber& date, DateArgType& date_arg_type, ObTime& ob_time) {
int ret = OB_SUCCESS;
int64_t date_int = 0;
if (OB_FAIL(date.extract_valid_int64_with_trunc(date_int))) {
LOG_WARN("extract_valid_int64_with_trunc fail.", K(ret), K(date));
} else if (OB_FAIL(integer_to_ob_time(date_int, date_arg_type, ob_time))) {
LOG_WARN("cast integer to ob_time fail.", K(ret), K(date_int));
}
return ret;
}
int ObExprAlignDate4Cmp::number_to_ob_time(const ObDatum* date_datum, DateArgType& date_arg_type, ObTime& ob_time) {
return number_to_ob_time(date_datum->get_number(), date_arg_type, ob_time);
}
int ObExprAlignDate4Cmp::str_to_ob_time(const ObString& date, DateArgType& date_arg_type, ObTime& ob_time) {
int ret = OB_SUCCESS;
ObDateSqlMode date_sql_mode;
date_sql_mode.allow_invalid_dates_ = true;
date_sql_mode.no_zero_date_ = false;
if (OB_FAIL(ObTimeConverter::str_to_ob_time_with_date(date, ob_time, NULL, true, date_sql_mode))) {
date_arg_type = NON_DATE;
ret = OB_SUCCESS;
} else {
date_sql_mode.allow_invalid_dates_ = false;
date_sql_mode.no_zero_date_ = true;
if (OB_SUCC(ObTimeConverter::validate_datetime(ob_time, false, date_sql_mode))) {
date_arg_type = VALID_DATE;
} else {
date_arg_type = INVALID_DATE;
ret = OB_SUCCESS;
}
}
return ret;
}
int ObExprAlignDate4Cmp::str_to_ob_time(const ObDatum* date_datum, DateArgType& date_arg_type, ObTime& ob_time) {
return str_to_ob_time(date_datum->get_string(), date_arg_type, ob_time);
}
int ObExprAlignDate4Cmp::datum_to_ob_time(const ObDatum* date_datum, const ObObjType& date_arg_obj_type, DateArgType& date_arg_type, ObTime& ob_time)
{
int ret = OB_SUCCESS;
if (date_datum->is_null()) {
date_arg_type = NULL_DATE;
} else if (ob_is_string_type(date_arg_obj_type)) {
if (OB_FAIL(str_to_ob_time(date_datum, date_arg_type, ob_time))) {
LOG_WARN("str_to_ob_time fail.", K(ret), K(date_datum));
}
} else {
switch(date_arg_obj_type) {
case ObNullType: {
date_arg_type = NULL_DATE;
break;
}
case ObTinyIntType:
case ObSmallIntType:
case ObMediumIntType:
case ObInt32Type:
case ObIntType:
case ObUTinyIntType:
case ObUSmallIntType:
case ObUMediumIntType:
case ObUInt32Type:
case ObUInt64Type: {
if (OB_FAIL(integer_to_ob_time(date_datum, date_arg_type, ob_time))) {
LOG_WARN("integer_to_ob_time fail.", K(ret), K(date_datum));
}
break;
}
case ObFloatType:
case ObDoubleType:
case ObUFloatType:
case ObUDoubleType: {
if (OB_FAIL(double_to_ob_time(date_datum, date_arg_type, ob_time))) {
LOG_WARN("double_to_ob_time fail.", K(ret), K(date_datum));
}
break;
}
case ObNumberType:
case ObUNumberType: {
if (OB_FAIL(number_to_ob_time(date_datum, date_arg_type, ob_time))) {
LOG_WARN("number_to_ob_time fail.", K(ret), K(date_datum));
}
break;
}
default: {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("date_arg_obj_type error: ", K(ret), K(date_arg_obj_type));
break;
}
}
}
return ret;
}
int ObExprAlignDate4Cmp::set_res(ObDatum &res, ObTime &ob_time,
const ObObjType &res_type,
const bool is_valid_time,
const bool offset,
const bool is_zero_on_warn)
{
int ret = OB_SUCCESS;
switch(res_type) {
case ObNullType: {
res.set_null();
break;
}
case ObDateTimeType: {
if (!is_valid_time) {
if (is_zero_on_warn) {
res.set_datetime(0);
} else {
res.set_null();
}
} else {
int64_t datetime_value = 0;
ObTimeConvertCtx cvrt_ctx(NULL, false);
if (OB_FAIL(ObTimeConverter::ob_time_to_datetime(ob_time, cvrt_ctx, datetime_value))) {
LOG_WARN("ob_time convert to datetime fail.", K(ret), K(ob_time));
} else {
res.set_datetime(datetime_value + offset);
}
}
break;
}
case ObDateType: {
if (!is_valid_time) {
if (is_zero_on_warn) {
res.set_date(0);
} else {
res.set_null();
}
} else {
int32_t date_value = ObTimeConverter::ob_time_to_date(ob_time);
res.set_date(date_value + offset);
}
break;
}
default: {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("unexpected res type.", K(ret), K(res_type));
break;
}
}
return ret;
}
bool ObExprAlignDate4Cmp::is_align_date4cmp_support_obj_type(const ObObjType& obj_type) {
bool res = false;
if (ObNullType <= obj_type && obj_type <= ObUNumberType) {
res = true;
} else if (ob_is_string_type(obj_type)) {
res = true;
}
return res;
}
}
}

83
src/sql/engine/expr/ob_expr_align_date4cmp.h Normal file
View File

@ -0,0 +1,83 @@
/**
* Copyright (c) 2021 OceanBase
* OceanBase CE is licensed under Mulan PubL v2.
* You can use this software according to the terms and conditions of the Mulan PubL v2.
* You may obtain a copy of Mulan PubL v2 at:
* http://license.coscl.org.cn/MulanPubL-2.0
* THIS SOFTWARE IS PROVIDED ON AN "AS IS" BASIS, WITHOUT WARRANTIES OF ANY KIND,
* EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO NON-INFRINGEMENT,
* MERCHANTABILITY OR FIT FOR A PARTICULAR PURPOSE.
* See the Mulan PubL v2 for more details.
*/
#ifndef _OB_EXPR_ALIGN_DATE4CMP_H_
#define _OB_EXPR_ALIGN_DATE4CMP_H_
#include "sql/engine/expr/ob_expr_operator.h"
namespace oceanbase
{
namespace sql
{
// This expression is used to handle issues encountered when comparing datetime or date type with other types:
// the other type will be converted to an illegal date, resulting in a comparison result that is incompatible with MySQL.
// such as:
// create table t1(c1 int primary key, c2 date);
// insert into t1 values(1, '1998-11-30');
// insert into t1 values(2, '1998-12-01');
// select * from t1 where c2 > '1998-11-31';
// This expression is used to convert illegal date into logical and valid date.
// such as: 1998-11-31 -> 1998-11-30/1998-12-01 depend on compare type.
class ObExprAlignDate4Cmp : public ObFuncExprOperator
{
public:
explicit ObExprAlignDate4Cmp(common::ObIAllocator &alloc);
virtual ~ObExprAlignDate4Cmp() {};
virtual int calc_result_type3(ObExprResType &type,
ObExprResType &type1,
ObExprResType &type2,
ObExprResType &type3,
common::ObExprTypeCtx &type_ctx) const;
virtual int cg_expr(ObExprCGCtx &expr_cg_ctx, const ObRawExpr &raw_expr,
ObExpr &rt_expr) const override;
static int eval_align_date4cmp(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &res);
static bool is_align_date4cmp_support_obj_type(const ObObjType& obj_type);
enum DateArgType
{
VALID_DATE = 1,
INVALID_DATE = 2,
NON_DATE = 3,
NULL_DATE = 4,
};
private:
//disallow copy
DISALLOW_COPY_AND_ASSIGN(ObExprAlignDate4Cmp);
static bool day_over_limit(const ObTime &ob_time);
static void set_valid_time_floor(ObTime &ob_time);
static int integer_to_ob_time(const int64_t &date, DateArgType &date_arg_type, ObTime &ob_time);
static int integer_to_ob_time(const ObDatum *date_datum, DateArgType &date_arg_type, ObTime &ob_time);
static int double_to_ob_time(const double &date, DateArgType &date_arg_type, ObTime &ob_time);
static int double_to_ob_time(const ObDatum *date_datum, DateArgType &date_arg_type, ObTime &ob_time);
static int number_to_ob_time(const number::ObNumber &date, DateArgType &date_arg_type, ObTime &ob_time);
static int number_to_ob_time(const ObDatum *date_datum, DateArgType &date_arg_type, ObTime &ob_time);
static int str_to_ob_time(const ObString &date, DateArgType &date_arg_type, ObTime &ob_time);
static int str_to_ob_time(const ObDatum *date_datum, DateArgType &date_arg_type, ObTime &ob_time);
static int datum_to_ob_time(const ObDatum *date_datum,
const ObObjType &date_arg_obj_type,
DateArgType &date_arg_type,
ObTime &ob_time);
static int set_res(ObDatum &res, ObTime &ob_time,
const ObObjType &res_type,
const bool is_valid_time,
const bool offset,
const bool is_zero_on_warn);
};
}
}
#endif /* _OB_EXPR_ALIGN_DATE4CMP_H_ */

2
src/sql/engine/expr/ob_expr_eval_functions.cpp
View File

@ -333,6 +333,7 @@
#include "ob_expr_prefix_pattern.h"
#include "ob_expr_initcap.h"
#include "ob_expr_temp_table_ssid.h"
#include "ob_expr_align_date4cmp.h"
namespace oceanbase
{
@ -1036,6 +1037,7 @@ static ObExpr::EvalFunc g_expr_eval_functions[] = {
ObExprJoinFilter::eval_in_filter, /* 605 */
ObExprCurrentScn::eval_current_scn, /* 606 */
ObExprTempTableSSID::calc_temp_table_ssid, /* 607 */
ObExprAlignDate4Cmp::eval_align_date4cmp, /* 608 */
};
static ObExpr::EvalBatchFunc g_expr_eval_batch_functions[] = {

2
src/sql/engine/expr/ob_expr_operator_factory.cpp
View File

@ -402,6 +402,7 @@
#include "sql/engine/expr/ob_expr_xmlcast.h"
#include "sql/engine/expr/ob_expr_update_xml.h"
#include "sql/engine/expr/ob_expr_temp_table_ssid.h"
#include "sql/engine/expr/ob_expr_align_date4cmp.h"
using namespace oceanbase::common;
namespace oceanbase
@ -997,6 +998,7 @@ void ObExprOperatorFactory::register_expr_operators()
REG_OP(ObExprRandom);
REG_OP(ObExprRandstr);
REG_OP(ObExprPrefixPattern);
REG_OP(ObExprAlignDate4Cmp);
}();
// 注册oracle系统函数
REG_OP_ORCL(ObExprSysConnectByPath);