hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[UPGRADE] Remove unused compatible code

Browse Source
This commit is contained in:
tino247
2022-11-21 07:29:40 +00:00
committed by wangzelin.wzl
parent cd2a883c13
commit 7d8c4a42fc
67 changed files with 509 additions and 1339 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/share/stat/ob_opt_stat_sql_service.cpp
View File

@ -1125,15 +1125,6 @@ int ObOptStatSqlService::fill_table_stat(common::sqlclient::ObMySQLResult &resul
EXTRACT_INT_FIELD_TO_CLASS_MYSQL(result, partition_id, stat, int64_t);
EXTRACT_INT_FIELD_TO_CLASS_MYSQL(result, object_type, stat, int64_t);
EXTRACT_INT_FIELD_TO_CLASS_MYSQL(result, row_count, stat, int64_t);
// if (GET_MIN_CLUSTER_VERSION() < CLUSTER_VERSION_3200) {
// EXTRACT_INT_FIELD_TO_CLASS_MYSQL(result, avg_row_size, stat, int64_t);
// } else {
// EXTRACT_DOUBLE_FIELD_TO_CLASS_MYSQL(result, avg_row_size, stat, double);
// }
// why not use GET_MIN_CLUSTER_VERSION to check result is int64_t or double?
// Because there has a corner case. When execute inner sql, min cluster verion is 3100.
// inner sql will select __all_table_stat and avg_row_size is int64_t. When fill table
// min cluster version is 3200, but avg_row_size result is int64_t, not double.
if (OB_SUCC(ret)) {
if (OB_FAIL(result.get_type("avg_row_size", obj_type))) {
LOG_WARN("failed to get type", K(ret));