From 7fb8601792c10949453ac698eb42ecc46cfc5212 Mon Sep 17 00:00:00 2001
From: obdev <obdev@oceanbase.com>
Date: Thu, 12 Dec 2024 06:16:04 +0000
Subject: [PATCH] optimise mview clean snapshot for backup

---
 .../mview/ob_mview_clean_snapshot_task.cpp    | 48 +++++++++++++++++++
 .../mview/ob_mview_clean_snapshot_task.h      |  1 +
 2 files changed, 49 insertions(+)

diff --git a/src/rootserver/mview/ob_mview_clean_snapshot_task.cpp b/src/rootserver/mview/ob_mview_clean_snapshot_task.cpp
index 4f2fed9d9..b81e8cf4a 100644
--- a/src/rootserver/mview/ob_mview_clean_snapshot_task.cpp
+++ b/src/rootserver/mview/ob_mview_clean_snapshot_task.cpp
@@ -25,6 +25,7 @@
 #include "storage/mview/ob_mview_refresh_stats_purge.h"
 #include "storage/compaction/ob_tenant_freeze_info_mgr.h"
 #include "sql/resolver/mv/ob_mv_dep_utils.h"
+#include "share/backup/ob_backup_data_table_operator.h"
 
 namespace oceanbase {
 namespace rootserver {
@@ -125,7 +126,10 @@ void ObMViewCleanSnapshotTask::runTimerTask()
     share::ObSnapshotTableProxy snapshot_proxy;
     const bool select_for_update = true;
     ObSEArray<share::ObSnapshotInfo, 4> snapshots;
+    ObArray<share::ObBackupJobAttr> backup_jobs;
+    uint64_t meta_tenant_id = gen_meta_tenant_id(tenant_id_);
     bool mview_in_creation = false;
+    bool space_danger = false;
     if (OB_FAIL(stat_proxy.get_major_refresh_mv_merge_scn(select_for_update,
                                                           major_refresh_mv_merge_scn))) {
       LOG_WARN("fail to get major_refresh_mv_merge_scn", KR(ret), K(tenant_id_));
@@ -143,6 +147,13 @@ void ObMViewCleanSnapshotTask::runTimerTask()
       // when a mview is being created, its snapshot may be added but the dependency is not
       // added yet, which can cause cleaning the snapshot by mistake. so we just skip this round.
       LOG_INFO("mview is being created, skip clean task", KR(ret), K(tenant_id_));
+    } else if (OB_FAIL(share::ObBackupJobOperator::get_jobs(
+                   *sql_proxy, meta_tenant_id, false /*select for update*/, backup_jobs))) {
+      LOG_WARN("failed to get backup jobs", K(ret), K(tenant_id_));
+    } else if (!backup_jobs.empty() && OB_FAIL(check_space_occupy_(space_danger))) {
+      LOG_WARN("backup jobs exist, check space occupy failed", KR(ret), K(tenant_id_));
+    } else if (!backup_jobs.empty() && !space_danger) {
+      LOG_INFO("backup jobs exist, space is not in danger just skip clean", KR(ret), K(tenant_id_));
     } else {
       uint64_t last_tablet_id = 0;
       // considering the task is scheduled infrequently, performance should not be a concern here,
@@ -248,5 +259,42 @@ int ObMViewCleanSnapshotTask::is_mv_container_table_(const uint64_t table_id, bo
 
   return ret;
 }
+
+int ObMViewCleanSnapshotTask::check_space_occupy_(bool &space_danger)
+{
+  int ret = OB_SUCCESS;
+  ObSqlString sql;
+  space_danger = false;
+
+  SMART_VAR(ObMySQLProxy::MySQLResult, res)
+  {
+    common::sqlclient::ObMySQLResult *result = nullptr;
+    if (OB_FAIL(sql.assign("select CAST(max(DATA_DISK_IN_USE/DATA_DISK_ALLOCATED)*100 as SIGNED) occupy from oceanbase.gv$ob_servers"))) {
+      LOG_WARN("fail to assign sql", KR(ret));
+    } else if (OB_FAIL(GCTX.sql_proxy_->read(res, sql.ptr()))) {
+      LOG_WARN("execute sql failed", KR(ret), K(sql));
+    } else if (OB_ISNULL(result = res.get_result())) {
+      ret = OB_ERR_UNEXPECTED;
+      LOG_WARN("result is null", KR(ret));
+    } else if (OB_FAIL(result->next())) {
+      LOG_WARN("fail to get next", KR(ret));
+    } else {
+      int64_t occupy = 0;
+      EXTRACT_INT_FIELD_MYSQL(*result, "occupy", occupy, int64_t);
+      int64_t upper_bound = GCONF._datafile_usage_upper_bound_percentage;
+      LOG_INFO("check_space_occupy", KR(ret), K(occupy), K(upper_bound), K(sql));
+      if (OB_SUCC(ret)) {
+        if (occupy >= GCONF._datafile_usage_upper_bound_percentage) {
+          space_danger = true;
+          LOG_ERROR("space in danger", K(occupy), K(upper_bound));
+        }
+      }
+    }
+  }
+
+  return ret;
+}
+
+
 } // namespace rootserver
 } // namespace oceanbase
diff --git a/src/rootserver/mview/ob_mview_clean_snapshot_task.h b/src/rootserver/mview/ob_mview_clean_snapshot_task.h
index 21a9c4e8b..a5e587c19 100644
--- a/src/rootserver/mview/ob_mview_clean_snapshot_task.h
+++ b/src/rootserver/mview/ob_mview_clean_snapshot_task.h
@@ -39,6 +39,7 @@ public:
 private:
   int get_table_id_(ObISQLClient &sql_client, const uint64_t tablet_id, uint64_t &table_id);
   int is_mv_container_table_(const uint64_t table_id, bool &is_container);
+  int check_space_occupy_(bool &space_danger);
 private:
   bool is_inited_;
   bool in_sched_;