hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Use ObFunction correctly

Browse Source
This commit is contained in:
obdev 2024-09-20 06:13:42 +00:00 committed by ob-robot
parent 45b11fd0ce
commit 86016b1b0f
2 changed files with 158 additions and 132 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

126
src/storage/blocksstable/cs_encoding/ob_integer_column_decoder.cpp
View File

@ -242,21 +242,23 @@ int ObIntegerColumnDecoder::comparison_operator(
} else {
ObDatumCmpFuncType type_cmp_func = filter.cmp_func_;
ObGetFilterCmpRetFunc get_cmp_ret = get_filter_cmp_ret_func(op_type);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> eval =
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int cmp_ret = 0;
if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(0), cmp_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (get_cmp_ret(cmp_ret)) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(ret), K(idx));
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> eval;
if (OB_FAIL(eval.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int cmp_ret = 0;
if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(0), cmp_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (get_cmp_ret(cmp_ret)) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(ret), K(idx));
}
}
}
return tmp_ret;
};
if (OB_FAIL(tranverse_datum_all_op(ctx, pd_filter_info, result_bitmap, eval))) {
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
} else if (OB_FAIL(tranverse_datum_all_op(ctx, pd_filter_info, result_bitmap, eval))) {
LOG_WARN("fail to traverse_datum in cmp_op", KR(ret), K(ctx));
}
}
@ -391,26 +393,28 @@ int ObIntegerColumnDecoder::between_operator(
ObDatumCmpFuncType type_cmp_func = filter.cmp_func_;
ObGetFilterCmpRetFunc get_le_cmp_ret = get_filter_cmp_ret_func(sql::WHITE_OP_LE);
ObGetFilterCmpRetFunc get_ge_cmp_ret = get_filter_cmp_ret_func(sql::WHITE_OP_GE);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> eval =
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int ge_ret = 0;
int le_ret = 0;
if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(0), ge_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (!get_ge_cmp_ret(ge_ret)) {
// skip
} else if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(1), le_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (!get_le_cmp_ret(le_ret)) {
// skip
} else if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
}
return tmp_ret;
};
if (OB_FAIL(tranverse_datum_all_op(ctx, pd_filter_info, result_bitmap, eval))) {
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> eval;
if (OB_FAIL(eval.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int ge_ret = 0;
int le_ret = 0;
if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(0), ge_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (!get_ge_cmp_ret(ge_ret)) {
// skip
} else if (OB_TMP_FAIL(type_cmp_func(cur_datum, filter.get_datums().at(1), le_ret))) {
LOG_WARN("fail to compare datums", K(tmp_ret), K(cur_datum), K(filter.get_datums()));
} else if (!get_le_cmp_ret(le_ret)) {
// skip
} else if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
}
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
} else if (OB_FAIL(tranverse_datum_all_op(ctx, pd_filter_info, result_bitmap, eval))) {
LOG_WARN("fail to tranverse datum in bt_op", KR(ret), K(ctx));
}
}
@ -526,33 +530,39 @@ int ObIntegerColumnDecoder::in_operator(
storage::ObFilterInCmpType cmp_type = storage::get_filter_in_cmp_type(pd_filter_info.count_, filter.get_datums().count(), false);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> eval;
if (cmp_type == storage::ObFilterInCmpType::BINARY_SEARCH) {
eval = [&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (OB_TMP_FAIL(filter.exist_in_datum_array(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in array", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
if (OB_FAIL(eval.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (OB_TMP_FAIL(filter.exist_in_datum_array(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in array", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
}
}
}
return tmp_ret;
};
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
} else if (cmp_type == storage::ObFilterInCmpType::HASH_SEARCH) {
eval = [&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (OB_TMP_FAIL(filter.exist_in_set(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in hashset", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
if (OB_FAIL(eval.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (OB_TMP_FAIL(filter.exist_in_set(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in hashset", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set result bitmap", KR(tmp_ret), K(idx));
}
}
}
return tmp_ret;
};
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
} else {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("Unexpected filter in compare type", KR(ret), K(cmp_type));

164
src/storage/blocksstable/cs_encoding/ob_string_column_decoder.cpp
View File

@ -470,19 +470,22 @@ int ObStringColumnDecoder::nunn_operator(
const bool is_fixed_len_str = ctx.str_ctx_->meta_.is_fixed_len_string();
const bool need_padding = (ctx.obj_meta_.is_fixed_len_char_type() && nullptr != ctx.col_param_);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle =
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
if (cur_datum.is_null()) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle;
if (OB_FAIL(op_handle.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
if (cur_datum.is_null()) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
}
}
}
return tmp_ret;
};
if (is_fixed_len_str) {
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
if (OB_FAIL(ret)) {
} else if (is_fixed_len_str) {
ret = filter_tranverse_datum_[FIX_STRING_OFFSET_WIDTH_V]
[ctx.null_flag_]
[need_padding] (ctx, row_start, row_count, op_handle);
@ -518,22 +521,25 @@ int ObStringColumnDecoder::comparison_operator(
const common::ObCmpOp &cmp_op = sql::ObPushdownWhiteFilterNode::WHITE_OP_TO_CMP_OP[op_type];
const bool need_padding = (ctx.obj_meta_.is_fixed_len_char_type() && nullptr != ctx.col_param_);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle =
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool cmp_ret = false;
if (OB_TMP_FAIL(compare_datum(cur_datum, filter_datum, filter.cmp_func_, cmp_op, cmp_ret))) {
LOG_WARN("Failed to compare datum", K(tmp_ret), K(cur_datum), K(filter_datum), K(cmp_op));
} else if ((!cur_datum.is_null()) && cmp_ret) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle;
if (OB_FAIL(op_handle.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool cmp_ret = false;
if (OB_TMP_FAIL(compare_datum(cur_datum, filter_datum, filter.cmp_func_, cmp_op, cmp_ret))) {
LOG_WARN("Failed to compare datum", K(tmp_ret), K(cur_datum), K(filter_datum), K(cmp_op));
} else if ((!cur_datum.is_null()) && cmp_ret) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
}
}
}
return tmp_ret;
};
if (is_fixed_len_str) {
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
if (OB_FAIL(ret)) {
} else if (is_fixed_len_str) {
ret = filter_tranverse_datum_[FIX_STRING_OFFSET_WIDTH_V]
[ctx.null_flag_]
[need_padding] (ctx, row_start, row_count, op_handle);
@ -561,35 +567,41 @@ int ObStringColumnDecoder::in_operator(
ObFilterInCmpType cmp_type = get_filter_in_cmp_type(row_count, filter.get_datums().count(), false);
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle;
if (cmp_type == ObFilterInCmpType::BINARY_SEARCH) {
op_handle = [&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (cur_datum.is_null()) {
} else if (OB_TMP_FAIL(filter.exist_in_datum_array(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in array", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
if (OB_FAIL(op_handle.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (cur_datum.is_null()) {
} else if (OB_TMP_FAIL(filter.exist_in_datum_array(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in array", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
}
}
}
return tmp_ret;
};
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
} else if (cmp_type == ObFilterInCmpType::HASH_SEARCH) {
op_handle = [&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (cur_datum.is_null()) {
} else if (OB_TMP_FAIL(filter.exist_in_set(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in hashset", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
if (OB_FAIL(op_handle.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
bool is_exist = false;
if (cur_datum.is_null()) {
} else if (OB_TMP_FAIL(filter.exist_in_set(cur_datum, is_exist))) {
LOG_WARN("fail to check datum in hashset", KR(tmp_ret), K(cur_datum));
} else if (is_exist) {
if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
}
}
}
return tmp_ret;
};
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
} else {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("Unexpected filter in compare type", KR(ret), K(cmp_type));
@ -622,28 +634,32 @@ int ObStringColumnDecoder::bt_operator(
const bool need_padding = (ctx.obj_meta_.is_fixed_len_char_type() && nullptr != ctx.col_param_);
const bool is_fixed_len_str = ctx.str_ctx_->meta_.is_fixed_len_string();
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle =
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int left_cmp_ret = 0;
int right_cmp_ret = 0;
if (cur_datum.is_null()) {
// skip
} else if (OB_TMP_FAIL(filter.cmp_func_(cur_datum, left_ref_datum, left_cmp_ret))) {
LOG_WARN("fail to compare datums", KR(tmp_ret), K(idx), K(cur_datum), K(left_ref_datum));
} else if (left_cmp_ret < 0) {
// skip
} else if (OB_TMP_FAIL(filter.cmp_func_(cur_datum, right_ref_datum, right_cmp_ret))) {
LOG_WARN("fail to compare datums", KR(tmp_ret), K(idx), K(cur_datum), K(right_ref_datum));
} else if (right_cmp_ret > 0) {
// skip
} else if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
ObFunction<int(const ObDatum &cur_datum, const int64_t idx)> op_handle;
if (OB_FAIL(op_handle.assign(
[&] (const ObDatum &cur_datum, const int64_t idx)
{
int tmp_ret = OB_SUCCESS;
int left_cmp_ret = 0;
int right_cmp_ret = 0;
if (cur_datum.is_null()) {
// skip
} else if (OB_TMP_FAIL(filter.cmp_func_(cur_datum, left_ref_datum, left_cmp_ret))) {
LOG_WARN("fail to compare datums", KR(tmp_ret), K(idx), K(cur_datum), K(left_ref_datum));
} else if (left_cmp_ret < 0) {
// skip
} else if (OB_TMP_FAIL(filter.cmp_func_(cur_datum, right_ref_datum, right_cmp_ret))) {
LOG_WARN("fail to compare datums", KR(tmp_ret), K(idx), K(cur_datum), K(right_ref_datum));
} else if (right_cmp_ret > 0) {
// skip
} else if (OB_TMP_FAIL(result_bitmap.set(idx))) {
LOG_WARN("fail to set", KR(tmp_ret), K(idx), K(row_start));
}
return tmp_ret;
}))) {
LOG_WARN("assign function failed", K(ret));
}
return tmp_ret;
};
if (is_fixed_len_str) {
if (OB_FAIL(ret)) {
} else if (is_fixed_len_str) {
ret = filter_tranverse_datum_[FIX_STRING_OFFSET_WIDTH_V]
[ctx.null_flag_]
[need_padding] (ctx, row_start, row_count, op_handle);