From 88411907ee8d64ffe33a9afccd56bdba0a0cf57b Mon Sep 17 00:00:00 2001 From: obdev Date: Thu, 8 Feb 2024 03:45:05 +0000 Subject: [PATCH] fix direct load no tx desc --- src/storage/lob/ob_lob_manager.cpp | 3 +-- src/storage/lob/ob_lob_meta.cpp | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/storage/lob/ob_lob_manager.cpp b/src/storage/lob/ob_lob_manager.cpp index 37b7718542..3edec2cb82 100644 --- a/src/storage/lob/ob_lob_manager.cpp +++ b/src/storage/lob/ob_lob_manager.cpp @@ -1178,8 +1178,7 @@ int ObLobManager::init_out_row_ctx( if (nullptr != param.tx_desc_) { param.seq_no_st_ = param.tx_desc_->get_and_inc_tx_seq(param.parent_seq_no_.get_branch(), N); } else { - int tmp_seq = ObSequence::get_and_inc_max_seq_no(N); - param.seq_no_st_ = transaction::ObTxSEQ::mk_v0(tmp_seq); + // do nothing, for direct load has no tx desc, do not use seq no } param.used_seq_cnt_ = 0; param.total_seq_cnt_ = N; diff --git a/src/storage/lob/ob_lob_meta.cpp b/src/storage/lob/ob_lob_meta.cpp index 0a32629c3e..daba2eff3c 100644 --- a/src/storage/lob/ob_lob_meta.cpp +++ b/src/storage/lob/ob_lob_meta.cpp @@ -861,6 +861,8 @@ int ObLobMetaWriteIter::get_next_row(ObLobMetaWriteResult &row) ObLobCommon *lob_common = reinterpret_cast(lob_common_); ObLobData *lob_data = reinterpret_cast(lob_common->buffer_); lob_data->byte_size_ += row.info_.byte_len_; + // FIXME @haozheng direct load has no tx desc info, therefore do not need modified outrow ctx here + // maybe later we should need to update outrow ctx here for cdc // refresh char len char *ptr = reinterpret_cast(lob_common_); int64_t *len = reinterpret_cast(ptr + ObLobManager::LOB_WITH_OUTROW_CTX_SIZE);