From 88dad848e0e5aac04840b39bb5e29226eb3352fe Mon Sep 17 00:00:00 2001
From: yishenglanlingzui <395329313@qq.com>
Date: Tue, 16 Aug 2022 11:51:22 +0800
Subject: [PATCH] [CP] fix bug insert on duplicate key update with unexpected
 error_no 5024

---
 src/sql/code_generator/ob_code_generator_impl.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sql/code_generator/ob_code_generator_impl.cpp b/src/sql/code_generator/ob_code_generator_impl.cpp
index 4fc68416f..476a6c08b 100644
--- a/src/sql/code_generator/ob_code_generator_impl.cpp
+++ b/src/sql/code_generator/ob_code_generator_impl.cpp
@@ -5143,7 +5143,8 @@ int ObCodeGeneratorImpl::convert_multi_table_insert_up_info(
         }
       }
     }
-    if (OB_SUCC(ret) && !index_dml_info.assignments_.empty()) {
+    if (OB_SUCC(ret)) {
+      // must generate insert and delete subplan for all data_table and global index_table, for multi_insert_up
       // delete subplan will be produced by update operation of insert_up
       // so if assignments is empty, it indicates no need to generate delete subplan
       OZ(convert_delete_subplan(op, index_dml_info, update_row_desc, subplans.at(ObMultiTableInsertUp::DELETE_OP)));