From 8d22244e436afbaf681e2ef75bc47a77ba01f7e3 Mon Sep 17 00:00:00 2001
From: obdev <obdev@oceanbase.com>
Date: Thu, 22 Feb 2024 09:15:51 +0000
Subject: [PATCH] disable select * from __all_virtual_mds_node_stat

---
 .../virtual_table/ob_all_virtual_mds_node_stat.cpp   | 12 +-----------
 src/share/stat/ob_dbms_stats_utils.cpp               |  4 +++-
 .../r/mysql/desc_virtual_table_in_mysql.result       |  6 ++----
 .../r/mysql/desc_virtual_table_in_sys.result         |  6 ++----
 4 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/src/observer/virtual_table/ob_all_virtual_mds_node_stat.cpp b/src/observer/virtual_table/ob_all_virtual_mds_node_stat.cpp
index 244f0cfc35..f5da5d4b55 100644
--- a/src/observer/virtual_table/ob_all_virtual_mds_node_stat.cpp
+++ b/src/observer/virtual_table/ob_all_virtual_mds_node_stat.cpp
@@ -295,17 +295,7 @@ int ObAllVirtualMdsNodeStat::get_tablet_info_(ObLS &ls, const ObFunction<int(ObT
     MDS_LOG(ERROR, "invalid ob function", KR(ret), K(key_ranges_), K(*this));
   } else {
     if (!tablet_ranges_.empty()) {// scan
-      if (OB_FAIL(ObTenantMdsService::for_each_tablet_in_ls(ls, [&ret, &apply_on_tablet_op, this](ObTablet &tablet) {
-        common::ObTabletID tablet_id = tablet.get_tablet_meta().tablet_id_;
-        if (judege_in_ranges(tablet_id, tablet_ranges_) || in_selected_points_(tablet_id)) {
-          if (OB_FAIL(apply_on_tablet_op(tablet))) {
-            MDS_LOG(WARN, "fail to apply op on tablet", KR(ret), K(key_ranges_), K(*this));
-          }
-        }
-        return ret;
-      }))) {
-        MDS_LOG(WARN, "fail to do for_each tablet in ls", KR(ret), K(key_ranges_), K(*this));
-      }
+      ret = OB_NOT_SUPPORTED;
     } else if (!tablet_points_.empty()) {// point select
       for (int64_t idx = 0; idx < tablet_points_.count() && OB_SUCC(ret); ++idx) {
         ObTabletHandle tablet_handle;
diff --git a/src/share/stat/ob_dbms_stats_utils.cpp b/src/share/stat/ob_dbms_stats_utils.cpp
index 233ee384c0..e54a2e0cb2 100644
--- a/src/share/stat/ob_dbms_stats_utils.cpp
+++ b/src/share/stat/ob_dbms_stats_utils.cpp
@@ -10,6 +10,7 @@
  * See the Mulan PubL v2 for more details.
  */
 
+#include "share/inner_table/ob_inner_table_schema_constants.h"
 #define USING_LOG_PREFIX SQL_ENG
 #include "ob_dbms_stats_utils.h"
 #include "share/stat/ob_opt_column_stat.h"
@@ -270,7 +271,8 @@ bool ObDbmsStatsUtils::is_no_stat_virtual_table(const int64_t table_id)
          table_id == share::OB_ALL_VIRTUAL_TRANS_STAT_ORA_TID ||
          table_id == share::OB_ALL_VIRTUAL_OPT_STAT_GATHER_MONITOR_ORA_TID ||
          table_id == share::OB_ALL_VIRTUAL_TRANS_LOCK_STAT_ORA_TID ||
-         table_id == share::OB_ALL_VIRTUAL_TRANS_SCHEDULER_ORA_TID;
+         table_id == share::OB_ALL_VIRTUAL_TRANS_SCHEDULER_ORA_TID ||
+         table_id == share::OB_ALL_VIRTUAL_MDS_NODE_STAT_TID;
 }
 
 bool ObDbmsStatsUtils::is_virtual_index_table(const int64_t table_id)
diff --git a/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_mysql.result b/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_mysql.result
index 07d0b77404..61046d1729 100644
--- a/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_mysql.result
+++ b/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_mysql.result
@@ -3578,11 +3578,9 @@ state	longtext	NO		NULL
 position	longtext	NO		NULL	
 user_data	longtext	NO		NULL	
 select /*+QUERY_TIMEOUT(60000000)*/ IF(count(*) >= 0, 1, 0) from oceanbase.__all_virtual_mds_node_stat;
-IF(count(*) >= 0, 1, 0)
-1
+ERROR 0A000: Not supported feature or function
 "oceanbase.__all_virtual_mds_node_stat runs in single server"
-IF(count(*) >= 0, 1, 0)
-1
+ERROR 0A000: Not supported feature or function
 desc oceanbase.__all_virtual_mds_event_history;
 Field	Type	Null	Key	Default	Extra
 tenant_id	bigint(20)	NO	PRI	NULL	
diff --git a/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_sys.result b/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_sys.result
index 192f5813f1..53171f5780 100644
--- a/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_sys.result
+++ b/tools/deploy/mysql_test/test_suite/inner_table/r/mysql/desc_virtual_table_in_sys.result
@@ -7850,11 +7850,9 @@ state	longtext	NO		NULL
 position	longtext	NO		NULL	
 user_data	longtext	NO		NULL	
 select /*+QUERY_TIMEOUT(60000000)*/ IF(count(*) >= 0, 1, 0) from oceanbase.__all_virtual_mds_node_stat;
-IF(count(*) >= 0, 1, 0)
-1
+ERROR 0A000: Not supported feature or function
 "oceanbase.__all_virtual_mds_node_stat runs in single server"
-IF(count(*) >= 0, 1, 0)
-1
+ERROR 0A000: Not supported feature or function
 desc oceanbase.__all_virtual_mds_event_history;
 Field	Type	Null	Key	Default	Extra
 tenant_id	bigint(20)	NO	PRI	NULL