From 8fa99e93d4eb8e4439f0ecf1ff1d3aae8ed8ea6f Mon Sep 17 00:00:00 2001
From: hanr881 <1741282579@qq.com>
Date: Mon, 7 Aug 2023 04:18:30 +0000
Subject: [PATCH] to issue<51345956>:fix memory leak when executing store
 procedure which has pure out complex type in ps mode

---
 src/observer/mysql/ob_sync_cmd_driver.cpp | 18 +++++++++++++++++-
 src/observer/mysql/ob_sync_cmd_driver.h   |  1 +
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/observer/mysql/ob_sync_cmd_driver.cpp b/src/observer/mysql/ob_sync_cmd_driver.cpp
index 69b5cab993..b90969e011 100644
--- a/src/observer/mysql/ob_sync_cmd_driver.cpp
+++ b/src/observer/mysql/ob_sync_cmd_driver.cpp
@@ -22,6 +22,7 @@
 #include "rpc/obmysql/packet/ompk_eof.h"
 #include "share/ob_lob_access_utils.h"
 #include "observer/mysql/obmp_stmt_prexecute.h"
+#include "src/pl/ob_pl_user_type.h"
 
 namespace oceanbase
 {
@@ -102,6 +103,20 @@ int ObSyncCmdDriver::response_query_result(sql::ObResultSet &result,
     result, is_ps_protocol, has_more_result, can_retry, fetch_limit);
 }
 
+
+void ObSyncCmdDriver::free_output_row(ObMySQLResultSet &result)
+{
+  if (OB_NOT_NULL(result.get_exec_context().get_output_row())) {
+    const ObNewRow *row = result.get_exec_context().get_output_row();
+    for (int64_t i = 0; i < row->get_count(); ++i) {
+      ObObj &obj = row->cells_[i];
+      if (obj.is_pl_extend()) {
+        (void)pl::ObUserDefinedType::destruct_obj(obj, &session_);
+      }
+    }
+  }
+}
+
 int ObSyncCmdDriver::response_result(ObMySQLResultSet &result)
 {
   ObActiveSessionGuard::get_stat().in_sql_execution_ = true;
@@ -138,6 +153,7 @@ int ObSyncCmdDriver::response_result(ObMySQLResultSet &result)
       LOG_ERROR("Not SELECT, should not have any row!!!", K(ret));
     } else if (OB_FAIL(response_query_result(result))) {
       LOG_WARN("response query result fail", K(ret));
+      free_output_row(result);
       int cret = result.close();
       if (cret != OB_SUCCESS) {
         LOG_WARN("close result set fail", K(cret));
@@ -160,7 +176,7 @@ int ObSyncCmdDriver::response_result(ObMySQLResultSet &result)
     // for CRUD SQL
     // must be called before result.close()
     process_schema_version_changes(result);
-
+    free_output_row(result);
     if (OB_FAIL(result.close())) {
       LOG_WARN("close result set fail", K(ret));
     } else if (!result.is_with_rows()
diff --git a/src/observer/mysql/ob_sync_cmd_driver.h b/src/observer/mysql/ob_sync_cmd_driver.h
index f4c61855f7..be57205453 100644
--- a/src/observer/mysql/ob_sync_cmd_driver.h
+++ b/src/observer/mysql/ob_sync_cmd_driver.h
@@ -58,6 +58,7 @@ private:
   int process_schema_version_changes(const ObMySQLResultSet &result);
   int check_and_refresh_schema(uint64_t tenant_id);
   int response_query_result(ObMySQLResultSet &result);
+  void free_output_row(ObMySQLResultSet &result);
   /* variables */
   /* const */
   /* disallow copy & assign */