From 91d94ce27a66e93550f8f58d3f05b44f933adbcc Mon Sep 17 00:00:00 2001 From: obdev Date: Thu, 9 Mar 2023 13:44:23 +0000 Subject: [PATCH] remove links. --- deps/oblib/src/lib/number/ob_number_v2.h | 2 +- src/sql/engine/expr/ob_expr_add.cpp | 1 - src/sql/engine/expr/ob_expr_minus.cpp | 1 - src/sql/engine/expr/ob_expr_mul.cpp | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --git a/deps/oblib/src/lib/number/ob_number_v2.h b/deps/oblib/src/lib/number/ob_number_v2.h index 7f9b91794b..605ba2cfcf 100644 --- a/deps/oblib/src/lib/number/ob_number_v2.h +++ b/deps/oblib/src/lib/number/ob_number_v2.h @@ -3494,7 +3494,7 @@ OB_INLINE bool ObNumber::try_fast_add(ObNumber &l_num, ObNumber &r_num, } } res_desc.sign_ = POSITIVE; - res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql, https://work.aone.alibaba-inc.com/issue/40852179. + res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql. } return is_fast_panel; diff --git a/src/sql/engine/expr/ob_expr_add.cpp b/src/sql/engine/expr/ob_expr_add.cpp index 0719f6a2aa..c6ec80d6f0 100644 --- a/src/sql/engine/expr/ob_expr_add.cpp +++ b/src/sql/engine/expr/ob_expr_add.cpp @@ -882,7 +882,6 @@ int ObExprAdd::add_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL) ObNumber::Desc &desc_buf = const_cast (results.at(i)->get_number_desc()); // Notice that, space of tmp is allocated in frame but without memset operation, which causes random memory content. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. - // Reference: https://work.aone.alibaba-inc.com/issue/40852179 ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc(); // speedup detection if (ObNumber::try_fast_add(l_num, r_num, res_digits, *res_desc)) { diff --git a/src/sql/engine/expr/ob_expr_minus.cpp b/src/sql/engine/expr/ob_expr_minus.cpp index 3c4aebca72..40fa9f75be 100644 --- a/src/sql/engine/expr/ob_expr_minus.cpp +++ b/src/sql/engine/expr/ob_expr_minus.cpp @@ -995,7 +995,6 @@ int ObExprMinus::minus_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL) ObNumber::Desc &desc_buf = const_cast (results.at(i)->get_number_desc()); // Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. - // Reference: https://work.aone.alibaba-inc.com/issue/40852179 ObNumber::Desc *res_desc = new (&desc_buf) ObNumberDesc(); // speedup detection if (ObNumber::try_fast_minus(l_num, r_num, res_digits, *res_desc)) { diff --git a/src/sql/engine/expr/ob_expr_mul.cpp b/src/sql/engine/expr/ob_expr_mul.cpp index 5a0d23577c..4e7c242107 100644 --- a/src/sql/engine/expr/ob_expr_mul.cpp +++ b/src/sql/engine/expr/ob_expr_mul.cpp @@ -762,7 +762,6 @@ int ObExprMul::mul_number_batch(BATCH_EVAL_FUNC_ARG_DECL) ObNumber::Desc &desc_buf = const_cast (results.at(i)->get_number_desc()); // Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. - // Reference: https://work.aone.alibaba-inc.com/issue/40852179 ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc(); // speedup detection if (ObNumber::try_fast_mul(l_num, r_num, res_digits, *res_desc)) {