patch 4.0
This commit is contained in:
@ -10,50 +10,48 @@
|
||||
* See the Mulan PubL v2 for more details.
|
||||
*/
|
||||
|
||||
#define USING_LOG_PREFIX SQL_RESV
|
||||
#define USING_LOG_PREFIX SQL_RESV
|
||||
|
||||
#include "sql/resolver/ddl/ob_drop_index_resolver.h"
|
||||
#include "share/schema/ob_table_schema.h"
|
||||
#include "sql/resolver/ddl/ob_drop_index_stmt.h"
|
||||
#include "sql/session/ob_sql_session_info.h"
|
||||
namespace oceanbase {
|
||||
namespace oceanbase
|
||||
{
|
||||
using namespace common;
|
||||
using namespace obrpc;
|
||||
using namespace share;
|
||||
using namespace share::schema;
|
||||
namespace sql {
|
||||
ObDropIndexResolver::ObDropIndexResolver(ObResolverParams& params) : ObDDLResolver(params)
|
||||
{}
|
||||
namespace sql
|
||||
{
|
||||
ObDropIndexResolver::ObDropIndexResolver(ObResolverParams ¶ms) : ObDDLResolver(params)
|
||||
{
|
||||
}
|
||||
|
||||
ObDropIndexResolver::~ObDropIndexResolver()
|
||||
{}
|
||||
{
|
||||
}
|
||||
|
||||
int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
int ObDropIndexResolver::resolve(const ParseNode &parse_tree)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
ParseNode* index_node = NULL;
|
||||
ParseNode *index_node = NULL;
|
||||
|
||||
if (share::is_oracle_mode()) { // oracle mode
|
||||
if (OB_UNLIKELY((parse_tree.type_ != T_DROP_INDEX || (1 != parse_tree.num_child_ && 2 != parse_tree.num_child_))) ||
|
||||
OB_ISNULL(parse_tree.children_)) {
|
||||
if (lib::is_oracle_mode()) { // oracle mode
|
||||
if (OB_UNLIKELY((parse_tree.type_ != T_DROP_INDEX || (1 != parse_tree.num_child_ && 2 != parse_tree.num_child_)))
|
||||
|| OB_ISNULL(parse_tree.children_)) {
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("invalid parse tree type or invalid children number",
|
||||
K(parse_tree.type_),
|
||||
K(parse_tree.num_child_),
|
||||
K(parse_tree.children_),
|
||||
K(ret));
|
||||
LOG_WARN("invalid parse tree type or invalid children number", K(parse_tree.type_),
|
||||
K(parse_tree.num_child_), K(parse_tree.children_), K(ret));
|
||||
}
|
||||
} else if (OB_UNLIKELY((parse_tree.type_ != T_DROP_INDEX || 2 != parse_tree.num_child_)) ||
|
||||
OB_ISNULL(parse_tree.children_)) { // mysql mode
|
||||
} else if (OB_UNLIKELY((parse_tree.type_ != T_DROP_INDEX || 2 != parse_tree.num_child_))
|
||||
|| OB_ISNULL(parse_tree.children_)) { // mysql mode
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("invalid parse tree type or invalid children number",
|
||||
K(parse_tree.type_),
|
||||
K(parse_tree.num_child_),
|
||||
K(parse_tree.children_),
|
||||
K(ret));
|
||||
LOG_WARN("invalid parse tree type or invalid children number", K(parse_tree.type_),
|
||||
K(parse_tree.num_child_), K(parse_tree.children_), K(ret));
|
||||
}
|
||||
if (OB_SUCC(ret)) {
|
||||
ObDropIndexStmt* drop_index_stmt = NULL;
|
||||
ObDropIndexStmt *drop_index_stmt = NULL;
|
||||
if (OB_UNLIKELY(NULL == (drop_index_stmt = create_stmt<ObDropIndexStmt>()))) {
|
||||
ret = OB_ALLOCATE_MEMORY_FAILED;
|
||||
LOG_ERROR("create index stmt failed", K(ret));
|
||||
@ -62,11 +60,15 @@ int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
}
|
||||
|
||||
// get table name in oracle mode
|
||||
if (OB_SUCC(ret) && share::is_oracle_mode()) {
|
||||
ParseNode* db_node = NULL;
|
||||
int32_t max_database_name_length = GET_MIN_CLUSTER_VERSION() < CLUSTER_CURRENT_VERSION
|
||||
? OB_MAX_DATABASE_NAME_LENGTH - 1
|
||||
: OB_MAX_DATABASE_NAME_LENGTH;
|
||||
if (OB_SUCC(ret) && lib::is_oracle_mode()) {
|
||||
ParseNode *db_node = NULL;
|
||||
/**
|
||||
* 在2.2.20版本上将命名长度比较逻辑由大于等于128字节时报错调整为大于128字节时报错后, 2.2.20以上版本
|
||||
* 数据库名长度可以为128字节。 升级过程中高版本server序列化session info到低版本server时, 如果数据
|
||||
* 库名长度为128字节会存在兼容性问题。 因此在升级过程中限制数据库名长度不超过127字节
|
||||
*/
|
||||
int32_t max_database_name_length = GET_MIN_CLUSTER_VERSION() < CLUSTER_CURRENT_VERSION ?
|
||||
OB_MAX_DATABASE_NAME_LENGTH - 1 : OB_MAX_DATABASE_NAME_LENGTH;
|
||||
if (1 == parse_tree.num_child_) {
|
||||
index_node = parse_tree.children_[0];
|
||||
} else if (2 == parse_tree.num_child_) {
|
||||
@ -82,9 +84,10 @@ int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
uint64_t tenant_id = session_info_->get_effective_tenant_id();
|
||||
uint64_t db_id = OB_INVALID_ID;
|
||||
ObString database_name;
|
||||
const ObTableSchema* index_table_schema = NULL;
|
||||
const ObTableSchema* data_table_schema = NULL;
|
||||
const ObTableSchema *index_table_schema = NULL;
|
||||
const ObTableSchema *data_table_schema = NULL;
|
||||
if (1 == parse_tree.num_child_) {
|
||||
// 缺省 database_name 的时候,默认使用当前 database_name
|
||||
db_id = session_info_->get_database_id();
|
||||
database_name = session_info_->get_database_name();
|
||||
} else if (2 == parse_tree.num_child_) {
|
||||
@ -99,7 +102,8 @@ int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
ret = OB_ERR_TOO_LONG_IDENT;
|
||||
LOG_USER_ERROR(OB_ERR_TOO_LONG_IDENT, (int)db_node->str_len_, db_node->str_value_);
|
||||
} else {
|
||||
database_name.assign_ptr(db_node->str_value_, static_cast<int32_t>(db_node->str_len_));
|
||||
database_name.assign_ptr(db_node->str_value_,
|
||||
static_cast<int32_t>(db_node->str_len_));
|
||||
}
|
||||
}
|
||||
if (OB_FAIL(ret)) {
|
||||
@ -108,35 +112,38 @@ int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
}
|
||||
}
|
||||
if (OB_FAIL(ret)) {
|
||||
} else if (OB_FAIL(schema_checker_->get_idx_schema_by_origin_idx_name(
|
||||
tenant_id, db_id, index_name, index_table_schema))) {
|
||||
} else if (OB_FAIL(schema_checker_->get_idx_schema_by_origin_idx_name(tenant_id, db_id, index_name, index_table_schema))) {
|
||||
LOG_WARN("fail to get index table schema", K(ret), K(index_name));
|
||||
} else if (OB_ISNULL(index_table_schema)) {
|
||||
// 获取到的 table_schema 为空,则说明当前 db 下没有 index_name 对应的 index
|
||||
ret = OB_ERR_CANT_DROP_FIELD_OR_KEY;
|
||||
LOG_WARN("index table schema should not be null", K(index_name), K(ret));
|
||||
LOG_USER_ERROR(OB_ERR_CANT_DROP_FIELD_OR_KEY, index_name.length(), index_name.ptr());
|
||||
} else if (schema_checker_->get_table_schema(index_table_schema->get_data_table_id(), data_table_schema)) {
|
||||
} else if (OB_FAIL(schema_checker_->get_table_schema(tenant_id,
|
||||
index_table_schema->get_data_table_id(), data_table_schema))) {
|
||||
LOG_WARN("fail to get data table schema", K(ret), K(index_name));
|
||||
} else {
|
||||
drop_index_stmt->set_table_name(data_table_schema->get_table_name_str());
|
||||
drop_index_stmt->set_database_name(database_name);
|
||||
drop_index_stmt->set_tenant_id(session_info_->get_effective_tenant_id());
|
||||
drop_index_stmt->set_table_id(data_table_schema->get_table_id());
|
||||
ObString table_name; // related issue : https://work.aone.alibaba-inc.com/issue/44979368
|
||||
if (OB_FAIL(deep_copy_str(data_table_schema->get_table_name_str(), table_name))) {
|
||||
LOG_WARN("failed to deep copy new_db_name", K(ret));
|
||||
} else {
|
||||
drop_index_stmt->set_table_name(table_name);
|
||||
drop_index_stmt->set_database_name(database_name);
|
||||
drop_index_stmt->set_tenant_id(session_info_->get_effective_tenant_id());
|
||||
drop_index_stmt->set_table_id(data_table_schema->get_table_id());
|
||||
}
|
||||
}
|
||||
if (OB_SUCC(ret) && ObSchemaChecker::is_ora_priv_check()) {
|
||||
OZ(schema_checker_->check_ora_ddl_priv(tenant_id,
|
||||
session_info_->get_priv_user_id(),
|
||||
database_name,
|
||||
stmt::T_DROP_INDEX,
|
||||
session_info_->get_enable_role_array()),
|
||||
tenant_id,
|
||||
session_info_->get_user_id(),
|
||||
database_name);
|
||||
OZ (schema_checker_->check_ora_ddl_priv(
|
||||
tenant_id, session_info_->get_priv_user_id(),
|
||||
database_name, stmt::T_DROP_INDEX,
|
||||
session_info_->get_enable_role_array()),
|
||||
tenant_id, session_info_->get_user_id(), database_name);
|
||||
}
|
||||
}
|
||||
} else if (OB_SUCC(ret) && share::is_mysql_mode()) {
|
||||
} else if (OB_SUCC(ret) && lib::is_mysql_mode()) {
|
||||
index_node = parse_tree.children_[0];
|
||||
ParseNode* relation_node = parse_tree.children_[1];
|
||||
ParseNode *relation_node = parse_tree.children_[1];
|
||||
ObString table_name;
|
||||
ObString database_name;
|
||||
if (OB_ISNULL(relation_node)) {
|
||||
@ -158,56 +165,54 @@ int ObDropIndexResolver::resolve(const ParseNode& parse_tree)
|
||||
} else {
|
||||
int32_t len = static_cast<int32_t>(index_node->str_len_);
|
||||
ObString index_name(len, len, index_node->str_value_);
|
||||
const ObTableSchema* table_schema = NULL;
|
||||
// 检查索引是否建立在外键列上,如果是的话,则不允许删除该索引
|
||||
const ObTableSchema *table_schema = NULL;
|
||||
if (OB_FAIL(schema_checker_->get_table_schema(session_info_->get_effective_tenant_id(),
|
||||
drop_index_stmt->get_database_name(),
|
||||
drop_index_stmt->get_table_name(),
|
||||
false /* not index table */,
|
||||
table_schema))) {
|
||||
drop_index_stmt->get_database_name(),
|
||||
drop_index_stmt->get_table_name(),
|
||||
false /* not index table */,
|
||||
table_schema))) {
|
||||
if (OB_TABLE_NOT_EXIST == ret) {
|
||||
LOG_USER_ERROR(OB_TABLE_NOT_EXIST,
|
||||
to_cstring(drop_index_stmt->get_database_name()),
|
||||
to_cstring(drop_index_stmt->get_table_name()));
|
||||
LOG_USER_ERROR(OB_TABLE_NOT_EXIST, to_cstring(drop_index_stmt->get_database_name()), to_cstring(drop_index_stmt->get_table_name()));
|
||||
}
|
||||
LOG_WARN("fail to get table schema", K(ret));
|
||||
} else if (OB_ISNULL(table_schema)) {
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("table schema is NULL", K(ret));
|
||||
} else if (table_schema->is_parent_table() || table_schema->is_child_table()) {
|
||||
const ObTableSchema* index_table_schema = NULL;
|
||||
const ObTableSchema *index_table_schema = NULL;
|
||||
ObString index_table_name;
|
||||
ObArenaAllocator allocator(ObModIds::OB_SCHEMA);
|
||||
bool has_other_indexes_on_same_cols = false;
|
||||
if (OB_FAIL(ObTableSchema::build_index_table_name(
|
||||
allocator, table_schema->get_table_id(), index_name, index_table_name))) {
|
||||
if (OB_FAIL(ObTableSchema::build_index_table_name(allocator,
|
||||
table_schema->get_table_id(),
|
||||
index_name,
|
||||
index_table_name))) {
|
||||
LOG_WARN("build_index_table_name failed", K(table_schema->get_table_id()), K(index_name), K(ret));
|
||||
} else if (OB_FAIL(schema_checker_->get_table_schema(session_info_->get_effective_tenant_id(),
|
||||
drop_index_stmt->get_database_name(),
|
||||
index_table_name,
|
||||
true /* index table */,
|
||||
index_table_schema))) {
|
||||
drop_index_stmt->get_database_name(),
|
||||
index_table_name,
|
||||
true /* index table */,
|
||||
index_table_schema))) {
|
||||
LOG_WARN("fail to get index table schema", K(ret));
|
||||
} else if (OB_ISNULL(index_table_schema)) {
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("table schema is NULL", K(ret));
|
||||
} else if (OB_FAIL(check_indexes_on_same_cols(
|
||||
*table_schema, *index_table_schema, *schema_checker_, has_other_indexes_on_same_cols))) {
|
||||
} else if (OB_FAIL(check_indexes_on_same_cols(*table_schema,
|
||||
*index_table_schema,
|
||||
*schema_checker_,
|
||||
has_other_indexes_on_same_cols))) {
|
||||
LOG_WARN("check indexes on same cols failed", K(ret));
|
||||
} else if (!has_other_indexes_on_same_cols && share::is_mysql_mode()) {
|
||||
} else if (!has_other_indexes_on_same_cols && lib::is_mysql_mode()) {
|
||||
if (OB_FAIL(check_index_columns_equal_foreign_key(*table_schema, *index_table_schema))) {
|
||||
LOG_WARN("failed to check_index_columns_equal_foreign_key", K(ret), K(index_table_name));
|
||||
}
|
||||
}
|
||||
}
|
||||
// 外键列对删除索引的影响至此检查结束
|
||||
if (OB_SUCC(ret)) {
|
||||
drop_index_stmt->set_index_name(index_name);
|
||||
obrpc::ObDropIndexArg& drop_index_arg = drop_index_stmt->get_drop_index_arg();
|
||||
ObObj is_recyclebin_open;
|
||||
if (OB_FAIL(session_info_->get_sys_variable(SYS_VAR_RECYCLEBIN, is_recyclebin_open))) {
|
||||
SQL_RESV_LOG(WARN, "get sys variable failed", K(ret));
|
||||
} else {
|
||||
drop_index_arg.to_recyclebin_ = is_recyclebin_open.get_bool();
|
||||
}
|
||||
obrpc::ObDropIndexArg &drop_index_arg = drop_index_stmt->get_drop_index_arg();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user