From 9564a010c5893650b9a471eb8fd0108ce0184d4a Mon Sep 17 00:00:00 2001 From: JiahuaChen Date: Mon, 6 Jan 2025 18:15:34 +0000 Subject: [PATCH] Safe dump micro block writer --- src/storage/blocksstable/ob_macro_block_writer.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/storage/blocksstable/ob_macro_block_writer.cpp b/src/storage/blocksstable/ob_macro_block_writer.cpp index d5452e7a3..27e6bbefa 100644 --- a/src/storage/blocksstable/ob_macro_block_writer.cpp +++ b/src/storage/blocksstable/ob_macro_block_writer.cpp @@ -2198,10 +2198,14 @@ void ObMacroBlockWriter::dump_micro_block(ObIMicroBlockWriter µ_writer) char *buf = NULL; int64_t size = 0; if (micro_writer.get_row_count() > 0) { - if (OB_FAIL(micro_writer.build_block(buf, size))) { - STORAGE_LOG(WARN, "failed to build micro block", K(ret)); - } else if (OB_FAIL(micro_helper_.dump_micro_block_writer_buffer(buf, size))) { - STORAGE_LOG(WARN, "failed to dump micro block", K(ret)); + if (data_store_desc_->encoding_enabled()) { + micro_writer.dump_diagnose_info(); + } else { + if (OB_FAIL(micro_writer.build_block(buf, size))) { + STORAGE_LOG(WARN, "failed to build micro block", K(ret)); + } else if (OB_FAIL(micro_helper_.dump_micro_block_writer_buffer(buf, size))) { + STORAGE_LOG(WARN, "failed to dump micro block", K(ret)); + } } } return;