hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix two bugs from github issues #715 #716

Browse Source
This commit is contained in:
LINxiansheng
2021-12-20 11:42:49 +08:00
committed by LINxiansheng
parent 9e79e15b18
commit 9802ffae64
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/share/object/ob_obj_cast.cpp
View File

@ -1603,10 +1603,10 @@ static int float_number(
if (OB_UNLIKELY(ObFloatTC != in.get_type_class() || ObNumberTC != ob_obj_type_class(expect_type))) {
ret = OB_ERR_UNEXPECTED;
LOG_ERROR("invalid input type", K(ret), K(in), K(expect_type));
} else if (isnan(value)) {
} else if (std::isnan(value)) {
ret = OB_INVALID_NUMERIC;
LOG_WARN("float_number failed ", K(ret), K(value));
} else if (isinf(value)) {
} else if (std::isinf(value)) {
ret = OB_NUMERIC_OVERFLOW;
LOG_WARN("float_number failed", K(ret), K(value));
} else if (ObUNumberType == expect_type && CAST_FAIL(numeric_negative_check(value))) {
@ -1908,10 +1908,10 @@ static int double_number(
if (OB_UNLIKELY(ObDoubleTC != in.get_type_class() || ObNumberTC != ob_obj_type_class(expect_type))) {
ret = OB_ERR_UNEXPECTED;
LOG_ERROR("invalid input type", K(ret), K(in), K(expect_type));
} else if (isnan(value) && lib::is_oracle_mode()) {
} else if (std::isnan(value) && lib::is_oracle_mode()) {
ret = OB_INVALID_NUMERIC;
LOG_WARN("float_number failed ", K(ret), K(value));
} else if (isinf(value) && lib::is_oracle_mode()) {
} else if (std::isinf(value) && lib::is_oracle_mode()) {
ret = OB_NUMERIC_OVERFLOW;
LOG_WARN("float_number failed", K(ret), K(value));
} else if (ObUNumberType == expect_type && CAST_FAIL(numeric_negative_check(value))) {

1
src/share/object/ob_obj_cast.h
View File

@ -21,6 +21,7 @@
#include "lib/charset/ob_charset.h"
#include "share/ob_errno.h"
namespace oceanbase {
namespace common {