hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Change _schema_history_recycle_interval to a formal parameter

Browse Source
This commit is contained in:
ym0 2021-12-02 14:33:30 +08:00 committed by LINxiansheng
parent b82a7f5e4b
commit 9850c3bc85
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/rootserver/ob_root_service.cpp
View File

@ -9790,9 +9790,9 @@ int ObRootService::set_config_post_hook(const obrpc::ObAdminSetConfigArg& arg)
LOG_WARN("fail to submit update rs list task", KR(ret), K(tmp_ret));
}
LOG_INFO("obconfig_url parameters updated, force submit update rslist task", KR(tmp_ret), KPC(item));
} else if (0 == STRCMP(item->name_.ptr(), _SCHEMA_HISTORY_RECYCLE_INTERVAL)) {
} else if (0 == STRCMP(item->name_.ptr(), SCHEMA_HISTORY_RECYCLE_INTERVAL)) {
schema_history_recycler_.wakeup();
LOG_INFO("_schema_history_recycle_interval parameters updated, wakeup schema_history_recycler", KPC(item));
LOG_INFO("schema_history_recycle_interval parameters updated, wakeup schema_history_recycler", KPC(item));
}
}
return ret;

6
src/rootserver/ob_schema_history_recycler.cpp
View File

@ -68,8 +68,8 @@ bool ObRecycleSchemaValue::is_valid() const
int64_t ObSchemaHistoryRecyclerIdling::get_idle_interval_us()
{
int64_t idle_time = DEFAULT_SCHEMA_HISTORY_RECYCLE_INTERVAL;
if (0 != GCONF._schema_history_recycle_interval && !GCONF.in_upgrade_mode()) {
idle_time = GCONF._schema_history_recycle_interval;
if (0 != GCONF.schema_history_recycle_interval && !GCONF.in_upgrade_mode()) {
idle_time = GCONF.schema_history_recycle_interval;
}
return idle_time;
}
@ -159,7 +159,7 @@ int ObSchemaHistoryRecycler::check_inner_stat()
} else if (stop_) {
ret = OB_CANCELED;
LOG_WARN("schema history recycler stopped", KR(ret));
} else if (0 == GCONF._schema_history_recycle_interval || GCONF.in_upgrade_mode() || !GCTX.is_schema_splited()) {
} else if (0 == GCONF.schema_history_recycle_interval || GCONF.in_upgrade_mode() || !GCTX.is_schema_splited()) {
ret = OB_CANCELED;
LOG_WARN("schema history recycler should stopped", KR(ret));
}

2
src/share/config/ob_server_config.h
View File

@ -42,7 +42,7 @@ const char* const ENABLE_SQL_AUDIT = "enable_sql_audit";
const char* const CONFIG_TRUE_VALUE = "1";
const char* const CONFIG_FALSE_VALUE = "0";
const char* const OBCONFIG_URL = "obconfig_url";
const char* const _SCHEMA_HISTORY_RECYCLE_INTERVAL = "_schema_history_recycle_interval";
const char* const SCHEMA_HISTORY_RECYCLE_INTERVAL = "schema_history_recycle_interval";
const char* const _RECYCLEBIN_OBJECT_PURGE_FREQUENCY = "_recyclebin_object_purge_frequency";
const char* const TDE_MODE = "tde_mode";
const char* const EXTERNAL_KMS_INFO = "external_kms_info";

2
src/share/parameter/ob_parameter_seed.ipp
View File

@ -1425,7 +1425,7 @@ DEF_BOOL(_enable_plan_cache_mem_diagnosis, OB_CLUSTER_PARAMETER, "False",
DEF_INT(_clog_aggregation_buffer_amount, OB_TENANT_PARAMETER, "0", "[0, 128]", "the amount of clog aggregation buffer",
ObParameterAttr(Section::OBSERVER, Source::DEFAULT, EditLevel::DYNAMIC_EFFECTIVE));
DEF_TIME(_schema_history_recycle_interval, OB_CLUSTER_PARAMETER, "0s", "[0s,]",
DEF_TIME(schema_history_recycle_interval, OB_CLUSTER_PARAMETER, "10m", "[0s,]",
"the time interval between the schedules of schema history recyle task. "
"Range: [0s, +∞)",
ObParameterAttr(Section::LOAD_BALANCE, Source::DEFAULT, EditLevel::DYNAMIC_EFFECTIVE));