hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] fix cgroup valid status cause performace regression

Browse Source
This commit is contained in:
zhjc1124 2024-12-12 16:15:46 +00:00 committed by ob-robot
parent af40e0c6af
commit 9a624399fe
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/share/resource_manager/ob_cgroup_ctrl.cpp
View File

@ -174,10 +174,10 @@ bool ObCgroupCtrl::check_cgroup_status()
// In case symbolic link is deleted
if (OB_TMP_FAIL(check_cgroup_root_dir())) {
LOG_WARN_RET(tmp_ret, "check cgroup root dir failed", K(tmp_ret));
set_valid(false);
valid_ = false;
}
} else if (GCONF.enable_cgroup == false && is_valid() == true) {
set_valid(false);
valid_ = false;
if (OB_TMP_FAIL(check_cgroup_root_dir())) {
LOG_WARN_RET(tmp_ret, "check cgroup root dir failed", K(tmp_ret));
} else if (OB_TMP_FAIL(regist_observer_to_cgroup(OBSERVER_ROOT_CGROUP_DIR))) {
@ -200,7 +200,7 @@ bool ObCgroupCtrl::check_cgroup_status()
LOG_WARN_RET(tmp_ret, "regist observer thread to cgroup failed", K(tmp_ret), K(OTHER_CGROUP_DIR));
} else {
need_regist_cgroup = true;
set_valid(true);
valid_ = true;
LOG_INFO("init cgroup success");
}
}
@ -226,7 +226,7 @@ int ObCgroupCtrl::check_cgroup_root_dir()
void ObCgroupCtrl::destroy()
{
if (is_valid()) {
set_valid(false);
valid_ = false;
recursion_remove_group_(OBSERVER_ROOT_CGROUP_DIR, false /* if_remove_top */);
}
}

3
src/share/resource_manager/ob_cgroup_ctrl.h
View File

@ -159,8 +159,7 @@ public:
bool check_cgroup_status();
static int check_cgroup_root_dir();
void destroy();
void set_valid(bool valid) { ATOMIC_STORE(&valid_, valid); }
bool is_valid() { return ATOMIC_LOAD(&valid_); }
bool is_valid() { return valid_; }
bool is_valid_group_name(common::ObString &group_name);
static int compare_cpu(const double cpu1, const double cpu2, int &compare_ret);