hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

disable sum(double/float) to groupby push down

Browse Source
This commit is contained in:
jingtaoye35
2024-08-20 04:47:45 +00:00
committed by ob-robot
parent 653dfe0e0f
commit 9a630dcc67
2 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/sql/rewrite/ob_transform_groupby_pushdown.cpp
View File

@ -226,7 +226,8 @@ int ObTransformGroupByPushdown::check_groupby_push_down_validity(ObSelectStmt *s
aggr_expr->get_expr_type() != T_FUN_COUNT &&
aggr_expr->get_expr_type() != T_FUN_MIN &&
aggr_expr->get_expr_type() != T_FUN_MAX) ||
aggr_expr->is_param_distinct()) {
aggr_expr->is_param_distinct() ||
!can_sum_trans_to_sum_count(aggr_expr)) {
is_valid = false;
OPT_TRACE("invalid aggregation type for group by placement", aggr_expr);
LOG_TRACE("invalid aggregation type for group by placement", K(is_valid),
@ -1695,3 +1696,23 @@ int ObTransformGroupByPushdown::check_hint_valid(ObDMLStmt &stmt,
LOG_TRACE("succeed to check group by hint valid", K(is_valid), K(trans_tables), K(params), K(hint));
return ret;
}
bool ObTransformGroupByPushdown::can_sum_trans_to_sum_count(const ObRawExpr *expr)
{
bool is_able = true;
if (OB_ISNULL(expr) ||
expr->get_expr_type() != T_FUN_SUM ||
OB_UNLIKELY(expr->get_param_count() != 1) ||
OB_ISNULL(expr->get_param_expr(0))) {
/* do nothing */
} else {
ObObjType obj_type = expr->get_param_expr(0)->get_result_type().get_type();
if (ObFloatType == obj_type || ObUFloatType == obj_type ||
ObDoubleType == obj_type || ObUDoubleType == obj_type) {
is_able = false;
OPT_TRACE("invalid aggregation param type");
LOG_TRACE("invalid aggregation param type", K(obj_type));
}
}
return is_able;
}

6
src/sql/rewrite/ob_transform_groupby_pushdown.h
View File

@ -183,7 +183,11 @@ private:
ObIArray<PushDownParam> &params,
bool &hint_force_pushdown,
bool &is_valid);
/* whether sum(c1) splift to sum(count(*) * c1)
* YES case: 1 + 1 + 1 + 2 + 2 + 2 = 3 * 1 + 3 * 2
* NO case: 0.1 + 0.1 + 0.1 + 0.1 + 0.1 + 0.1 != 6 * 0.1
*/
bool can_sum_trans_to_sum_count(const ObRawExpr *expr);
private:
// help functions
int64_t get_count_sum_num(const ObIArray<ObRawExpr *> &exprs)