hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] fix bug insert ignore with generated column maybe cause 4377 error

Browse Source
This commit is contained in:
yishenglanlingzui
2024-02-08 21:47:06 +00:00
committed by ob-robot
parent b5c3184f83
commit 9db2501590
6 changed files with 45 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/sql/engine/dml/ob_dml_service.cpp
View File

@ -38,6 +38,28 @@ using namespace share;
using namespace transaction;
namespace sql
{
bool ObDMLService::check_cascaded_reference(const ObExpr *expr, const ObExprPtrIArray &row)
{
bool bret = false;
if (OB_ISNULL(expr) || expr->parent_cnt_ <= 0) {
bret = false;
} else {
for (int i = 0; !bret && i < expr->parent_cnt_; ++i) {
ObExpr *parent_expr = expr->parents_[i];
if (parent_expr != nullptr) {
if (parent_expr->type_ == T_FUN_COLUMN_CONV) {
bret = has_exist_in_array(row, parent_expr);
}
}
if (!bret) {
bret = check_cascaded_reference(parent_expr, row);
}
}
}
return bret;
}
int ObDMLService::check_row_null(const ObExprPtrIArray &row,
ObEvalCtx &eval_ctx,
int64_t row_num,
@ -74,6 +96,12 @@ int ObDMLService::check_row_null(const ObExprPtrIArray &row,
ret = OB_BAD_NULL_ERROR;
LOG_WARN("dml with ignore not supported in geometry type");
LOG_USER_ERROR(OB_BAD_NULL_ERROR, column_infos.at(i).column_name_.length(), column_infos.at(i).column_name_.ptr());
} else if (check_cascaded_reference(row.at(col_idx), row)) {
//This column is dependent on other columns and cannot be modified again;
//otherwise, it will necessitate a cascading recalculation of the dependent expression results.
ret = OB_BAD_NULL_ERROR;
LOG_WARN("dml with ignore not supported with cascaded column", KPC(row.at(col_idx)));
LOG_USER_ERROR(OB_BAD_NULL_ERROR, column_infos.at(i).column_name_.length(), column_infos.at(i).column_name_.ptr());
} else if (OB_FAIL(ObObjCaster::get_zero_value(
row.at(col_idx)->obj_meta_.get_type(),
row.at(col_idx)->obj_meta_.get_collation_type(),

2
src/sql/engine/dml/ob_dml_service.h
View File

@ -24,6 +24,8 @@ class ObErrLogService;
class ObDMLService
{
public:
static bool check_cascaded_reference(const ObExpr *expr, const ObExprPtrIArray &row);
static int check_row_null(const ObExprPtrIArray &row,
ObEvalCtx &eval_ctx,
int64_t row_num,