hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix typo

Browse Source
This commit is contained in:
chenhuiming
2022-08-11 10:01:00 +08:00
parent 60c5786486
commit 9dc9c4894f
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/resolver/expr/ob_raw_expr.cpp
View File

@ -910,7 +910,7 @@ int ObConstRawExpr::inner_deep_copy(ObIRawExprCopier &copier)
} else if (OB_FAIL(deep_copy_obj(*inner_alloc_, value_, tmp))) { } else if (OB_FAIL(deep_copy_obj(*inner_alloc_, value_, tmp))) {
LOG_WARN("deep copy error", K(value_), K(ret)); LOG_WARN("deep copy error", K(value_), K(ret));
} else if (OB_FAIL(ob_write_string(*inner_alloc_, literal_prefix_, literal_prefix_))) { } else if (OB_FAIL(ob_write_string(*inner_alloc_, literal_prefix_, literal_prefix_))) {
LOG_WARN("failed to werite string", K(ret)); LOG_WARN("failed to write string", K(ret));
} else { } else {
value_ = tmp; value_ = tmp;
} }
@ -3934,7 +3934,7 @@ int ObSysFunRawExpr::get_name_internal(char *buf, const int64_t buf_len, int64_t
if (get_param_count() >= 1) { if (get_param_count() >= 1) {
if (OB_ISNULL(get_param_expr(i))) { if (OB_ISNULL(get_param_expr(i))) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("poram expr is NULL", K(i), K(ret)); LOG_WARN("param expr is NULL", K(i), K(ret));
} else if (OB_FAIL(get_param_expr(i)->get_name(buf, buf_len, pos, type))) { } else if (OB_FAIL(get_param_expr(i)->get_name(buf, buf_len, pos, type))) {
LOG_WARN("fail to get_name", K(ret)); LOG_WARN("fail to get_name", K(ret));
} else {} } else {}
@ -4193,7 +4193,7 @@ int ObNormalDllUdfRawExpr::set_udf_meta(const share::schema::ObUDF &udf)
udf_meta_.ret_ = udf.get_ret(); udf_meta_.ret_ = udf.get_ret();
udf_meta_.type_ = udf.get_type(); udf_meta_.type_ = udf.get_type();
/* data from schame, deep copy maybe a better choices */ /* data from schema, deep copy maybe a better choices */
if (OB_ISNULL(inner_alloc_)) { if (OB_ISNULL(inner_alloc_)) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("inner allocator or expr factory is NULL", K(inner_alloc_), K(ret)); LOG_WARN("inner allocator or expr factory is NULL", K(inner_alloc_), K(ret));
@ -4429,7 +4429,7 @@ int ObObjectConstructRawExpr::assign(const ObRawExpr &other)
if (OB_FAIL(elem_types_.assign(tmp.elem_types_))) { if (OB_FAIL(elem_types_.assign(tmp.elem_types_))) {
LOG_WARN("failed to assign elem types", K(ret)); LOG_WARN("failed to assign elem types", K(ret));
} else if (OB_FAIL(access_names_.assign(tmp.access_names_))) { } else if (OB_FAIL(access_names_.assign(tmp.access_names_))) {
LOG_WARN("failed to assgin access names", K(ret)); LOG_WARN("failed to assign access names", K(ret));
} }
} }
} }
@ -5047,10 +5047,10 @@ int Bound::replace_expr(const common::ObIArray<ObRawExpr *> &other_exprs,
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
if (OB_FAIL(ObTransformUtils::replace_expr( if (OB_FAIL(ObTransformUtils::replace_expr(
other_exprs, new_exprs, interval_expr_))) { other_exprs, new_exprs, interval_expr_))) {
LOG_WARN("failed to repalce exprs", K(ret)); LOG_WARN("failed to replace exprs", K(ret));
} else if (OB_FAIL(ObTransformUtils::replace_expr( } else if (OB_FAIL(ObTransformUtils::replace_expr(
other_exprs, new_exprs, date_unit_expr_))) { other_exprs, new_exprs, date_unit_expr_))) {
LOG_WARN("failed to repalce exprs", K(ret)); LOG_WARN("failed to replace exprs", K(ret));
} }
for (int i = 0; OB_SUCC(ret) && i < BOUND_EXPR_MAX; ++i) { for (int i = 0; OB_SUCC(ret) && i < BOUND_EXPR_MAX; ++i) {
if (OB_ISNULL(exprs_[i])) { if (OB_ISNULL(exprs_[i])) {
@ -5839,7 +5839,7 @@ bool ObExprParamCheckContext::compare_const(const ObConstRawExpr &left, const Ob
const ObRawExpr *left_param = NULL; const ObRawExpr *left_param = NULL;
const ObRawExpr *right_param = NULL; const ObRawExpr *right_param = NULL;
if (OB_FAIL(get_calc_expr(left.get_value().get_unknown(), left_param))) { if (OB_FAIL(get_calc_expr(left.get_value().get_unknown(), left_param))) {
LOG_WARN("faield to get calculable expr", K(ret)); LOG_WARN("failed to get calculable expr", K(ret));
} else if (OB_FAIL(get_calc_expr(right.get_value().get_unknown(), right_param))) { } else if (OB_FAIL(get_calc_expr(right.get_value().get_unknown(), right_param))) {
LOG_WARN("failed to get calculable expr", K(ret)); LOG_WARN("failed to get calculable expr", K(ret));
} else if (OB_ISNULL(left_param) || OB_ISNULL(right_param)) { } else if (OB_ISNULL(left_param) || OB_ISNULL(right_param)) {

2
src/sql/resolver/expr/ob_raw_expr_info_extractor.cpp
View File

@ -515,7 +515,7 @@ int ObRawExprInfoExtractor::visit(ObSysFunRawExpr &expr)
} else if (T_FUN_NORMAL_UDF == expr.get_expr_type() } else if (T_FUN_NORMAL_UDF == expr.get_expr_type()
|| T_FUN_AGG_UDF == expr.get_expr_type()) { || T_FUN_AGG_UDF == expr.get_expr_type()) {
/* /*
* it seems we have no chioce but to set the udf uncalculable. * it seems we have no choice but to set the udf uncalculable.
* we can not say a udf expr is const or not util we finish the xxx_init() function. * we can not say a udf expr is const or not util we finish the xxx_init() function.
* but we do the xxx_init() at the expr deduce type stage which was done after we * but we do the xxx_init() at the expr deduce type stage which was done after we
* extractor info from expr. * extractor info from expr.