hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] not considering const expr equal in or/and expr when computing shared expr

Browse Source
This commit is contained in:
jingtaoye35
2024-02-20 07:16:09 +00:00
committed by ob-robot
parent 625ea22c07
commit a3096d9389
5 changed files with 108 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/sql/resolver/expr/ob_shared_expr_resolver.cpp
View File

@ -143,7 +143,8 @@ int ObSharedExprResolver::add_new_instance(ObRawExprEntry &entry)
int ObSharedExprResolver::get_shared_instance(ObRawExpr *expr,
ObRawExpr *&shared_expr,
bool &is_new)
bool &is_new,
bool &disable_share_expr)
{
int ret = OB_SUCCESS;
shared_expr = NULL;
@ -152,34 +153,37 @@ int ObSharedExprResolver::get_shared_instance(ObRawExpr *expr,
if (OB_ISNULL(expr)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("expr is null", K(ret), K(expr));
} else if (!expr->is_aggr_expr() && !expr->is_win_func_expr() &&
T_OP_CASE != expr->get_expr_type()) {
} else if (is_blacklist_share_const(*expr)) {
disable_share_const_level_++;
}
if (OB_FAIL(ret) || is_blacklist_share_child(*expr)) {
} else {
bool has_questionmark = false;
for (int64_t i = 0; OB_SUCC(ret) && i < expr->get_param_count(); ++i) {
ObRawExpr *old_param_expr = expr->get_param_expr(i);
ObRawExpr *new_param_expr = NULL;
bool is_param_new = false;
if (old_param_expr->get_expr_type() == T_QUESTIONMARK ||
(expr->get_expr_type() == T_FUN_SYS_CAST && i == 1)) {
bool disable_share_child = false;
if (old_param_expr->get_expr_type() == T_QUESTIONMARK) {
if (old_param_expr->has_flag(IS_STATIC_PARAM) && disable_share_const_level_ > 0) {
disable_share_expr = true;
}
} else if (expr->get_expr_type() == T_FUN_SYS_CAST && i == 1) {
// skip exec var and question mark
} else if (OB_FAIL(SMART_CALL(get_shared_instance(old_param_expr,
new_param_expr,
is_param_new)))) {
is_param_new,
disable_share_child)))) {
LOG_WARN("failed to get shared instance", K(ret));
} else {
expr->get_param_expr(i) = new_param_expr;
has_new_param = has_new_param || is_param_new;
disable_share_expr |= disable_share_child;
}
}
}
if (OB_SUCC(ret)) {
if (expr->is_column_ref_expr() ||
expr->is_aggr_expr() ||
expr->is_win_func_expr() ||
expr->is_query_ref_expr() ||
expr->is_exec_param_expr() ||
expr->is_pseudo_column_expr() ||
expr->get_expr_type() == T_OP_ROW ||
expr->get_expr_type() == T_QUESTIONMARK) {
if (is_blacklist_share_expr(*expr) || disable_share_expr) {
shared_expr = expr;
} else {
ObRawExprEntry entry(expr, get_scope_id(), hash_expr_tree(expr, get_scope_id()));
@ -196,6 +200,9 @@ int ObSharedExprResolver::get_shared_instance(ObRawExpr *expr,
is_new = true;
}
}
if (is_blacklist_share_const(*expr)) {
disable_share_const_level_--;
}
}
return ret;
}

27
src/sql/resolver/expr/ob_shared_expr_resolver.h
View File

@ -59,14 +59,16 @@ public:
ObSharedExprResolver(ObQueryCtx *query_ctx)
: allocator_("MergeSharedExpr"),
scope_id_(0),
query_ctx_(query_ctx)
query_ctx_(query_ctx),
disable_share_const_level_(0)
{}
virtual ~ObSharedExprResolver();
int get_shared_instance(ObRawExpr *expr,
ObRawExpr *&shared_expr,
bool &is_new);
bool &is_new,
bool &disable_share_expr);
int add_new_instance(ObRawExprEntry &entry);
@ -82,7 +84,25 @@ private:
int inner_get_shared_expr(ObRawExprEntry &entry,
ObRawExpr *&new_expr);
inline bool is_blacklist_share_expr(const ObRawExpr &expr)
{
return expr.is_column_ref_expr() ||
expr.is_aggr_expr() ||
expr.is_win_func_expr() ||
expr.is_query_ref_expr() ||
expr.is_exec_param_expr() ||
expr.is_pseudo_column_expr() ||
expr.get_expr_type() == T_OP_ROW ||
expr.get_expr_type() == T_QUESTIONMARK;
}
inline bool is_blacklist_share_child(const ObRawExpr &expr)
{
return expr.is_aggr_expr() || expr.is_win_func_expr() || T_OP_CASE == expr.get_expr_type();
}
inline bool is_blacklist_share_const(const ObRawExpr &expr)
{
return T_OP_OR == expr.get_expr_type() || T_OP_AND == expr.get_expr_type();
}
private:
typedef ObSEArray<ObRawExprEntry, 1> SharedExprs;
@ -92,6 +112,7 @@ private:
uint64_t scope_id_;
ObQueryCtx *query_ctx_;
int64_t disable_share_const_level_;
};
}