hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[BUG] remove callback when on failure

Browse Source
This commit is contained in:
Handora
2023-04-04 07:14:37 +00:00
committed by ob-robot
parent a184912a69
commit a920d19e0a
9 changed files with 137 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
unittest/storage/memtable/mvcc/test_mvcc_callback.cpp
View File

@ -149,17 +149,18 @@ public:
return cb;
}
void create_and_append_callback(ObMemtable *mt,
bool need_submit_log = true,
bool need_fill_redo = true,
share::SCN scn = share::SCN::max_scn())
{
ObITransCallback *create_and_append_callback(ObMemtable *mt,
bool need_submit_log = true,
bool need_fill_redo = true,
share::SCN scn = share::SCN::max_scn())
{
ObMockTxCallback *cb = create_callback(mt,
need_submit_log,
need_fill_redo,
scn);
EXPECT_NE(NULL, (long)cb);
EXPECT_EQ(OB_SUCCESS, callback_list_.append_callback(cb));
return cb;
}
ObMemtable *create_memtable()
@ -227,6 +228,38 @@ int ObMockTxCallback::calc_checksum(const share::SCN checksum_scn,
return OB_SUCCESS;
}
TEST_F(TestTxCallbackList, remove_callback_on_failure)
{
ObMemtable *memtable = create_memtable();
share::SCN scn_1;
scn_1.convert_for_logservice(1);
create_and_append_callback(memtable,
false, /*need_submit_log*/
false, /*need_fill_redo*/
scn_1);
auto cb1 = create_and_append_callback(memtable,
false, /*need_submit_log*/
true /*need_fill_redo*/);
auto cb2 = create_and_append_callback(memtable,
false, /*need_submit_log*/
true /*need_fill_redo*/);
create_and_append_callback(memtable,
false, /*need_submit_log*/
true /*need_fill_redo*/);
ObCallbackScope scope;
int64_t removed_cnt = 0;
scope.start_ = ObITransCallbackIterator(cb1);
scope.end_ = ObITransCallbackIterator(cb2);
EXPECT_EQ(false, scope.is_empty());
EXPECT_EQ(OB_SUCCESS, callback_list_.sync_log_fail(scope, removed_cnt));
EXPECT_EQ(2, removed_cnt);
EXPECT_EQ(2, callback_list_.get_length());
}
TEST_F(TestTxCallbackList, remove_callback_by_tx_commit)
{
ObMemtable *memtable = create_memtable();