hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

bugfix: disable propagate const to T_OP_ROW

Browse Source
This commit is contained in:
obdev 2024-02-10 06:16:58 +00:00 committed by ob-robot
parent 8ff70b6622
commit af2d0042b6
2 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/sql/rewrite/ob_transform_const_propagate.cpp
View File

@ -1097,6 +1097,7 @@ int ObTransformConstPropagate::recursive_replace_expr(ObRawExpr *&cur_expr,
bool found = false; bool found = false;
bool is_shared = false; bool is_shared = false;
trans_happened = false; trans_happened = false;
bool can_replace_child = true;
if (OB_ISNULL(cur_expr)) { if (OB_ISNULL(cur_expr)) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("invalid parameter", K(ret)); LOG_WARN("invalid parameter", K(ret));
@ -1116,7 +1117,14 @@ int ObTransformConstPropagate::recursive_replace_expr(ObRawExpr *&cur_expr,
used_in_compare, used_in_compare,
trans_happened))) { trans_happened))) {
LOG_WARN("failed to replace expr internal", K(ret)); LOG_WARN("failed to replace expr internal", K(ret));
} else if (!trans_happened && cur_expr->get_param_count() > 0) { } else if (trans_happened || cur_expr->get_param_count() < 1) {
// do nothing
} else if (cur_expr->get_expr_type() == T_OP_ROW &&
OB_FAIL(check_can_replace_child_of_row(const_ctx, cur_expr, can_replace_child))) {
LOG_WARN("failed to check can replace in row", K(ret));
} else if (!can_replace_child) {
// do nothing
} else {
int64_t N = cur_expr->get_param_count(); int64_t N = cur_expr->get_param_count();
if (OB_FAIL(parent_exprs.push_back(cur_expr))) { if (OB_FAIL(parent_exprs.push_back(cur_expr))) {
LOG_WARN("failed to push back", K(ret)); LOG_WARN("failed to push back", K(ret));
@ -2662,5 +2670,35 @@ int ObTransformConstPropagate::replace_select_exprs_skip_agg_internal(ObRawExpr
return ret; return ret;
} }
// Check if all non-consts in T_OP_ROW can be replaced to consts.
int ObTransformConstPropagate::check_can_replace_child_of_row(ConstInfoContext &const_ctx,
ObRawExpr *&cur_expr,
bool &can_replace_child)
{
int ret = OB_SUCCESS;
if (OB_ISNULL(cur_expr)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("unexpected null", K(ret));
} else if (cur_expr->is_const_expr() || !const_ctx.allow_trans_) {
can_replace_child = false;
} else {
ObSEArray<ObRawExpr*, 4> const_cols;
bool is_const_recursively = false;
for (int64_t i = 0; OB_SUCC(ret) && i < const_ctx.active_const_infos_.count(); i++) {
if (OB_FAIL(const_cols.push_back(const_ctx.active_const_infos_.at(i).column_expr_))) {
LOG_WARN("failed to push back expr", K(ret));
}
}
if (OB_SUCC(ret) && OB_FAIL(ObOptimizerUtil::is_const_expr_recursively(cur_expr,
const_cols,
is_const_recursively))) {
LOG_WARN("failed to check const expr recursively", K(ret));
} else {
can_replace_child &= is_const_recursively;
}
}
return ret;
}
}// namespace sql }// namespace sql
} // namespace oceanbase } // namespace oceanbase

4
src/sql/rewrite/ob_transform_const_propagate.h
View File

@ -364,6 +364,10 @@ private:
int check_constraint_value_validity(ObRawExpr *value_expr, bool &reject); int check_constraint_value_validity(ObRawExpr *value_expr, bool &reject);
int check_can_replace_child_of_row(ConstInfoContext &const_ctx,
ObRawExpr *&cur_expr,
bool &can_replace_child);
private: private:
typedef ObSEArray<PullupConstInfo, 2> PullupConstInfos; typedef ObSEArray<PullupConstInfo, 2> PullupConstInfos;
ObArenaAllocator allocator_; ObArenaAllocator allocator_;