hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[WhiteScan] Fix some white scan errors

Browse Source
This commit is contained in:
br0
2021-09-17 19:24:43 +08:00
committed by wangzelin.wzl
parent 875865e081
commit b1581e364b
4 changed files with 57 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/engine/expr/ob_expr_div.cpp
View File

@ -403,7 +403,6 @@ int ObExprDiv::div_interval(
res.set_scale(ObAccuracy::MAX_ACCURACY2[ORACLE_MODE][res.get_type()].get_scale()); res.set_scale(ObAccuracy::MAX_ACCURACY2[ORACLE_MODE][res.get_type()].get_scale());
UNUSED(calc_scale); UNUSED(calc_scale);
return ret; return ret;
return ret;
} }
const ObScale ObExprDiv::DIV_CALC_SCALE = 9; const ObScale ObExprDiv::DIV_CALC_SCALE = 9;

5
src/sql/engine/expr/ob_expr_func_part_hash.cpp
View File

@ -574,7 +574,9 @@ int ObExprFuncPartHash::calc_oracle_vt_part_id(ObTaskExecutorCtx& task_exec_ctx,
} else { } else {
ObString ip = objs_stack[0].get_string(); ObString ip = objs_stack[0].get_string();
number::ObNumber port_num; number::ObNumber port_num;
objs_stack[1].get_number(port_num); if (OB_FAIL(objs_stack[1].get_number(port_num))) {
LOG_WARN("Get port_number failed.", K(ret));
} else {
int32_t port = atoi(port_num.format()); int32_t port = atoi(port_num.format());
ObAddr addr; ObAddr addr;
addr.set_ip_addr(ip, port); addr.set_ip_addr(ip, port);
@ -585,6 +587,7 @@ int ObExprFuncPartHash::calc_oracle_vt_part_id(ObTaskExecutorCtx& task_exec_ctx,
result.set_int(part_id); result.set_int(part_id);
} }
} }
}
return ret; return ret;
} }

1
src/sql/engine/expr/ob_expr_in.h
View File

@ -182,6 +182,7 @@ class ObExprInOrNotIn : public ObVectorExprOperator {
public: public:
ObExprInCtx() ObExprInCtx()
: ObExprOperatorCtx(), : ObExprOperatorCtx(),
row_dimension_(-1),
right_has_null(false), right_has_null(false),
hash_func_buff_(NULL), hash_func_buff_(NULL),
funcs_ptr_set(false), funcs_ptr_set(false),

5
src/sql/engine/expr/ob_expr_least.cpp
View File

@ -44,10 +44,6 @@ int ObExprBaseLeastGreatest::calc_result_typeN_oracle(
} else if (OB_ISNULL(types) || OB_UNLIKELY(param_num < 1)) { } else if (OB_ISNULL(types) || OB_UNLIKELY(param_num < 1)) {
ret = OB_INVALID_ARGUMENT; ret = OB_INVALID_ARGUMENT;
LOG_WARN("types is null or param_num is wrong", K(types), K(param_num), K(ret)); LOG_WARN("types is null or param_num is wrong", K(types), K(param_num), K(ret));
} else {
if (OB_ISNULL(types) || OB_UNLIKELY(param_num < 1)) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("types is null or param_num is wrong", K(types), K(param_num), K(ret));
} else { } else {
ObExprResType& first_type = types[0]; ObExprResType& first_type = types[0];
type = first_type; type = first_type;
@ -103,7 +99,6 @@ int ObExprBaseLeastGreatest::calc_result_typeN_oracle(
} }
} }
} }
}
if (ObNullType != types[0].get_type()) { if (ObNullType != types[0].get_type()) {
for (int64_t i = 1; OB_SUCC(ret) && i < param_num; i++) { for (int64_t i = 1; OB_SUCC(ret) && i < param_num; i++) {
OZ(ObObjCaster::can_cast_in_oracle_mode(types[0].get_type_class(), types[i].get_type_class())); OZ(ObObjCaster::can_cast_in_oracle_mode(types[0].get_type_class(), types[i].get_type_class()));