hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[4.1] fix tablet gc bug that skip process when tablet_change_scn has not changed

Browse Source
This commit is contained in:
obdev
2023-03-27 12:15:13 +00:00
committed by ob-robot
parent 6c22fc4d17
commit b486542a3f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/storage/tx_storage/ob_tablet_gc_service.cpp
View File

@ -76,9 +76,9 @@ int ObTabletGCService::start()
STORAGE_LOG(ERROR, "fail to init timer", KR(ret)); STORAGE_LOG(ERROR, "fail to init timer", KR(ret));
} else if (OB_FAIL(timer_for_tablet_gc_.init())) { } else if (OB_FAIL(timer_for_tablet_gc_.init())) {
STORAGE_LOG(ERROR, "fail to init timer", KR(ret)); STORAGE_LOG(ERROR, "fail to init timer", KR(ret));
} else if (OB_FAIL(timer_for_tablet_change_.schedule(tablet_gc_task_, GC_CHECK_INTERVAL, true))) { } else if (OB_FAIL(timer_for_tablet_change_.schedule(tablet_change_task_, GC_CHECK_INTERVAL, true))) {
STORAGE_LOG(ERROR, "fail to schedule task", KR(ret)); STORAGE_LOG(ERROR, "fail to schedule task", KR(ret));
} else if (OB_FAIL(timer_for_tablet_gc_.schedule(tablet_change_task_, GC_CHECK_DELETE_INTERVAL, true))) { } else if (OB_FAIL(timer_for_tablet_gc_.schedule(tablet_gc_task_, GC_CHECK_DELETE_INTERVAL, true))) {
STORAGE_LOG(ERROR, "fail to schedule task", KR(ret)); STORAGE_LOG(ERROR, "fail to schedule task", KR(ret));
} }
return ret; return ret;
@ -170,7 +170,7 @@ void ObTabletGCService::ObTabletChangeTask::runTimerTask()
STORAGE_LOG(WARN, "decide_max_decided_scn failed", KR(ret), K(freezer->get_ls_id())); STORAGE_LOG(WARN, "decide_max_decided_scn failed", KR(ret), K(freezer->get_ls_id()));
} else if (!checkpoint_scn.is_valid() } else if (!checkpoint_scn.is_valid()
|| SCN::min_scn() == checkpoint_scn || SCN::min_scn() == checkpoint_scn
|| checkpoint_scn <= ls->get_tablet_change_checkpoint_scn()) { || checkpoint_scn < ls->get_tablet_change_checkpoint_scn()) {
STORAGE_LOG(INFO, "no any log callback and no need to update clog checkpoint", STORAGE_LOG(INFO, "no any log callback and no need to update clog checkpoint",
K(freezer->get_ls_id()), K(checkpoint_scn), KPC(ls), K(ls->get_ls_meta())); K(freezer->get_ls_id()), K(checkpoint_scn), KPC(ls), K(ls->get_ls_meta()));
} }
@ -190,7 +190,8 @@ void ObTabletGCService::ObTabletChangeTask::runTimerTask()
STORAGE_LOG(WARN, "failed to flush_unpersist_tablet_ids", KPC(ls), KR(ret), K(unpersist_tablet_ids)); STORAGE_LOG(WARN, "failed to flush_unpersist_tablet_ids", KPC(ls), KR(ret), K(unpersist_tablet_ids));
} }
// 5. update tablet_change_checkpoint in log meta // 5. update tablet_change_checkpoint in log meta
else if (OB_FAIL(ls->set_tablet_change_checkpoint_scn(checkpoint_scn))) { else if (checkpoint_scn > ls->get_tablet_change_checkpoint_scn()
&& OB_FAIL(ls->set_tablet_change_checkpoint_scn(checkpoint_scn))) {
need_retry = true; need_retry = true;
STORAGE_LOG(WARN, "failed to set_tablet_change_checkpoint_scn", KPC(ls), KR(ret), K(checkpoint_scn)); STORAGE_LOG(WARN, "failed to set_tablet_change_checkpoint_scn", KPC(ls), KR(ret), K(checkpoint_scn));
} }