From b4afba40e59c07f2d6fdd1aa40df78c876d6d641 Mon Sep 17 00:00:00 2001
From: obdev <obdev@oceanbase.com>
Date: Tue, 10 Jan 2023 13:16:02 +0000
Subject: [PATCH] add error log when pthread join failed

---
 deps/oblib/src/lib/thread/thread.cpp | 47 +++++++++++++++++++++++++++-
 deps/oblib/src/lib/thread/thread.h   |  2 ++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/deps/oblib/src/lib/thread/thread.cpp b/deps/oblib/src/lib/thread/thread.cpp
index 37a55ec08d..bb81b57b8b 100644
--- a/deps/oblib/src/lib/thread/thread.cpp
+++ b/deps/oblib/src/lib/thread/thread.cpp
@@ -128,10 +128,55 @@ void Thread::stop()
   stop_ = true;
 }
 
+void Thread::dump_pth() // for debug pthread join faileds
+{
+#ifndef OB_USE_ASAN
+  int ret = OB_SUCCESS;
+  int fd = 0;
+  int64_t len = 0;
+  ssize_t size = 0;
+  char path[PATH_SIZE];
+  len = (char*)stack_addr_ + stack_size_ - (char*)pth_;
+  snprintf(path, PATH_SIZE, "log/dump_pth.%p.%d", (char*)pth_, (int)tid_);
+  LOG_WARN("dump pth start", K(path), K(pth_), K(tid_), K(len), K(stack_addr_), K(stack_size_));
+  if (NULL == (char*)pth_ || len >= stack_size_ || len <= 0) {
+    LOG_WARN("invalid member", K(pth_), K(stack_addr_), K(stack_size_));
+  } else if ((fd = ::open(path, O_WRONLY | O_CREAT | O_TRUNC,
+                          S_IRUSR  | S_IWUSR | S_IRGRP)) < 0) {
+    ret = OB_IO_ERROR;
+    LOG_WARN("fail to create file", KERRMSG, K(ret));
+  } else if (len != (size = write(fd, (char*)(pth_), len))) {
+    ret = OB_IO_ERROR;
+    LOG_WARN("dump pth fail", K(errno), KERRMSG, K(len), K(size), K(ret));
+    if (0 != close(fd)) {
+      LOG_WARN("fail to close file fd", K(fd), K(errno), KERRMSG, K(ret));
+    }
+  } else if (::fsync(fd) != 0) {
+    ret = OB_IO_ERROR;
+    LOG_WARN("sync pth fail", K(errno), KERRMSG, K(len), K(size), K(ret));
+    if (0 != close(fd)) {
+      LOG_WARN("fail to close file fd", K(fd), K(errno), KERRMSG, K(ret));
+    }
+  } else if (0 != close(fd)) {
+    ret = OB_IO_ERROR;
+    LOG_WARN("fail to close file fd", K(fd), KERRMSG, K(ret));
+  } else {
+    LOG_WARN("dump pth done", K(path), K(pth_), K(tid_), K(size));
+  }
+#endif
+}
+
 void Thread::wait()
 {
+  int ret = OB_SUCCESS;
   if (pth_ != 0) {
-    pthread_join(pth_, nullptr);
+    if (OB_FAIL(pthread_join(pth_, nullptr))) {
+      LOG_ERROR("pthread_join failed", K(ret), K(errno));
+#ifndef OB_USE_ASAN
+      dump_pth();
+      abort();
+#endif
+    }
     destroy_stack();
     pth_ = 0;
     pid_ = 0;
diff --git a/deps/oblib/src/lib/thread/thread.h b/deps/oblib/src/lib/thread/thread.h
index 2a24dbb855..717f195b3f 100644
--- a/deps/oblib/src/lib/thread/thread.h
+++ b/deps/oblib/src/lib/thread/thread.h
@@ -24,6 +24,7 @@ namespace lib {
 class Thread {
 public:
   using Runnable = std::function<void()>;
+  static constexpr int PATH_SIZE = 128;
   Thread();
   Thread(int64_t stack_size);
   Thread(Runnable runnable, int64_t stack_size=0);
@@ -34,6 +35,7 @@ public:
   void stop();
   void wait();
   void destroy();
+  void dump_pth();
 
   pid_t get_pid() const;
   pid_t get_tid() const;