update comment
This commit is contained in:
parent
a28b52781f
commit
c27891ea08
@ -309,7 +309,7 @@ int ObArchiveSchedulerService::start_tenant_archive_(const uint64_t tenant_id)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
ObArchiveHandler archive_handler;
|
||||
// TODO: wangxiaohui.wxh, start specific dest archive.
|
||||
// Only one dest is supported.
|
||||
const int64_t dest_no = 0;
|
||||
if (OB_FAIL(archive_handler.init(tenant_id, *server_mgr_, *zone_mgr_, *unit_mgr_, schema_service_, *rpc_proxy_, *sql_proxy_))) {
|
||||
LOG_WARN("failed to init archive_handler", K(ret));
|
||||
@ -326,7 +326,7 @@ int ObArchiveSchedulerService::stop_tenant_archive_(const uint64_t tenant_id)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
ObArchiveHandler archive_handler;
|
||||
// TODO: wangxiaohui.wxh, stop specific dest archive.
|
||||
// Only one dest is supported.
|
||||
const int64_t dest_no = 0;
|
||||
if (OB_FAIL(archive_handler.init(tenant_id, *server_mgr_, *zone_mgr_, *unit_mgr_, schema_service_, *rpc_proxy_, *sql_proxy_))) {
|
||||
LOG_WARN("failed to init archive_handler", K(ret), K(tenant_id));
|
||||
|
@ -134,7 +134,7 @@ static int record_piece_checkpoint(const ObTenantArchivePieceAttr &piece_info, c
|
||||
&& ObBackupFileStatus::STATUS::BACKUP_FILE_AVAILABLE == piece_info.file_status_)) {
|
||||
} else {
|
||||
// persist piece checkpoint
|
||||
// TODO: wangxiaohui.wxh, change overwrite to append.
|
||||
// TODO: change overwrite to append
|
||||
ObPieceCheckpointDesc checkpoint_desc;
|
||||
checkpoint_desc.tenant_id_ = piece_info.key_.tenant_id_;
|
||||
checkpoint_desc.dest_id_ = piece_info.key_.dest_id_;
|
||||
@ -671,7 +671,7 @@ int ObArchiveHandler::do_checkpoint_(share::ObTenantArchiveRoundAttr &round_info
|
||||
int ObArchiveHandler::notify_(const ObTenantArchiveRoundAttr &round)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
// TODO: wangxiaohui.wxh notify each log stream.
|
||||
// TODO: notify each log stream.
|
||||
UNUSED(round);
|
||||
// Get all log streams, and try the best to notify each log stream event of archive start.
|
||||
return ret;
|
||||
|
@ -215,7 +215,6 @@ int ObArchivePersistHelper::get_piece_switch_interval(
|
||||
} else if (OB_FAIL(dest_attr.set_piece_switch_interval(value.ptr()))) {
|
||||
LOG_WARN("fail to set piece switch interval", K(ret), K(value));
|
||||
} else {
|
||||
// TODO: need to adjust
|
||||
piece_switch_interval = dest_attr.piece_switch_interval_;
|
||||
}
|
||||
return ret;
|
||||
|
@ -384,7 +384,7 @@ int ObDataBackupDestConfigParser::update_inner_config_table(common::ObISQLClient
|
||||
ObBackupDestMgr dest_mgr;
|
||||
share::ObBackupPathString backup_dest;
|
||||
ObBackupDestType::TYPE dest_type = ObBackupDestType::TYPE::DEST_TYPE_BACKUP_DATA;
|
||||
// TODO: wangxiaohui.wxh, handle trans failed after write format file.
|
||||
// TODO: handle trans failed after write format file.
|
||||
if (!type_.is_valid() || 1 != config_items_.count() ) {
|
||||
ret = OB_INVALID_ARGUMENT;
|
||||
LOG_WARN("invalid parser", K(ret), KPC(this));
|
||||
@ -489,7 +489,7 @@ int ObLogArchiveDestConfigParser::update_archive_dest_config_(common::ObISQLClie
|
||||
LOG_WARN("fail to gen archive config items", K(ret));
|
||||
}
|
||||
|
||||
// TODO: wangxiaohui.wxh, handle trans failed after write format file.
|
||||
// TODO: handle trans failed after write format file.
|
||||
ARRAY_FOREACH_X(config_items_, i, cnt, OB_SUCC(ret)) {
|
||||
const BackupConfigItemPair &config_item = config_items_.at(i);
|
||||
if (OB_FAIL(helper.set_kv_item(trans, dest_no_, config_item.key_, config_item.value_))) {
|
||||
|
@ -354,7 +354,9 @@ int ObBackupCheckFile::generate_format_desc_(const share::ObBackupDest &dest, sh
|
||||
int ret = OB_SUCCESS;
|
||||
schema::ObSchemaGetterGuard schema_guard;
|
||||
const schema::ObTenantSchema *tenant_schema = nullptr;
|
||||
// TODO: wangxiaohui.wxh, pass GCONF and GCTX to class.
|
||||
|
||||
// TODO: pass GCONF and GCTX to class.
|
||||
|
||||
if (OB_ISNULL(GCTX.schema_service_)) {
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("invalid argument", K(ret), K(GCTX.schema_service_));
|
||||
|
@ -787,7 +787,9 @@ int ObBackupInfoChecker::get_item_count_(const uint64_t tenant_id, int64_t &item
|
||||
int ObBackupInfoChecker::get_status_line_count_(const uint64_t tenant_id, int64_t &status_count)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
// TODO: wangxiaohui.wxh, to remove
|
||||
|
||||
// TODO: to remove.
|
||||
|
||||
#if 0
|
||||
ObSqlString sql;
|
||||
SMART_VAR(ObMySQLProxy::ReadResult, res) {
|
||||
@ -929,7 +931,7 @@ int ObBackupInfoChecker::insert_log_archive_status_(
|
||||
common::ObMySQLTransaction &trans, const uint64_t tenant_id)
|
||||
{
|
||||
int ret = OB_SUCCESS;
|
||||
// TODO: wangxiaohui.wxh, to remove
|
||||
// TODO: to remove.
|
||||
#if 0
|
||||
ObSqlString sql;
|
||||
int64_t affected_rows = -1;
|
||||
|
@ -85,7 +85,7 @@ private:
|
||||
|
||||
};
|
||||
|
||||
// TODO(wangxiaohui.wxh): move functions in ObBackupInfoOperator into ObTenantBackupInfoOperation.
|
||||
// TODO: merge ObBackupInfoOperator into ObTenantBackupInfoOperation.
|
||||
class ObBackupInfoOperator final
|
||||
{
|
||||
public:
|
||||
|
@ -38,7 +38,7 @@ public:
|
||||
|
||||
|
||||
// Wrapper backup serialize data with common backup header.
|
||||
// TODO: wangxiaohui.wxh, support deserialize according to different version.
|
||||
// TODO: support deserialize according to different version.
|
||||
class ObBackupSerializeHeaderWrapper final : public ObIBackupSerializeProvider
|
||||
{
|
||||
public:
|
||||
|
@ -500,7 +500,7 @@ int ObBackupDestMgr::generate_format_desc_(
|
||||
schema::ObSchemaGetterGuard schema_guard;
|
||||
share::ObBackupPathString root_path;
|
||||
const schema::ObTenantSchema *tenant_schema = nullptr;
|
||||
// TODO: wangxiaohui.wxh, pass GCONF and GCTX to class.
|
||||
// TODO: pass GCONF and GCTX to class.
|
||||
if (OB_ISNULL(GCTX.schema_service_)) {
|
||||
ret = OB_ERR_UNEXPECTED;
|
||||
LOG_WARN("invalid argument", K(ret), K(GCTX.schema_service_));
|
||||
|
@ -22,7 +22,7 @@ using namespace share;
|
||||
// round op
|
||||
int ObTenantArchiveMgr::get_tenant_current_round(const int64_t tenant_id, const int64_t incarnation, ObTenantArchiveRoundAttr &round_attr)
|
||||
{
|
||||
// TODO: fix get round from other channel
|
||||
// Only one dest is supported now.
|
||||
const int64_t fake_dest_no = 0;
|
||||
return get_dest_round_by_dest_no(tenant_id, fake_dest_no, round_attr);
|
||||
}
|
||||
|
@ -68,7 +68,6 @@ class ObPhysicalRestoreUriParser
|
||||
public:
|
||||
ObPhysicalRestoreUriParser() = default;
|
||||
~ObPhysicalRestoreUriParser() = default;
|
||||
// TODO: wangxiaohui.wxh, filter same path
|
||||
static int parse(
|
||||
const common::ObString &multi_uri,
|
||||
common::ObArenaAllocator &allocator,
|
||||
|
Loading…
x
Reference in New Issue
Block a user