hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

add log in compaction diagnose

Browse Source
This commit is contained in:
a1iive
2023-07-11 15:11:59 +00:00
committed by ob-robot
parent a77abb22ee
commit c3f0fb704b
4 changed files with 41 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/share/scheduler/ob_diagnose_config.h
View File

@ -73,10 +73,10 @@ static constexpr ObDiagnoseInfoStruct OB_SUSPECT_INFO_TYPES[] = {
static_assert(sizeof(OB_SUSPECT_INFO_TYPES) / sizeof(ObDiagnoseInfoStruct) == SUSPECT_INFO_TYPE_MAX + 1, "Not enough initializer");
static constexpr ObDiagnoseInfoStruct OB_DAG_WARNING_INFO_TYPES[] = {
{2, true, "DAG_MINI_MERGE", {"ls_id", "tablet_id"}},
{2, true, "DAG_MINOR_MERGE", {"ls_id", "tablet_id"}},
{2, true, "DAG_MAJOR_MERGE", {"ls_id", "tablet_id"}},
{2, true, "DAG_TX_TABLE_MERGE", {"ls_id", "tablet_id"}},
{3, true, "DAG_MINI_MERGE", {"ls_id", "tablet_id", "compaction_scn"}},
{3, true, "DAG_MINOR_MERGE", {"ls_id", "tablet_id", "compaction_scn"}},
{3, true, "DAG_MAJOR_MERGE", {"ls_id", "tablet_id", "compaction_scn"}},
{3, true, "DAG_TX_TABLE_MERGE", {"ls_id", "tablet_id", "compaction_scn"}},
{0, false, "DAG_WRITE_CKPT", {}},
{3, false, "DAG_TYPE_MDS_TABLE_MERGE", {"ls_id", "tablet_id", "flush_scn"}},

61
src/storage/compaction/ob_compaction_diagnose.cpp
View File

@ -624,6 +624,9 @@ int ObCompactionDiagnoseMgr::diagnose_dag(
STORAGE_LOG(WARN, "failed to diagnose dag", K(ret), K(ls_id), K(tablet_id), K(progress));
}
}
if (OB_HASH_NOT_EXIST == ret) {
LOG_TRACE("dag not exist", K(ret), K(dag));
}
return ret;
}
@ -1162,32 +1165,35 @@ int ObCompactionDiagnoseMgr::diagnose_tablet_medium_merge(
table_store_wrapper.get_member()->get_major_sstables().get_boundary_table(true/*last*/))) {
} else if (OB_FAIL(tablet.get_max_sync_medium_scn(max_sync_medium_scn))){
LOG_WARN("failed to get max sync medium scn", K(ret), K(ls_id), K(tablet_id));
} else if (max_sync_medium_scn > last_major_sstable->get_snapshot_version()) {
if (tablet.get_snapshot_version() < max_sync_medium_scn) { // wait mini compaction or tablet freeze
if (ObTimeUtility::current_time_ns() > max_sync_medium_scn + WAIT_MEDIUM_SCHEDULE_INTERVAL * 2
&& can_add_diagnose_info()
&& OB_FAIL(SET_DIAGNOSE_INFO(
info_array_[idx_++],
} else {
LOG_TRACE("diagnose tablet medium merge", K(max_sync_medium_scn));
if (max_sync_medium_scn > last_major_sstable->get_snapshot_version()) {
if (tablet.get_snapshot_version() < max_sync_medium_scn) { // wait mini compaction or tablet freeze
if (ObTimeUtility::current_time_ns() > max_sync_medium_scn + WAIT_MEDIUM_SCHEDULE_INTERVAL * 2
&& can_add_diagnose_info()
&& OB_FAIL(SET_DIAGNOSE_INFO(
info_array_[idx_++],
merge_type,
MTL_ID(),
ls_id,
tablet_id,
ObCompactionDiagnoseInfo::DIA_STATUS_NOT_SCHEDULE,
ObTimeUtility::fast_current_time(),
"max_receive_medium_scn", max_sync_medium_scn,
"max_serialized_medium_scn", max_serialized_medium_scn,
"tablet_snapshot", tablet.get_snapshot_version()))) {
LOG_WARN("failed to add diagnose info", K(ret), K(ls_id), K(tablet_id));
}
} else if (max_sync_medium_scn != compaction_scn) {
ObTabletMajorMergeDag dag;
if (OB_FAIL(diagnose_tablet_merge(
dag,
merge_type,
MTL_ID(),
ls_id,
tablet_id,
ObCompactionDiagnoseInfo::DIA_STATUS_NOT_SCHEDULE,
ObTimeUtility::fast_current_time(),
"max_receive_medium_scn", max_sync_medium_scn,
"max_serialized_medium_scn", max_serialized_medium_scn,
"tablet_snapshot", tablet.get_snapshot_version()))) {
LOG_WARN("failed to add diagnose info", K(ret), K(ls_id), K(tablet_id));
}
} else if (max_sync_medium_scn != compaction_scn) {
ObTabletMajorMergeDag dag;
if (OB_FAIL(diagnose_tablet_merge(
dag,
merge_type,
ls_id,
tablet_id,
max_sync_medium_scn))) {
LOG_WARN("diagnose failed", K(ret), K(ls_id), K(tablet_id), KPC(last_major_sstable));
max_sync_medium_scn))) {
LOG_WARN("diagnose failed", K(ret), K(ls_id), K(tablet_id), KPC(last_major_sstable));
}
}
}
}
@ -1218,6 +1224,7 @@ int ObCompactionDiagnoseMgr::diagnose_tablet_major_merge(
} else if (OB_FAIL(tablet.fetch_table_store(table_store_wrapper))) {
LOG_WARN("fail to fetch table store", K(ret));
} else {
LOG_TRACE("diagnose tablet major merge", K(max_sync_medium_scn));
ObSSTable *latest_major_sstable = static_cast<ObSSTable*>(
table_store_wrapper.get_member()->get_major_sstables().get_boundary_table(true/*last*/));
int tmp_ret = OB_SUCCESS;
@ -1288,6 +1295,7 @@ int ObCompactionDiagnoseMgr::diagnose_tablet_merge(
LOG_WARN("failed to add diagnose info", K(ret), K(ls_id), K(tablet_id), K(progress));
}
}
LOG_TRACE("dag exist", K(dag), K(progress));
} else if (OB_FAIL(diagnose_no_dag(dag, merge_type, ls_id, tablet_id, compaction_scn))) {
LOG_WARN("failed to dagnose no dag", K(ret), K(ls_id), K(tablet_id));
}
@ -1312,6 +1320,7 @@ int ObCompactionDiagnoseMgr::get_suspect_and_warning_info(
if (OB_HASH_NOT_EXIST != ret) {
LOG_WARN("failed to get suspect info", K(ret), K(ls_id), K(tablet_id));
} else { // no schedule suspect info
LOG_TRACE("suspect info not exist", K(ret), K(dag));
info.info_param_ = nullptr;
allocator.reuse();
char tmp_str[common::OB_DAG_WARNING_INFO_LENGTH] = "\0";
@ -1322,12 +1331,12 @@ int ObCompactionDiagnoseMgr::get_suspect_and_warning_info(
LOG_WARN("failed to get dag warning info", K(ret), K(ls_id), K(tablet_id));
} else { // no execute failure
ret = OB_SUCCESS;
LOG_DEBUG("may wait for schedule", K(ret), K(ls_id), K(tablet_id));
LOG_TRACE("may wait for schedule", K(ret), K(ls_id), K(tablet_id));
}
} else if (can_add_diagnose_info()) {
if (OB_FAIL(warning_info.info_param_->fill_comment(tmp_str, sizeof(tmp_str)))) {
STORAGE_LOG(WARN, "failed to fill comment from info param", K(ret));
}else if (OB_FAIL(SET_DIAGNOSE_INFO(
} else if (OB_FAIL(SET_DIAGNOSE_INFO(
info_array_[idx_++],
merge_type,
MTL_ID(),
@ -1370,7 +1379,7 @@ int ObCompactionDiagnoseMgr::diagnose_no_dag(
ret = OB_ERR_UNEXPECTED;
LOG_WARN("merge version or freeze ts is invalid", K(ret), K(compaction_scn));
} else {
LOG_INFO("diagnose major", K(ret), K(ls_id), K(tablet_id), K(merge_type));
LOG_TRACE("diagnose with suspect info", K(ret), K(ls_id), K(tablet_id), K(merge_type));
ObDiagnoseTabletCompProgress progress;
ObTabletMiniMergeDag mini_dag;
if (OB_FAIL(diagnose_dag(MINI_MERGE, ls_id, tablet_id, ObVersionRange::MIN_VERSION, mini_dag, progress))) {

1
src/storage/compaction/ob_tablet_merge_task.cpp
View File

@ -405,6 +405,7 @@ int ObBasicTabletMergeDag::fill_info_param(compaction::ObIBasicInfoParam *&out_p
if (OB_FAIL(ADD_DAG_WARN_INFO_PARAM(out_param, allocator, get_type(),
ls_id_.id(),
static_cast<int64_t>(tablet_id_.id()),
param_.merge_version_,
"merge_type", merge_type))) {
LOG_WARN("failed to fill info param", K(ret));
}

2
unittest/storage/test_dag_warning_history.cpp
View File

@ -75,7 +75,7 @@ class ObBasicDag : public ObIDag
{
public:
ObBasicDag() :
ObIDag(ObDagType::DAG_TYPE_MINI_MERGE)
ObIDag(ObDagType::DAG_TYPE_TABLET_BACKFILL_TX)
{}
void init() { is_inited_ = true; }
virtual int64_t hash() const {