hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

modify log level of async_cb and get pcode from cb first

Browse Source
This commit is contained in:
obdev
2023-04-24 13:11:23 +00:00
committed by ob-robot
parent dad6688384
commit c4fb5cb985
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
deps/oblib/src/rpc/frame/ob_req_transport.cpp vendored
View File

@ -76,6 +76,7 @@ int async_cb(easy_request_t *r)
typedef ObReqTransport::AsyncCB ACB; typedef ObReqTransport::AsyncCB ACB;
ACB *cb = reinterpret_cast<ACB*>(r->user_data); ACB *cb = reinterpret_cast<ACB*>(r->user_data);
cb->record_stat(r->ipacket == NULL); cb->record_stat(r->ipacket == NULL);
pcode = cb->get_pcode();
if (!r->ipacket) { if (!r->ipacket) {
// 1. destination doesn't response // 1. destination doesn't response
@ -96,9 +97,9 @@ int async_cb(easy_request_t *r)
ret = OB_LIBEASY_ERROR; ret = OB_LIBEASY_ERROR;
} else if (OB_FAIL(cb->decode(r->ipacket))) { } else if (OB_FAIL(cb->decode(r->ipacket))) {
cb->on_invalid(); cb->on_invalid();
LOG_DEBUG("decode failed", K(ret)); LOG_WARN("decode failed", K(ret), K(pcode));
} else if (OB_PACKET_CLUSTER_ID_NOT_MATCH == cb->get_rcode()) { } else if (OB_PACKET_CLUSTER_ID_NOT_MATCH == cb->get_rcode()) {
LOG_WARN("wrong cluster id", K(ret), K(easy_connection_str(r->ms->c))); LOG_WARN("wrong cluster id", K(ret), K(easy_connection_str(r->ms->c)), K(pcode));
cb->set_error(EASY_CLUSTER_ID_MISMATCH); cb->set_error(EASY_CLUSTER_ID_MISMATCH);
ret = cb->on_error(EASY_CLUSTER_ID_MISMATCH); ret = cb->on_error(EASY_CLUSTER_ID_MISMATCH);
if (OB_ERROR == ret) { if (OB_ERROR == ret) {
@ -119,7 +120,7 @@ int async_cb(easy_request_t *r)
pkt->get_clen() + pkt->get_header_size() + OB_NET_HEADER_LENGTH); pkt->get_clen() + pkt->get_header_size() + OB_NET_HEADER_LENGTH);
if (OB_FAIL(cb->process())) { if (OB_FAIL(cb->process())) {
LOG_DEBUG("process failed", K(ret)); LOG_WARN("process failed", K(ret), K(pcode));
} }
if (cb_cloned) { if (cb_cloned) {
@ -140,7 +141,7 @@ int async_cb(easy_request_t *r)
} }
if (!OB_SUCC(ret)) { if (!OB_SUCC(ret)) {
LOG_DEBUG("process async request fail", K(r), K(ret)); LOG_WARN("process async request fail", K(r), K(ret), K(pcode));
} }
const int64_t cur_time = ObTimeUtility::current_time(); const int64_t cur_time = ObTimeUtility::current_time();
@ -150,7 +151,7 @@ int async_cb(easy_request_t *r)
const int64_t session_destroy_time = cur_time - after_process_time; const int64_t session_destroy_time = cur_time - after_process_time;
if (total_time > OB_EASY_HANDLER_COST_TIME) { if (total_time > OB_EASY_HANDLER_COST_TIME) {
LOG_WARN_RET(OB_ERR_TOO_MUCH_TIME, "async_cb handler cost too much time", K(total_time), K(decode_time), LOG_WARN_RET(OB_ERR_TOO_MUCH_TIME, "async_cb handler cost too much time", K(total_time), K(decode_time),
K(process_time), K(session_destroy_time), K(pcode)); K(process_time), K(session_destroy_time), K(ret), K(pcode));
} }
return EASY_OK; return EASY_OK;

1
deps/oblib/src/rpc/frame/ob_req_transport.h vendored
View File

@ -123,6 +123,7 @@ public:
int64_t get_send_ts() { return send_ts_; } int64_t get_send_ts() { return send_ts_; }
void set_payload(const int64_t payload) { payload_ = payload; } void set_payload(const int64_t payload) { payload_ = payload; }
int64_t get_payload() { return payload_; } int64_t get_payload() { return payload_; }
obrpc::ObRpcPacketCode get_pcode() const { return static_cast<obrpc::ObRpcPacketCode>(pcode_); }
void* low_level_cb_; void* low_level_cb_;
private: private: