hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix dynamic leak in cost based rewrite

Browse Source
This commit is contained in:
xianyu-w 2023-07-21 08:12:44 +00:00 committed by ob-robot
parent 145e1ce044
commit c76d1f3c71
1 changed files with 34 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/rewrite/ob_transform_rule.cpp
View File

@ -381,7 +381,6 @@ int ObTransformRule::evaluate_cost(common::ObIArray<ObParentDMLStmt> &parent_stm
ctx_->eval_cost_ = true; ctx_->eval_cost_ = true;
ParamStore &param_store = ctx_->exec_ctx_->get_physical_plan_ctx()->get_param_store_for_update(); ParamStore &param_store = ctx_->exec_ctx_->get_physical_plan_ctx()->get_param_store_for_update();
ObDMLStmt *root_stmt = NULL; ObDMLStmt *root_stmt = NULL;
lib::MemoryContext mem_context = nullptr;
lib::ContextParam param; lib::ContextParam param;
ObTransformerImpl trans(ctx_); ObTransformerImpl trans(ctx_);
param.set_mem_attr(ctx_->session_info_->get_effective_tenant_id(), param.set_mem_attr(ctx_->session_info_->get_effective_tenant_id(),
@ -393,19 +392,15 @@ int ObTransformRule::evaluate_cost(common::ObIArray<ObParentDMLStmt> &parent_stm
LOG_WARN("failed to prepare eval cost stmt", K(ret)); LOG_WARN("failed to prepare eval cost stmt", K(ret));
} else if (OB_FAIL(trans.transform_heuristic_rule(reinterpret_cast<ObDMLStmt*&>(root_stmt)))) { } else if (OB_FAIL(trans.transform_heuristic_rule(reinterpret_cast<ObDMLStmt*&>(root_stmt)))) {
LOG_WARN("failed to transform heuristic rule", K(ret)); LOG_WARN("failed to transform heuristic rule", K(ret));
} else if (OB_FAIL(CURRENT_CONTEXT->CREATE_CONTEXT(mem_context, param))) {
LOG_WARN("failed to create memory entity", K(ret));
} else if (OB_ISNULL(mem_context)) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("failed to create memory entity", K(ret));
} else { } else {
LOG_DEBUG("get transformed heuristic rule stmt when evaluate_cost", K(*root_stmt)); LOG_DEBUG("get transformed heuristic rule stmt when evaluate_cost", K(*root_stmt));
CREATE_WITH_TEMP_CONTEXT(param) {
HEAP_VAR(ObOptimizerContext, optctx, HEAP_VAR(ObOptimizerContext, optctx,
ctx_->session_info_, ctx_->session_info_,
ctx_->exec_ctx_, ctx_->exec_ctx_,
ctx_->sql_schema_guard_, ctx_->sql_schema_guard_,
ctx_->opt_stat_mgr_, ctx_->opt_stat_mgr_,
mem_context->get_arena_allocator(), CURRENT_CONTEXT->get_arena_allocator(),
&ctx_->exec_ctx_->get_physical_plan_ctx()->get_param_store(), &ctx_->exec_ctx_->get_physical_plan_ctx()->get_param_store(),
*ctx_->self_addr_, *ctx_->self_addr_,
GCTX.srv_rpc_proxy_, GCTX.srv_rpc_proxy_,
@ -425,7 +420,6 @@ int ObTransformRule::evaluate_cost(common::ObIArray<ObParentDMLStmt> &parent_stm
LOG_WARN("failed to check transformed plan", K(ret)); LOG_WARN("failed to check transformed plan", K(ret));
} }
} }
}
if (OB_SUCC(ret)) { if (OB_SUCC(ret)) {
if (OB_FAIL(eval_cost_helper.recover_context(*ctx_->exec_ctx_->get_physical_plan_ctx(), if (OB_FAIL(eval_cost_helper.recover_context(*ctx_->exec_ctx_->get_physical_plan_ctx(),
*ctx_->exec_ctx_->get_stmt_factory()->get_query_ctx(), *ctx_->exec_ctx_->get_stmt_factory()->get_query_ctx(),
@ -433,8 +427,8 @@ int ObTransformRule::evaluate_cost(common::ObIArray<ObParentDMLStmt> &parent_stm
LOG_WARN("failed to recover context", K(ret)); LOG_WARN("failed to recover context", K(ret));
} else if (OB_FAIL(ObTransformUtils::free_stmt(*ctx_->stmt_factory_, root_stmt))) { } else if (OB_FAIL(ObTransformUtils::free_stmt(*ctx_->stmt_factory_, root_stmt))) {
LOG_WARN("failed to free stmt", K(ret)); LOG_WARN("failed to free stmt", K(ret));
} else { }
DESTROY_CONTEXT(mem_context); }
} }
} }
} }