hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

close skip_ghost_row for wrong is_rowkey_first_row_already_output_ flag

Browse Source
This commit is contained in:
yangqise7en
2024-04-09 10:25:25 +00:00
committed by ob-robot
parent d3d37f4e93
commit cc135f2ce2
4 changed files with 125 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/storage/blocksstable/ob_micro_block_row_scanner.cpp
View File

@ -2023,7 +2023,6 @@ int ObMultiVersionMicroBlockMinorMergeRowScanner::inner_get_next_row(const ObDat
// set delete/insert committed row compacted
row_.set_compacted_multi_version_row();
}
return ret;
}

3
src/storage/compaction/ob_partition_merge_iter.cpp
View File

@ -1604,10 +1604,12 @@ int ObPartitionMinorRowMergeIter::next()
ret = OB_ERR_UNEXPECTED;
LOG_WARN("Unexpceted null current row", K(ret), K(*this));
}
/* TODO is_rowkey_first_row_already_output_ is not right, can't skip ghost row now
} else if (OB_FAIL(skip_ghost_row())) {
if (OB_UNLIKELY(ret != OB_ITER_END)) {
LOG_WARN("Failed to skip_ghost_row", K(ret));
}
*/
} else if (need_recycle_mv_row()) {
if (OB_FAIL(compact_old_row())) {
LOG_WARN("Failed to compact_old_row", K(ret));
@ -1619,7 +1621,6 @@ int ObPartitionMinorRowMergeIter::next()
if (OB_SUCC(ret) && curr_row_ != nullptr && curr_row_->is_last_multi_version_row()) {
check_committing_trans_compacted_ = true;
}
return ret;
}