hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] Reset left_brs.skip_ with enough size after get_left_batch in NLJ

Browse Source
This commit is contained in:
pe-99y
2024-03-27 04:20:40 +00:00
committed by ob-robot
parent 62eb9bd22b
commit cc85856379
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sql/engine/join/ob_nested_loop_join_op.cpp
View File

@ -821,7 +821,11 @@ int ObNestedLoopJoinOp::group_get_left_batch(const ObBatchRows *&left_brs)
} }
if (OB_SUCC(ret)) { if (OB_SUCC(ret)) {
const_cast<ObBatchRows *>(left_brs)->skip_->reset(read_size); // left_brs.size_ may be larger or smaller than read_size:
// left_brs.size_ > read_size: group size is small and lots of left rows were skipped;
// left_brs.size_ < read_size: left_brs reaches iter end with no enough rows;
// Thus, we need to reset skip_ with max size of left_brs.size_ and read_size.
const_cast<ObBatchRows *>(left_brs)->skip_->reset(std::max(left_brs->size_, read_size));
const_cast<ObBatchRows *>(left_brs)->size_ = read_size; const_cast<ObBatchRows *>(left_brs)->size_ = read_size;
const_cast<ObBatchRows *>(left_brs)->end_ = false; const_cast<ObBatchRows *>(left_brs)->end_ = false;
left_row_joined_ = false; left_row_joined_ = false;
@ -847,7 +851,11 @@ int ObNestedLoopJoinOp::group_get_left_batch(const ObBatchRows *&left_brs)
LOG_WARN("get next batch from store failed", KR(ret)); LOG_WARN("get next batch from store failed", KR(ret));
} }
} else { } else {
const_cast<ObBatchRows *>(left_brs)->skip_->reset(read_size); // left_brs.size_ may be larger or smaller than read_size:
// left_brs.size_ > read_size: group size is small and lots of left rows were skipped;
// left_brs.size_ < read_size: left_brs reaches iter end with no enough rows;
// Thus, we need to reset skip_ with max size of left_brs.size_ and read_size.
const_cast<ObBatchRows *>(left_brs)->skip_->reset(std::max(left_brs->size_, read_size));
const_cast<ObBatchRows *>(left_brs)->size_ = read_size; const_cast<ObBatchRows *>(left_brs)->size_ = read_size;
const_cast<ObBatchRows *>(left_brs)->end_ = false; const_cast<ObBatchRows *>(left_brs)->end_ = false;
left_row_joined_ = false; left_row_joined_ = false;