From cf46abc3e923e7b9a8208258d9936b8553354ab5 Mon Sep 17 00:00:00 2001 From: obdev Date: Tue, 7 Feb 2023 16:38:11 +0800 Subject: [PATCH] [to #32475164] fix typo by review 11475789 --- src/pl/ob_pl_package_state.cpp | 4 +--- src/sql/ob_spi.cpp | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/pl/ob_pl_package_state.cpp b/src/pl/ob_pl_package_state.cpp index 3615633769..89a2c461c8 100644 --- a/src/pl/ob_pl_package_state.cpp +++ b/src/pl/ob_pl_package_state.cpp @@ -52,9 +52,7 @@ bool ObPackageStateVersion::operator ==(const ObPackageStateVersion &other) { bool b_ret = true; if (package_version_ != other.package_version_ - || (package_body_version_ != OB_INVALID_VERSION - && other.package_body_version_ != OB_INVALID_VERSION - && package_body_version_ != other.package_body_version_)) { + || package_body_version_ != other.package_body_version_) { b_ret = false; } return b_ret; diff --git a/src/sql/ob_spi.cpp b/src/sql/ob_spi.cpp index d7148e4adc..38c8f48c3c 100644 --- a/src/sql/ob_spi.cpp +++ b/src/sql/ob_spi.cpp @@ -884,7 +884,8 @@ int ObSPIService::spi_calc_subprogram_expr(ObPLExecCtx *ctx, OZ (ObPLContext::get_exec_state_from_local(*session_info, package_id, routine_id, state)); CK (OB_NOT_NULL(state)); CK (OB_NOT_NULL(exec_ctx = state->get_exec_ctx().exec_ctx_)); - CK (OB_NOT_NULL(expr = state->get_function().get_default_expr(expr_idx))); + CK (expr_idx >= 0 && expr_idx < state->get_function().get_expressions().count()); + CK (OB_NOT_NULL(expr = state->get_function().get_expressions().at(expr_idx))); if (OB_SUCC(ret)) { ExecCtxBak exec_ctx_bak; OX (exec_ctx_bak.backup(*exec_ctx));