hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] Add defensive check code for inner table and weak read

Browse Source
This commit is contained in:
Naynahs
2024-06-18 04:33:02 +00:00
committed by ob-robot
parent e2661c1548
commit d2841956bc
4 changed files with 36 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/ob_sql_trans_control.cpp
View File

@ -730,12 +730,13 @@ int ObSqlTransControl::stmt_sanity_check_(ObSQLSessionInfo *session,
int ret = OB_SUCCESS;
ObConsistencyLevel current_consist_level = plan_ctx->get_consistency_level();
CK (current_consist_level != ObConsistencyLevel::INVALID_CONSISTENCY);
const bool contain_inner_table = plan->is_contain_inner_table();
// adjust stmt's consistency level
if (OB_SUCC(ret)) {
// Weak read statement with inner table should be converted to strong read.
// For example, schema refresh statement;
if (plan->is_contain_inner_table() ||
if (contain_inner_table ||
(!plan->is_plain_select() && current_consist_level != ObConsistencyLevel::STRONG)) {
plan_ctx->set_consistency_level(ObConsistencyLevel::STRONG);
}
@ -762,6 +763,13 @@ int ObSqlTransControl::stmt_sanity_check_(ObSQLSessionInfo *session,
LOG_USER_ERROR(OB_NOT_SUPPORTED, "weak consistency under SERIALIZABLE and REPEATABLE-READ isolation level");
}
}
if (OB_SUCC(ret)
&& !plan_ctx->check_consistency_level_validation(contain_inner_table)) {
ret = OB_ERR_UNEXPECTED;
TRANS_LOG(ERROR, "unexpected consistency level", K(ret), K(contain_inner_table),
"current_level", current_consist_level,
"plan_ctx_level", plan_ctx->get_consistency_level());
}
return ret;
}