hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

dayofweek and dayname function‘s return value of ret is lost because without using OB_FAIL

Browse Source
This commit is contained in:
obdev
2022-11-09 11:40:46 +00:00
committed by wangzelin.wzl
parent 0f714e6f87
commit d43171fc6c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/engine/expr/ob_expr_day_of_func.cpp
View File

@ -50,7 +50,7 @@ ObExprDayOfWeek::~ObExprDayOfWeek() {}
int ObExprDayOfWeek::calc_dayofweek(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &expr_datum) int ObExprDayOfWeek::calc_dayofweek(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &expr_datum)
{ {
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
if (ObExprTimeBase::calc(expr, ctx, expr_datum, DT_WDAY, true)) { if (OB_FAIL(ObExprTimeBase::calc(expr, ctx, expr_datum, DT_WDAY, true))) {
LOG_WARN("calc day of week failed", K(ret)); LOG_WARN("calc day of week failed", K(ret));
} else if (!expr_datum.is_null()) { } else if (!expr_datum.is_null()) {
expr_datum.set_int32(expr_datum.get_int32() % 7 + 1); expr_datum.set_int32(expr_datum.get_int32() % 7 + 1);
@ -623,7 +623,7 @@ ObExprDayName::~ObExprDayName() {}
int ObExprDayName::calc_dayname(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &expr_datum) int ObExprDayName::calc_dayname(const ObExpr &expr, ObEvalCtx &ctx, ObDatum &expr_datum)
{ {
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
if (ObExprTimeBase::calc(expr, ctx, expr_datum, DT_WDAY, true)) { if (OB_FAIL(ObExprTimeBase::calc(expr, ctx, expr_datum, DT_WDAY, true))) {
LOG_WARN("dayname calc day of dayweek failed", K(ret)); LOG_WARN("dayname calc day of dayweek failed", K(ret));
} }
return ret; return ret;