hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix bug, drop hash key has not same error code like mysql and oracle

Browse Source
This commit is contained in:
obdev
2023-10-25 06:43:15 +00:00
committed by ob-robot
parent 5586d55073
commit d4730c71fe
5 changed files with 37 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/sql/resolver/ddl/ob_alter_table_resolver.cpp
View File

@ -5638,6 +5638,9 @@ int ObAlterTableResolver::resolve_drop_column(const ParseNode &node, ObReducedVi
alter_column_schema.get_origin_column_name(),
alter_table_stmt))) {
SQL_RESV_LOG(WARN, "failed to check column in foreign key for oracle mode", K(ret));
} else if (OB_FAIL(check_drop_column_is_partition_key(*table_schema_,
alter_column_schema.get_origin_column_name()))) {
SQL_RESV_LOG(WARN, "failed to check column in parition key", K(ret));
} else if (OB_FAIL(check_column_in_check_constraint(
*table_schema_,
alter_column_schema.get_origin_column_name(),
@ -5969,5 +5972,31 @@ int ObAlterTableResolver::check_mysql_rename_column(const AlterColumnSchema &alt
return ret;
}
/*
* chech the droped column is partition key,
* if ture, forbid the action
*/
int ObAlterTableResolver::check_drop_column_is_partition_key(const ObTableSchema &table_schema, const ObString &column_name)
{
int ret=OB_SUCCESS;
if (!table_schema.is_valid()) {
ret = OB_INVALID_ARGUMENT;
SQL_RESV_LOG(WARN, "invalid arguemnt", K(ret), K(table_schema));
} else {
const ObColumnSchemaV2 *origin_column = table_schema.get_column_schema(column_name);
if (OB_ISNULL(origin_column)) {
// do nothing
// 根据列名查不到列是因为表中不存在该列，后面会在 RS 端再检查一遍表中是否存在该列，并在 RS 端根据操作的不同报不同的错误
} else if (origin_column->is_tbl_part_key_column()){
ret = OB_ERR_DEPENDENT_BY_PARTITION_FUNC;
LOG_USER_ERROR(OB_ERR_DEPENDENT_BY_PARTITION_FUNC,
column_name.length(),
column_name.ptr());
LOG_WARN("alter column has table part key deps", K(ret), K(origin_column));
}
}
return ret;
}
} //namespace common
} //namespace oceanbase