hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix the length of encrypted_passwd when set backup passwd

Browse Source
This commit is contained in:
wxhwang
2023-11-10 07:39:08 +00:00
committed by ob-robot
parent 9d9cdc2cd9
commit d49d442c2f
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/sql/resolver/cmd/ob_alter_system_stmt.cpp
View File

@ -32,14 +32,25 @@ ObBackupSetEncryptionStmt::ObBackupSetEncryptionStmt()
int ObBackupSetEncryptionStmt::set_param(const int64_t mode, const common::ObString &passwd) int ObBackupSetEncryptionStmt::set_param(const int64_t mode, const common::ObString &passwd)
{ {
int ret = common::OB_SUCCESS; int ret = common::OB_SUCCESS;
int64_t pos = 0;
char encrypted_buffer[OB_MAX_PASSWORD_LENGTH] = {0};
ObString encrypted_str(sizeof(encrypted_buffer), encrypted_buffer);
mode_ = static_cast<const share::ObBackupEncryptionMode::EncryptionMode>(mode); mode_ = static_cast<const share::ObBackupEncryptionMode::EncryptionMode>(mode);
encrypted_passwd_.assign_ptr(passwd_buf_, sizeof(passwd_buf_));
if (!share::ObBackupEncryptionMode::is_valid(mode_)) { if (!share::ObBackupEncryptionMode::is_valid(mode_)) {
ret = OB_INVALID_ARGUMENT; ret = OB_INVALID_ARGUMENT;
COMMON_LOG(WARN, "invalid args", K(ret), K(mode), K(mode_)); COMMON_LOG(WARN, "invalid args", K(ret), K(mode), K(mode_));
} else if (OB_FAIL(ObEncryptedHelper::encrypt_passwd_to_stage2(passwd, encrypted_passwd_))) { } else if (OB_FAIL(ObEncryptedHelper::encrypt_passwd_to_stage2(passwd, encrypted_str))) {
COMMON_LOG(WARN, "failed to encrypted passwd", K(ret), K(passwd)); COMMON_LOG(WARN, "failed to encrypted passwd", K(ret), K(passwd));
} else if (OB_FAIL(databuff_printf(passwd_buf_,
sizeof(passwd_buf_),
pos,
"%.*s",
encrypted_str.length(),
encrypted_str.ptr()))) {
COMMON_LOG(WARN, "failed to format passwd_buf", K(ret), K(encrypted_str));
} else {
encrypted_passwd_.assign_ptr(passwd_buf_, pos);
} }
return ret; return ret;