hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix index skip scan selectively calculate bugs

Browse Source
This commit is contained in:
obdev
2023-01-05 12:41:57 +00:00
committed by ob-robot
parent 6bc6228b9c
commit d5c563072a
2 changed files with 29 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/sql/optimizer/ob_access_path_estimation.cpp
View File

@ -584,7 +584,8 @@ int ObAccessPathEstimation::calc_skip_scan_prefix_ndv(AccessPath &ap, double &pr
ObJoinOrder *join_order = NULL; ObJoinOrder *join_order = NULL;
ObLogPlan *log_plan = NULL; ObLogPlan *log_plan = NULL;
const ObTableMetaInfo *table_meta_info = NULL; const ObTableMetaInfo *table_meta_info = NULL;
if (OB_ISNULL(ap.pre_query_range_) || !ap.pre_query_range_->is_ss_range()) { if (OB_ISNULL(ap.pre_query_range_) || !ap.pre_query_range_->is_ss_range()
|| OptSkipScanState::SS_DISABLE == ap.use_skip_scan_) {
/* do nothing */ /* do nothing */
} else if (OB_ISNULL(join_order = ap.parent_) || OB_ISNULL(log_plan = join_order->get_plan()) } else if (OB_ISNULL(join_order = ap.parent_) || OB_ISNULL(log_plan = join_order->get_plan())
|| OB_ISNULL(table_meta_info = ap.est_cost_info_.table_meta_info_)) { || OB_ISNULL(table_meta_info = ap.est_cost_info_.table_meta_info_)) {
@ -597,6 +598,8 @@ int ObAccessPathEstimation::calc_skip_scan_prefix_ndv(AccessPath &ap, double &pr
const double prefix_range_row_count = table_meta_info->table_row_count_ const double prefix_range_row_count = table_meta_info->table_row_count_
* ap.est_cost_info_.prefix_filter_sel_ * ap.est_cost_info_.prefix_filter_sel_
* ap.est_cost_info_.pushdown_prefix_filter_sel_; * ap.est_cost_info_.pushdown_prefix_filter_sel_;
const EqualSets *temp_equal_sets = log_plan->get_selectivity_ctx().get_equal_sets();
const double temp_rows = log_plan->get_selectivity_ctx().get_current_rows();
log_plan->get_selectivity_ctx().init_op_ctx(&join_order->get_output_equal_sets(), prefix_range_row_count); log_plan->get_selectivity_ctx().init_op_ctx(&join_order->get_output_equal_sets(), prefix_range_row_count);
if (OB_FAIL(get_skip_scan_prefix_exprs(ap.est_cost_info_.range_columns_, if (OB_FAIL(get_skip_scan_prefix_exprs(ap.est_cost_info_.range_columns_,
ap.pre_query_range_->get_skip_scan_offset(), ap.pre_query_range_->get_skip_scan_offset(),
@ -619,6 +622,7 @@ int ObAccessPathEstimation::calc_skip_scan_prefix_ndv(AccessPath &ap, double &pr
} else { } else {
double refine_ndv = 1.0; double refine_ndv = 1.0;
prefix_ndv = std::max(refine_ndv, prefix_ndv); prefix_ndv = std::max(refine_ndv, prefix_ndv);
log_plan->get_selectivity_ctx().init_op_ctx(temp_equal_sets, temp_rows);
} }
} }
} }
@ -686,21 +690,27 @@ int ObAccessPathEstimation::update_use_skip_scan(ObCostTableScanInfo &est_cost_i
} else { } else {
reset_skip_scan = true; reset_skip_scan = true;
} }
if (OB_FAIL(ret) || !reset_skip_scan) { if (OB_SUCC(ret) && reset_skip_scan) {
} else if (OB_FAIL(append(est_cost_info.postfix_filters_, est_cost_info.ss_postfix_range_filters_))) { const bool is_full_scan = est_cost_info.ref_table_id_ == est_cost_info.index_id_;
LOG_WARN("failed to append exprs", K(ret)); ObIArray<ObRawExpr*> &filters = is_full_scan ? est_cost_info.table_filters_
} else if (OB_FAIL(ObOptSelectivity::calculate_selectivity(*est_cost_info.table_metas_, : est_cost_info.postfix_filters_;
*est_cost_info.sel_ctx_, double &filter_sel = is_full_scan ? est_cost_info.table_filter_sel_
est_cost_info.postfix_filters_, : est_cost_info.postfix_filter_sel_;
est_cost_info.postfix_filter_sel_, if (OB_FAIL(append(filters, est_cost_info.ss_postfix_range_filters_))) {
all_predicate_sel))) { LOG_WARN("failed to append exprs", K(ret));
LOG_WARN("failed to calculate selectivity", K(est_cost_info.postfix_filters_), K(ret)); } else if (OB_FAIL(ObOptSelectivity::calculate_selectivity(*est_cost_info.table_metas_,
} else { *est_cost_info.sel_ctx_,
est_cost_info.ss_ranges_.reuse(); filters,
est_cost_info.ss_postfix_range_filters_.reuse(); filter_sel,
est_cost_info.ss_prefix_ndv_ = 1.0; all_predicate_sel))) {
est_cost_info.ss_postfix_range_filters_sel_ = 1.0; LOG_WARN("failed to calculate selectivity", K(est_cost_info.postfix_filters_), K(ret));
use_skip_scan = OptSkipScanState::SS_DISABLE; } else {
est_cost_info.ss_ranges_.reuse();
est_cost_info.ss_postfix_range_filters_.reuse();
est_cost_info.ss_prefix_ndv_ = 1.0;
est_cost_info.ss_postfix_range_filters_sel_ = 1.0;
use_skip_scan = OptSkipScanState::SS_DISABLE;
}
} }
} }
return ret; return ret;

4
src/sql/optimizer/ob_join_order.cpp
View File

@ -9663,7 +9663,9 @@ int ObJoinOrder::fill_filters(const ObIArray<ObRawExpr*> &all_filters,
ret = est_cost_info.table_filters_.push_back(filter); ret = est_cost_info.table_filters_.push_back(filter);
} }
} else { } else {
ret = est_cost_info.table_filters_.push_back(filter); if (!use_skip_scan || !ObOptimizerUtil::find_item(est_cost_info.ss_postfix_range_filters_, filter)) {
ret = est_cost_info.table_filters_.push_back(filter);
}
} }
} }