hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove redundant checks on ret (#613)

Browse Source
This commit is contained in:
nauta 2021-11-29 18:05:12 +08:00 committed by GitHub
parent 22e98cc42c
commit da6f7be724
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/sql/resolver/ddl/ob_ddl_resolver.cpp
View File

@ -3136,15 +3136,13 @@ int ObDDLResolver::resolve_part_func(ObResolverParams& params, const ParseNode*
}
if (OB_SUCC(ret)) {
// check duplicate of PARTITION_FUNC_TYPE_RANGE_COLUMNS
if (OB_SUCC(ret)) {
if (partition_func_type == PARTITION_FUNC_TYPE_RANGE_COLUMNS) {
for (int64_t idx = 0; OB_SUCC(ret) && idx < partition_keys.count(); ++idx) {
const ObString& key_name = partition_keys.at(idx);
for (int64_t b_idx = 0; OB_SUCC(ret) && b_idx < idx; ++b_idx) {
if (ObCharset::case_insensitive_equal(key_name, partition_keys.at(b_idx))) {
ret = OB_ERR_SAME_NAME_PARTITION_FIELD;
LOG_USER_ERROR(OB_ERR_SAME_NAME_PARTITION_FIELD, key_name.length(), key_name.ptr());
}
if (partition_func_type == PARTITION_FUNC_TYPE_RANGE_COLUMNS) {
for (int64_t idx = 0; OB_SUCC(ret) && idx < partition_keys.count(); ++idx) {
const ObString& key_name = partition_keys.at(idx);
for (int64_t b_idx = 0; OB_SUCC(ret) && b_idx < idx; ++b_idx) {
if (ObCharset::case_insensitive_equal(key_name, partition_keys.at(b_idx))) {
ret = OB_ERR_SAME_NAME_PARTITION_FIELD;
LOG_USER_ERROR(OB_ERR_SAME_NAME_PARTITION_FIELD, key_name.length(), key_name.ptr());
}
}
}