hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix type deduction error

Browse Source
This commit is contained in:
Zach41
2023-11-23 08:11:03 +00:00
committed by ob-robot
parent 8d166a7d96
commit dd4fe92807
3 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/engine/expr/ob_expr_add.cpp
View File

@ -105,6 +105,7 @@ int ObExprAdd::calc_result_type2(ObExprResType &type,
} else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) { } else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) {
type1.set_calc_type(ObNumberType); type1.set_calc_type(ObNumberType);
type2.set_calc_type(ObNumberType); type2.set_calc_type(ObNumberType);
type.set_number();
} else { } else {
if (ObRawExprUtils::decimal_int_need_cast(type1.get_accuracy(), type.get_accuracy()) || if (ObRawExprUtils::decimal_int_need_cast(type1.get_accuracy(), type.get_accuracy()) ||
ObRawExprUtils::decimal_int_need_cast(type2.get_accuracy(), type.get_accuracy())) { ObRawExprUtils::decimal_int_need_cast(type2.get_accuracy(), type.get_accuracy())) {

1
src/sql/engine/expr/ob_expr_minus.cpp
View File

@ -121,6 +121,7 @@ int ObExprMinus::calc_result_type2(ObExprResType &type,
} else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) { } else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) {
type1.set_calc_type(ObNumberType); type1.set_calc_type(ObNumberType);
type2.set_calc_type(ObNumberType); type2.set_calc_type(ObNumberType);
type.set_number();
} else { } else {
if (ObRawExprUtils::decimal_int_need_cast(type1.get_accuracy(), type.get_accuracy()) || if (ObRawExprUtils::decimal_int_need_cast(type1.get_accuracy(), type.get_accuracy()) ||
ObRawExprUtils::decimal_int_need_cast(type2.get_accuracy(), type.get_accuracy())) { ObRawExprUtils::decimal_int_need_cast(type2.get_accuracy(), type.get_accuracy())) {

3
src/sql/engine/expr/ob_expr_mul.cpp
View File

@ -105,6 +105,9 @@ int ObExprMul::calc_result_type2(ObExprResType &type,
} else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) { } else if (is_oracle && type.get_precision() > OB_MAX_NUMBER_PRECISION) {
type1.set_calc_type(ObNumberType); type1.set_calc_type(ObNumberType);
type2.set_calc_type(ObNumberType); type2.set_calc_type(ObNumberType);
type.set_number();
type.set_scale(ORA_NUMBER_SCALE_UNKNOWN_YET);
type.set_precision(PRECISION_UNKNOWN_YET);
} else if ((type1.get_scale() + type2.get_scale() <= OB_MAX_DECIMAL_SCALE) } else if ((type1.get_scale() + type2.get_scale() <= OB_MAX_DECIMAL_SCALE)
&& (type1.get_precision() + type2.get_precision() <= MAX_PRECISION_DECIMAL_INT_256)) { && (type1.get_precision() + type2.get_precision() <= MAX_PRECISION_DECIMAL_INT_256)) {
// use specialized functions without additional casts // use specialized functions without additional casts