hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix ddl remote write when the tenant is standby

Browse Source
This commit is contained in:
simonjoylet
2023-02-09 16:38:59 +00:00
committed by ob-robot
parent 8efeef908d
commit ddca0b032d
4 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/observer/ob_rpc_processor_simple.cpp
View File

@ -1991,7 +1991,7 @@ int ObRpcRemoteWriteDDLRedoLogP::process()
LOG_WARN("fail to wait macro block io finish", K(ret)); LOG_WARN("fail to wait macro block io finish", K(ret));
} else if (OB_FAIL(sstable_redo_writer.init(arg_.ls_id_, arg_.redo_info_.table_key_.tablet_id_))) { } else if (OB_FAIL(sstable_redo_writer.init(arg_.ls_id_, arg_.redo_info_.table_key_.tablet_id_))) {
LOG_WARN("init sstable redo writer", K(ret), K_(arg)); LOG_WARN("init sstable redo writer", K(ret), K_(arg));
} else if (OB_FAIL(sstable_redo_writer.write_redo_log(arg_.redo_info_, macro_handle.get_macro_id()))) { } else if (OB_FAIL(sstable_redo_writer.write_redo_log(arg_.redo_info_, macro_handle.get_macro_id(), false/*allow remote write*/))) {
LOG_WARN("fail to write macro redo", K(ret), K_(arg)); LOG_WARN("fail to write macro redo", K(ret), K_(arg));
} else if (OB_FAIL(sstable_redo_writer.wait_redo_log_finish(arg_.redo_info_, } else if (OB_FAIL(sstable_redo_writer.wait_redo_log_finish(arg_.redo_info_,
macro_handle.get_macro_id()))) { macro_handle.get_macro_id()))) {

9
src/share/ob_ddl_common.cpp
View File

@ -831,10 +831,11 @@ int ObDDLUtil::ddl_get_tablet(
bool ObDDLUtil::need_remote_write(const int ret_code) bool ObDDLUtil::need_remote_write(const int ret_code)
{ {
return OB_NOT_MASTER == ret_code return ObTenantRole::PRIMARY_TENANT == MTL_GET_TENANT_ROLE()
|| OB_NOT_RUNNING == ret_code && (OB_NOT_MASTER == ret_code
|| OB_LS_LOCATION_LEADER_NOT_EXIST == ret_code || OB_NOT_RUNNING == ret_code
|| OB_EAGAIN == ret_code; || OB_LS_LOCATION_LEADER_NOT_EXIST == ret_code
|| OB_EAGAIN == ret_code);
} }
int ObDDLUtil::get_tablet_paxos_member_list( int ObDDLUtil::get_tablet_paxos_member_list(

12
src/storage/ddl/ob_ddl_redo_log_writer.cpp
View File

@ -930,7 +930,7 @@ int ObDDLMacroBlockRedoWriter::remote_write_macro_redo(const ObAddr &leader_addr
obrpc::ObRpcRemoteWriteDDLRedoLogArg arg; obrpc::ObRpcRemoteWriteDDLRedoLogArg arg;
if (OB_FAIL(arg.init(MTL_ID(), leader_ls_id, redo_info))) { if (OB_FAIL(arg.init(MTL_ID(), leader_ls_id, redo_info))) {
LOG_WARN("fail to init ObRpcRemoteWriteDDLRedoLogArg", K(ret)); LOG_WARN("fail to init ObRpcRemoteWriteDDLRedoLogArg", K(ret));
} else if (OB_FAIL(srv_rpc_proxy->to(leader_addr).remote_write_ddl_redo_log(arg))) { } else if (OB_FAIL(srv_rpc_proxy->to(leader_addr).by(MTL_ID()).remote_write_ddl_redo_log(arg))) {
LOG_WARN("fail to remote write ddl redo log", K(ret), K(leader_addr), K(arg)); LOG_WARN("fail to remote write ddl redo log", K(ret), K(leader_addr), K(arg));
} }
} }
@ -998,7 +998,7 @@ int ObDDLSSTableRedoWriter::start_ddl_redo(const ObITable::TableKey &table_key,
return ret; return ret;
} }
int ObDDLSSTableRedoWriter::write_redo_log(const ObDDLMacroBlockRedoInfo &redo_info, const blocksstable::MacroBlockId &macro_block_id) int ObDDLSSTableRedoWriter::write_redo_log(const ObDDLMacroBlockRedoInfo &redo_info, const blocksstable::MacroBlockId &macro_block_id, const bool allow_remote_write)
{ {
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
ObLSHandle ls_handle; ObLSHandle ls_handle;
@ -1020,12 +1020,12 @@ int ObDDLSSTableRedoWriter::write_redo_log(const ObDDLMacroBlockRedoInfo &redo_i
LOG_WARN("allocate memory failed", K(ret), K(BUF_SIZE)); LOG_WARN("allocate memory failed", K(ret), K(BUF_SIZE));
} else if (!remote_write_) { } else if (!remote_write_) {
if (OB_FAIL(ObDDLMacroBlockRedoWriter::write_macro_redo(redo_info, ls->get_ls_id(), ls->get_log_handler(), macro_block_id, buffer_, ddl_redo_handle_))) { if (OB_FAIL(ObDDLMacroBlockRedoWriter::write_macro_redo(redo_info, ls->get_ls_id(), ls->get_log_handler(), macro_block_id, buffer_, ddl_redo_handle_))) {
if (ObDDLUtil::need_remote_write(ret)) { if (ObDDLUtil::need_remote_write(ret) && allow_remote_write) {
if (OB_FAIL(switch_to_remote_write())) { if (OB_FAIL(switch_to_remote_write())) {
LOG_WARN("fail to switch to remote write", K(ret)); LOG_WARN("fail to switch to remote write", K(ret));
} }
} else { } else {
LOG_WARN("fail to write ddl redo clog", K(ret)); LOG_WARN("fail to write ddl redo clog", K(ret), K(MTL_GET_TENANT_ROLE()));
} }
} }
} }
@ -1118,7 +1118,7 @@ int ObDDLSSTableRedoWriter::write_commit_log(const ObITable::TableKey &table_key
} else if (OB_ISNULL(srv_rpc_proxy)) { } else if (OB_ISNULL(srv_rpc_proxy)) {
ret = OB_ERR_SYS; ret = OB_ERR_SYS;
LOG_WARN("srv rpc proxy or location service is null", K(ret), KP(srv_rpc_proxy)); LOG_WARN("srv rpc proxy or location service is null", K(ret), KP(srv_rpc_proxy));
} else if (OB_FAIL(srv_rpc_proxy->to(leader_addr_).remote_write_ddl_commit_log(arg, log_ns))) { } else if (OB_FAIL(srv_rpc_proxy->to(leader_addr_).by(MTL_ID()).remote_write_ddl_commit_log(arg, log_ns))) {
LOG_WARN("fail to remote write ddl redo log", K(ret), K(arg)); LOG_WARN("fail to remote write ddl redo log", K(ret), K(arg));
} else if (OB_FAIL(commit_scn.convert_for_tx(log_ns))) { } else if (OB_FAIL(commit_scn.convert_for_tx(log_ns))) {
LOG_WARN("convert for tx failed", K(ret)); LOG_WARN("convert for tx failed", K(ret));
@ -1217,7 +1217,7 @@ int ObDDLRedoLogWriterCallback::write(const ObMacroBlockHandle &macro_handle,
redo_info_.block_type_ = block_type_; redo_info_.block_type_ = block_type_;
redo_info_.logic_id_ = logic_id; redo_info_.logic_id_ = logic_id;
redo_info_.start_scn_ = ddl_writer_->get_start_scn(); redo_info_.start_scn_ = ddl_writer_->get_start_scn();
if (OB_FAIL(ddl_writer_->write_redo_log(redo_info_, macro_block_id_))) { if (OB_FAIL(ddl_writer_->write_redo_log(redo_info_, macro_block_id_, true/*allow remote write*/))) {
LOG_WARN("fail to write ddl redo log", K(ret)); LOG_WARN("fail to write ddl redo log", K(ret));
} }
} }

3
src/storage/ddl/ob_ddl_redo_log_writer.h
View File

@ -251,7 +251,8 @@ public:
const int64_t ddl_cluster_version, const int64_t ddl_cluster_version,
ObDDLKvMgrHandle &ddl_kv_mgr_handle); ObDDLKvMgrHandle &ddl_kv_mgr_handle);
int write_redo_log(const blocksstable::ObDDLMacroBlockRedoInfo &redo_info, int write_redo_log(const blocksstable::ObDDLMacroBlockRedoInfo &redo_info,
const blocksstable::MacroBlockId &macro_block_id); const blocksstable::MacroBlockId &macro_block_id,
const bool allow_remote_write);
int wait_redo_log_finish(const blocksstable::ObDDLMacroBlockRedoInfo &redo_info, int wait_redo_log_finish(const blocksstable::ObDDLMacroBlockRedoInfo &redo_info,
const blocksstable::MacroBlockId &macro_block_id); const blocksstable::MacroBlockId &macro_block_id);
int write_commit_log(const ObITable::TableKey &table_key, int write_commit_log(const ObITable::TableKey &table_key,