hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[4.x] not set tx isolation level when setting tx read write

Browse Source
This commit is contained in:
jw-guo
2023-05-16 05:42:08 +00:00
committed by ob-robot
parent 1c1eef34a3
commit de0a65febd
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/share/system_variable/ob_system_variable.cpp
View File

@ -2440,7 +2440,7 @@ int ObSysVarOnUpdateFuncs::update_tx_read_only_no_scope(ObExecContext &ctx,
int ret = OB_SUCCESS; int ret = OB_SUCCESS;
if (set_var.set_scope_ == ObSetVar::SET_SCOPE_NEXT_TRANS) { if (set_var.set_scope_ == ObSetVar::SET_SCOPE_NEXT_TRANS) {
ObSQLSessionInfo *session = GET_MY_SESSION(ctx); ObSQLSessionInfo *session = GET_MY_SESSION(ctx);
bool read_only = val.get_bool(); const bool read_only = val.get_bool();
if (OB_ISNULL(session)) { if (OB_ISNULL(session)) {
ret = OB_ERR_UNEXPECTED; ret = OB_ERR_UNEXPECTED;
LOG_WARN("fail to get session info", K(ret)); LOG_WARN("fail to get session info", K(ret));
@ -2450,9 +2450,11 @@ int ObSysVarOnUpdateFuncs::update_tx_read_only_no_scope(ObExecContext &ctx,
// READ ONLY will use SERIALIZABLE implicitly, // READ ONLY will use SERIALIZABLE implicitly,
// READ WRITE need use default value in session, so set UNKNOWN. // READ WRITE need use default value in session, so set UNKNOWN.
// //
ObTxIsolationLevel isolation = read_only ? // if read only, set tx isolation level to serializable
ObTxIsolationLevel::SERIAL : ObTxIsolationLevel::INVALID; // otherwise, use the value in session
session->set_tx_isolation(isolation); if (read_only) {
session->set_tx_isolation(ObTxIsolationLevel::SERIAL);
}
if (OB_FAIL(start_trans_by_set_trans_char_(ctx))) { if (OB_FAIL(start_trans_by_set_trans_char_(ctx))) {
// TODO: fatal bug, need disconnect // TODO: fatal bug, need disconnect
LOG_WARN("auto start trans fail when set txn charactor", K(ret), LOG_WARN("auto start trans fail when set txn charactor", K(ret),