hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [bugfix]: In mysql, const aggr(e.g., count(const_expr)) should belong to the nearest legal level.

Browse Source
This commit is contained in:
Monk-Liu 2022-07-05 16:16:52 +08:00 committed by wangzelin.wzl
parent 031989c299
commit e01bfda9af
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/sql/resolver/dml/ob_aggr_expr_push_up_analyzer.cpp
View File

@ -235,8 +235,10 @@ int32_t ObAggrExprPushUpAnalyzer::get_final_aggr_level() const
}
}
if (final_aggr_level < 0) {
// count(const_expr)
final_aggr_level = cur_aggr_level;
}
// in mysql mode if the final_aggr_level < 0, the aggr's params are const. e.g., count(const_expr);
return final_aggr_level;
}
@ -250,7 +252,8 @@ ObSelectResolver* ObAggrExprPushUpAnalyzer::fetch_final_aggr_resolver(
* For oracle mode, if it is in having scope, it will pull subquery up to compute
* if it is in order scope (and subquery does not appear in where scope), it will pull subquery up to compute
*/
if (cur_resolver->get_current_level() > final_aggr_level && NULL != cur_resolver->get_parent_namespace_resolver() &&
if (final_aggr_level >= 0 && cur_resolver->get_current_level() > final_aggr_level &&
NULL != cur_resolver->get_parent_namespace_resolver() &&
(share::is_mysql_mode() ||
T_HAVING_SCOPE == cur_resolver->get_parent_namespace_resolver()->get_current_scope() ||
(T_ORDER_SCOPE == cur_resolver->get_parent_namespace_resolver()->get_current_scope() &&
@ -271,6 +274,20 @@ ObSelectResolver* ObAggrExprPushUpAnalyzer::fetch_final_aggr_resolver(
ObSelectResolver* select_resolver = static_cast<ObSelectResolver*>(cur_resolver);
if (select_resolver->can_produce_aggr()) {
final_resolver = select_resolver;
} else if (share::is_mysql_mode() && final_aggr_level < 0) {
/*
* in mysql, a const aggr_expr(e.g., count(const_expr)), belongs to the nearest legal level.
*
* select 1 from t1 where (select 1 from t1 group by pk having (select 1 from t1 where count(1)));
* --> count(1)'s level is 1; it belongs to select 1 from t1 group by pk having xxx;
*
* select 1 from t1 group by pk having (select 1 from dual where (select 1 from t1 where count(1)));
* --> count(1)'s level is 0;
*/
ObDMLResolver *next_resolver = cur_resolver->get_parent_namespace_resolver();
if (NULL != next_resolver) {
final_resolver = fetch_final_aggr_resolver(next_resolver, final_aggr_level);
}
}
}
}