hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix simplify case when bug

Browse Source
This commit is contained in:
obdev
2024-02-08 01:05:39 +00:00
committed by ob-robot
parent 833df1e858
commit e1764b71bb
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/rewrite/ob_transform_simplify_expr.cpp
View File

@ -3618,6 +3618,7 @@ int ObTransformSimplifyExpr::check_convert_then_exprs_validity(ObRawExpr *parent
} else if (OB_FAIL(enum_exprs.push_back(case_expr->get_default_param_expr()))) { } else if (OB_FAIL(enum_exprs.push_back(case_expr->get_default_param_expr()))) {
LOG_WARN("failed to push back enum exprs", K(ret)); LOG_WARN("failed to push back enum exprs", K(ret));
} else { } else {
bool all_true_only = false;
// collect basic info for each `[cmp](enum_expr, sibling_expr)` // collect basic info for each `[cmp](enum_expr, sibling_expr)`
for (int64_t i = 0; OB_SUCC(ret) && is_valid && i < enum_exprs.count(); ++i) { for (int64_t i = 0; OB_SUCC(ret) && is_valid && i < enum_exprs.count(); ++i) {
ObRawExpr *enum_expr = NULL; ObRawExpr *enum_expr = NULL;
@ -3645,6 +3646,7 @@ int ObTransformSimplifyExpr::check_convert_then_exprs_validity(ObRawExpr *parent
is_valid = false; is_valid = false;
} else if (OB_FALSE_IT(is_all_false &= (result.is_false() || result.is_null()))) { } else if (OB_FALSE_IT(is_all_false &= (result.is_false() || result.is_null()))) {
} else if (OB_FALSE_IT(is_all_true &= result.is_true())) { } else if (OB_FALSE_IT(is_all_true &= result.is_true())) {
} else if (OB_FALSE_IT(is_valid &= (all_true_only ? is_all_true : true))) {
} else if (result.is_false() || result.is_null()) { } else if (result.is_false() || result.is_null()) {
if (OB_FAIL(false_null_exprs.push_back(cur_then_filter))) { if (OB_FAIL(false_null_exprs.push_back(cur_then_filter))) {
LOG_WARN("failed to push back to false exprs", K(ret)); LOG_WARN("failed to push back to false exprs", K(ret));
@ -3656,8 +3658,9 @@ int ObTransformSimplifyExpr::check_convert_then_exprs_validity(ObRawExpr *parent
candi_then_filter = NULL; candi_then_filter = NULL;
candi_when_filter = i < case_expr->get_when_expr_size() ? candi_when_filter = i < case_expr->get_when_expr_size() ?
case_expr->get_when_param_expr(i) : NULL; case_expr->get_when_param_expr(i) : NULL;
} else if (!is_all_true) { } else { // multi true branches
is_valid = false; all_true_only = true;
is_valid &= is_all_true;
} }
} else if (reserved_branch_cnt == -1) { // first true/[uncalc] branch } else if (reserved_branch_cnt == -1) { // first true/[uncalc] branch
is_all_false = false; is_all_false = false;