hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix sort spec compression codec overwrite

Browse Source
This commit is contained in:
hezuojiao
2024-06-25 13:32:14 +00:00
committed by ob-robot
parent 302959395e
commit e5bc48d855
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/code_generator/ob_static_engine_cg.cpp
View File

@ -303,6 +303,7 @@ int ObStaticEngineCG::postorder_generate_op(ObLogicalOperator &op,
ret = OB_ERR_UNEXPECTED;
LOG_WARN("NULL operator spec returned", K(ret));
} else {
spec->compress_type_ = compress_type;
for (int64_t i = 0; i < children.count() && OB_SUCC(ret); i++) {
if (OB_FAIL(spec->set_child(i, children.at(i)))) {
LOG_WARN("set child failed", K(ret));
@ -332,8 +333,7 @@ int ObStaticEngineCG::postorder_generate_op(ObLogicalOperator &op,
} else if (OB_FAIL(ObOperatorFactory::generate_spec(*this, op, *spec, in_root_job))) {
LOG_WARN("generate operator spec failed",
K(ret), KP(phy_plan_), K(ob_phy_operator_type_str(type)));
} else if (OB_FAIL(generate_spec_basic(op, *spec, check_eval_once, need_check_output_datum,
compress_type))) {
} else if (OB_FAIL(generate_spec_basic(op, *spec, check_eval_once, need_check_output_datum))) {
LOG_WARN("generate operator spec basic failed", K(ret));
} else if (OB_FAIL(generate_spec_final(op, *spec))) {
LOG_WARN("generate operator spec final failed", K(ret));
@ -787,8 +787,7 @@ int ObStaticEngineCG::generate_rt_exprs(const ObIArray<ObRawExpr *> &src,
int ObStaticEngineCG::generate_spec_basic(ObLogicalOperator &op,
ObOpSpec &spec,
const bool check_eval_once,
const bool need_check_output_datum,
const common::ObCompressorType compress_type)
const bool need_check_output_datum)
{
int ret = OB_SUCCESS;
if (0 == spec.rows_) {
@ -798,7 +797,6 @@ int ObStaticEngineCG::generate_spec_basic(ObLogicalOperator &op,
spec.width_ = op.get_width();
spec.plan_depth_ = op.get_plan_depth();
spec.px_est_size_factor_ = op.get_px_est_size_factor();
spec.compress_type_ = compress_type;
OZ(generate_rt_exprs(op.get_startup_exprs(), spec.startup_filters_));

3
src/sql/code_generator/ob_static_engine_cg.h
View File

@ -247,8 +247,7 @@ private:
int generate_spec_basic(ObLogicalOperator &op,
ObOpSpec &spec,
const bool check_eval_once,
const bool need_check_output_datum,
const common::ObCompressorType compress_type);
const bool need_check_output_datum);
// Invoked after generate_spec() and generate_spec_basic(),
// some operator need this phase to do some special generation.