hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix incorrect log warn from ob_ls_location_service

Browse Source
This commit is contained in:
obdev
2022-11-02 17:05:53 +00:00
committed by wangzelin.wzl
parent 8723bbd3b2
commit e847423ce3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/share/location_cache/ob_ls_location_service.cpp
View File

@ -789,7 +789,7 @@ int ObLSLocationService::renew_location(
// get from cache just for printing cache changes log // get from cache just for printing cache changes log
if (OB_FAIL(ret)) { if (OB_FAIL(ret)) {
} else if (OB_SUCCESS != (tmp_ret = get_from_cache(cluster_id, tenant_id, ls_id, old_location))) { } else if (OB_SUCCESS != (tmp_ret = get_from_cache(cluster_id, tenant_id, ls_id, old_location))) {
if (OB_ENTRY_NOT_EXIST == tmp_ret) { if (OB_CACHE_NOT_HIT == tmp_ret) {
tmp_ret = OB_SUCCESS; tmp_ret = OB_SUCCESS;
} else { } else {
LOG_WARN("fail to get from cache", KR(tmp_ret), K(cluster_id), K(tenant_id), K(ls_id)); LOG_WARN("fail to get from cache", KR(tmp_ret), K(cluster_id), K(tenant_id), K(ls_id));
@ -813,7 +813,7 @@ int ObLSLocationService::renew_location(
LOG_WARN("get empty location from meta table", KR(ret), K(location)); LOG_WARN("get empty location from meta table", KR(ret), K(location));
} }
// print cache changes // print cache changes
if (OB_SUCC(ret) && OB_SUCC(tmp_ret) && !location.is_same_with(old_location)) { if (OB_SUCC(ret) && (OB_SUCCESS == tmp_ret) && !location.is_same_with(old_location)) {
FLOG_INFO("[LOCATION_CACHE]ls location cache has changed", KR(ret), K(old_location), "new_location", location); FLOG_INFO("[LOCATION_CACHE]ls location cache has changed", KR(ret), K(old_location), "new_location", location);
} }
return ret; return ret;