hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix missing ret

Browse Source
This commit is contained in:
JiahuaChen
2024-04-07 08:01:26 +00:00
committed by ob-robot
parent 0c6006d7fd
commit e85d9ab53b
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/storage/blocksstable/encoding/ob_dict_decoder.cpp
View File

@ -1351,7 +1351,8 @@ int ObDictDecoder::in_operator(
++traverse_it;
++dict_ref;
}
if (found && OB_FAIL(set_res_with_bitset(parent, col_ctx, col_data,
if (OB_FAIL(ret)) {
} else if (found && OB_FAIL(set_res_with_bitset(parent, col_ctx, col_data,
ref_bitset, pd_filter_info, result_bitmap))) {
LOG_WARN("Failed to set result bitmap", K(ret));
}

4
src/storage/blocksstable/encoding/ob_integer_base_diff_decoder.cpp
View File

@ -517,7 +517,7 @@ int ObIntegerBaseDiffDecoder::comparison_operator(
const sql::ObWhiteFilterOperatorType op_type = filter.get_op_type();
ObGetFilterCmpRetFunc get_cmp_ret = get_filter_cmp_ret_func(op_type);
int cmp_res = 0;
if (OB_FAIL(cmp_func(ref_datum, base_datum, cmp_res))) {
if (FAILEDx(cmp_func(ref_datum, base_datum, cmp_res))) {
LOG_WARN("Failed to compare datum", K(ret), K(ref_datum), K(base_datum));
} else if (FALSE_IT(filter_obj_smaller_than_base = cmp_res < 0)){
} else if (filter_obj_smaller_than_base) {
@ -742,7 +742,7 @@ int ObIntegerBaseDiffDecoder::traverse_all_data(
cur_datum.ptr_ = reinterpret_cast<char *> (&cur_int);
// use lambda here to filter and set result bitmap
bool result = false;
if (OB_FAIL(lambda(cur_datum, filter, result))) {
if (FAILEDx(lambda(cur_datum, filter, result))) {
LOG_WARN("Failed on trying to filter the row", K(ret), K(row_id), K(cur_int));
} else if (result) {
if (OB_FAIL(result_bitmap.set(offset))) {

5
src/storage/slog_ckpt/ob_tenant_checkpoint_slog_handler.cpp
View File

@ -1450,11 +1450,10 @@ int ObTenantCheckpointSlogHandler::parse(
int32_t length = 0;
int32_t version = 0;
snprintf(slog_name, ObStorageLogReplayer::MAX_SLOG_NAME_LEN, "update tablet slog: ");
if (OB_FAIL(slog_entry.deserialize(buf, len, pos))) {
LOG_WARN("fail to deserialize tablet meta", K(ret), KP(buf), K(len), K(pos));
}
snprintf(slog_name, ObStorageLogReplayer::MAX_SLOG_NAME_LEN, "update tablet slog: ");
if (0 > fprintf(stream, "%s\n version:%d length:%d\n%s\n", slog_name, version, length, to_cstring(slog_entry))) {
} else if (0 > fprintf(stream, "%s\n version:%d length:%d\n%s\n", slog_name, version, length, to_cstring(slog_entry))) {
ret = OB_IO_ERROR;
LOG_WARN("Fail to print slog to file.", K(ret));
}