hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix sequence prefetch bug

Browse Source
This commit is contained in:
raywill
2021-08-25 11:58:37 +08:00
committed by wangzelin.wzl
parent cc0e6b8c12
commit eab34d598b
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/share/sequence/ob_sequence_cache.cpp
View File

@ -342,12 +342,11 @@ int ObSequenceCache::nextval(const ObSequenceSchema& schema, ObIAllocator& alloc
ObNumber rest; ObNumber rest;
ObNumber full; ObNumber full;
ObNumberCalc calc(item->curr_node_.end(), allocator); ObNumberCalc calc(item->curr_node_.end(), allocator);
// magic value static const int64_t PREFETCH_OP_THRESHOLD = 2;
static const int64_t PREFETCH_OP_THRESHOLD = 4;
// //
// const int64_t rest = std::abs(item->curr_node_.end_ - item->curr_node_.start_) * PREFETCH_OP_THRESHOLD; // const int64_t rest = std::abs(item->curr_node_.end_ - item->curr_node_.start_) * PREFETCH_OP_THRESHOLD;
// const int64_t full = std::abs(schema.get_increment_by() * schema.get_cache_size()); // const int64_t full = std::abs(schema.get_increment_by() * schema.get_cache_size());
// if (rest > full) { // if (rest < full) {
// enable prefetch // enable prefetch
// } // }
// //
@ -355,7 +354,7 @@ int ObSequenceCache::nextval(const ObSequenceSchema& schema, ObIAllocator& alloc
LOG_WARN("fail do number sub", K(ret)); LOG_WARN("fail do number sub", K(ret));
} else if (OB_FAIL(schema.get_increment_by().mul(schema.get_cache_size(), full, allocator))) { } else if (OB_FAIL(schema.get_increment_by().mul(schema.get_cache_size(), full, allocator))) {
LOG_WARN("fail do number multiply", K(ret)); LOG_WARN("fail do number multiply", K(ret));
} else if (rest.abs() > full.abs()) { } else if (rest.abs() <= full.abs()) {
item->prefetching_ = true; item->prefetching_ = true;
need_prefetch = true; need_prefetch = true;
} }