hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Use error log when cannot create more memtable

Browse Source
This commit is contained in:
obdev
2023-03-06 07:46:27 +00:00
committed by ob-robot
parent ca23020851
commit ee44943313
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/storage/tablet/ob_tablet_memtable_mgr.cpp
View File

@ -36,6 +36,7 @@ ObTabletMemtableMgr::ObTabletMemtableMgr()
: ObIMemtableMgr(LockType::OB_SPIN_RWLOCK, &lock_def_), : ObIMemtableMgr(LockType::OB_SPIN_RWLOCK, &lock_def_),
ls_(NULL), ls_(NULL),
lock_def_(common::ObLatchIds::TABLET_MEMTABLE_LOCK), lock_def_(common::ObLatchIds::TABLET_MEMTABLE_LOCK),
retry_times_(0),
schema_recorder_(), schema_recorder_(),
medium_info_recorder_() medium_info_recorder_()
{ {
@ -71,6 +72,7 @@ void ObTabletMemtableMgr::destroy()
freezer_ = nullptr; freezer_ = nullptr;
schema_recorder_.destroy(); schema_recorder_.destroy();
medium_info_recorder_.destroy(); medium_info_recorder_.destroy();
retry_times_ = 0;
is_inited_ = false; is_inited_ = false;
} }
@ -106,6 +108,7 @@ int ObTabletMemtableMgr::init(const common::ObTabletID &tablet_id,
t3m_ = t3m; t3m_ = t3m;
table_type_ = ObITable::TableType::DATA_MEMTABLE; table_type_ = ObITable::TableType::DATA_MEMTABLE;
freezer_ = freezer; freezer_ = freezer;
retry_times_ = 0;
is_inited_ = true; is_inited_ = true;
TRANS_LOG(DEBUG, "succeeded to init tablet memtable mgr", K(ret), K(ls_id), K(tablet_id)); TRANS_LOG(DEBUG, "succeeded to init tablet memtable mgr", K(ret), K(ls_id), K(tablet_id));
} }
@ -186,12 +189,13 @@ int ObTabletMemtableMgr::create_memtable(const SCN clog_checkpoint_scn,
ret = OB_ENTRY_EXIST; ret = OB_ENTRY_EXIST;
} else if (get_memtable_count_() >= MAX_MEMSTORE_CNT) { } else if (get_memtable_count_() >= MAX_MEMSTORE_CNT) {
ret = OB_MINOR_FREEZE_NOT_ALLOW; ret = OB_MINOR_FREEZE_NOT_ALLOW;
if (TC_REACH_TIME_INTERVAL(1000 * 1000)) { ob_usleep(1 * 1000);
if ((++retry_times_ % (60 * 1000)) == 0) { // 1 min
ObTableHandleV2 first_frozen_memtable; ObTableHandleV2 first_frozen_memtable;
get_first_frozen_memtable_(first_frozen_memtable); get_first_frozen_memtable_(first_frozen_memtable);
LOG_WARN("cannot create more memtable", K(ret), K(ls_id), K(tablet_id_), K(MAX_MEMSTORE_CNT), LOG_ERROR("cannot create more memtable", K(ret), K(ls_id), K(tablet_id_), K(MAX_MEMSTORE_CNT),
K(get_memtable_count_()), K(get_memtable_count_()),
KPC(first_frozen_memtable.get_table())); KPC(first_frozen_memtable.get_table()));
} }
} else if (OB_FAIL(get_newest_clog_checkpoint_scn(new_clog_checkpoint_scn))) { } else if (OB_FAIL(get_newest_clog_checkpoint_scn(new_clog_checkpoint_scn))) {
LOG_WARN("failed to get newest clog_checkpoint_scn", K(ret), K(ls_id), K(tablet_id_), K(new_clog_checkpoint_scn)); LOG_WARN("failed to get newest clog_checkpoint_scn", K(ret), K(ls_id), K(tablet_id_), K(new_clog_checkpoint_scn));
@ -206,6 +210,7 @@ int ObTabletMemtableMgr::create_memtable(const SCN clog_checkpoint_scn,
table_key.scn_range_.end_scn_.set_max(); table_key.scn_range_.end_scn_.set_max();
memtable::ObMemtable *memtable = NULL; memtable::ObMemtable *memtable = NULL;
ObLSHandle ls_handle; ObLSHandle ls_handle;
retry_times_ = 0;
if (OB_FAIL(t3m_->acquire_memtable(memtable_handle))) { if (OB_FAIL(t3m_->acquire_memtable(memtable_handle))) {
LOG_WARN("failed to create memtable", K(ret), K(ls_id), K(tablet_id_)); LOG_WARN("failed to create memtable", K(ret), K(ls_id), K(tablet_id_));

1
src/storage/tablet/ob_tablet_memtable_mgr.h
View File

@ -145,6 +145,7 @@ private:
private: private:
ObLS *ls_; // 8B ObLS *ls_; // 8B
common::SpinRWLock lock_def_; //8B common::SpinRWLock lock_def_; //8B
int64_t retry_times_; // 8B
ObStorageSchemaRecorder schema_recorder_; // 120B ObStorageSchemaRecorder schema_recorder_; // 120B
compaction::ObTabletMediumCompactionInfoRecorder medium_info_recorder_; // 96B compaction::ObTabletMediumCompactionInfoRecorder medium_info_recorder_; // 96B
}; };