hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[bug fix]add pre_check

Browse Source
This commit is contained in:
renju96
2023-07-25 09:48:27 +00:00
committed by ob-robot
parent 421d03141e
commit f7c543a8bc
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
deps/oblib/src/lib/ob_define.h vendored
View File

@ -183,6 +183,12 @@ OB_INLINE bool is_sys_group(const int64_t group_id)
return group_id >= SYS_RESOURCE_GROUP_START_ID && group_id <= SYS_RESOURCE_GROUP_START_ID + SYS_RESOURCE_GROUP_CNT; return group_id >= SYS_RESOURCE_GROUP_START_ID && group_id <= SYS_RESOURCE_GROUP_START_ID + SYS_RESOURCE_GROUP_CNT;
} }
OB_INLINE bool is_valid_resource_group(const int64_t group_id)
{
//other group or user group
return group_id == 0 || (group_id >= USER_RESOURCE_GROUP_START_ID && group_id <= USER_RESOURCE_GROUP_END_ID);
}
// See ObDeviceHealthStatus for more information // See ObDeviceHealthStatus for more information
const int64_t OB_MAX_DEVICE_HEALTH_STATUS_STR_LENGTH = 20; const int64_t OB_MAX_DEVICE_HEALTH_STATUS_STR_LENGTH = 20;

2
src/share/io/ob_io_manager.cpp
View File

@ -1012,7 +1012,7 @@ int ObTenantIOManager::modify_io_config(const uint64_t group_id,
} else { } else {
uint64_t index = INT64_MAX; uint64_t index = INT64_MAX;
DRWLock::WRLockGuard guard(io_config_lock_); DRWLock::WRLockGuard guard(io_config_lock_);
if (OB_UNLIKELY(!is_user_group(group_id))) { if (OB_UNLIKELY(!is_valid_resource_group(group_id))) {
ret = OB_INVALID_CONFIG; ret = OB_INVALID_CONFIG;
LOG_WARN("invalid group id", K(ret), K(tenant_id_), K(group_id)); LOG_WARN("invalid group id", K(ret), K(tenant_id_), K(group_id));
} else if (min_percent < 0 || min_percent > 100 || } else if (min_percent < 0 || min_percent > 100 ||